René's URL Explorer Experiment


Title: Clean up the `CALL` sequence · Issue #105848 · python/cpython · GitHub

Open Graph Title: Clean up the `CALL` sequence · Issue #105848 · python/cpython

X Title: Clean up the `CALL` sequence · Issue #105848 · python/cpython

Description: The bytecode sequence for calls has gotten better in 3.12, but I think it can still be improved in a couple of ways: First, we can start either pushing NULL or a tuple of kwnames onto the stack immediately before calls, rather than somet...

Open Graph Description: The bytecode sequence for calls has gotten better in 3.12, but I think it can still be improved in a couple of ways: First, we can start either pushing NULL or a tuple of kwnames onto the stack imm...

X Description: The bytecode sequence for calls has gotten better in 3.12, but I think it can still be improved in a couple of ways: First, we can start either pushing NULL or a tuple of kwnames onto the stack imm...

Opengraph URL: https://github.com/python/cpython/issues/105848

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Clean up the `CALL` sequence","articleBody":"The bytecode sequence for calls has gotten better in 3.12, but I think it can still be improved in a couple of ways:\r\n- First, we can start either pushing `NULL` or a tuple of `kwnames` onto the stack immediately before calls, rather than sometimes stashing `kwnames` away in a local eval loop variable via the `KW_NAMES` opcode. This *should* free up a register around calls, and it's nice to do anyways since it makes the bytecode more regular (and the stack is really where this sort of stuff belongs).\r\n- Once that is done, we can use the low bit of the `CALL` oparg to indicate whether or not to expect `kwnames` on the stack. This should get rid of lots of new `PUSH_NULL`/`CALL` pairs.\r\n- Separate from the above, but still sort of related: it's a bit awkward that our method call optimization either leaves `[callable, self, args...]` or `[NULL, callable, args...]` on the stack, since it means that `CALL` (and most of its specializations) have to do an awkward swap in order to load the \"correct\" callable. This can be simplified by always entering calls with `[callable, self_or_null, args...]` on the stack, so that the callable is always in the same position.\r\n\r\nAfter this is all said and done, the `CALL` stack effect will look something like:\r\n\r\n```c\r\ninst(CALL, (counter/1, cache/2, callable, self_or_null, args[oparg \u003e\u003e 1], kwnames if (oparg \u0026 1) -- res)) {\r\n    // ...\r\n}\r\n```\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-105849\n* gh-107788\n* gh-108496\n* gh-109300\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/brandtbucher","@type":"Person","name":"brandtbucher"},"datePublished":"2023-06-16T05:54:45.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/105848/cpython/issues/105848"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:306d7aae-4118-5394-3ccf-c6c888a4c596
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC9DA:A7972:D8DD75:12D36B5:696A8328
html-safe-noncec71f194e1a9d845eaffebe65f4de833b9b56454c27d61e95562be7b4ac276858
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOURBOkE3OTcyOkQ4REQ3NToxMkQzNkI1OjY5NkE4MzI4IiwidmlzaXRvcl9pZCI6Ijg3ODU1NDE5NzI5NTc0OTYxMDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac74c2a69ca150bf5bb4e4d806ff3ba497f512c8550cef90df2e47b0470ed0eb34
hovercard-subject-tagissue:1759969934
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/105848/issue_layout
twitter:imagehttps://opengraph.githubassets.com/25337a3eff7c2cc323e19b30419553d672c8ad879a49396987c4a0b4aa275efd/python/cpython/issues/105848
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/25337a3eff7c2cc323e19b30419553d672c8ad879a49396987c4a0b4aa275efd/python/cpython/issues/105848
og:image:altThe bytecode sequence for calls has gotten better in 3.12, but I think it can still be improved in a couple of ways: First, we can start either pushing NULL or a tuple of kwnames onto the stack imm...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebrandtbucher
hostnamegithub.com
expected-hostnamegithub.com
None913560fa317c3c5a71e34f9b19253c9f09d02b4b958a86c2a56f4c8541116377
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5998c30593994bf2589055aef7b22d368a499367
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/105848#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F105848
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F105848
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/105848
Reloadhttps://github.com/python/cpython/issues/105848
Reloadhttps://github.com/python/cpython/issues/105848
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/105848
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/105848
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/105848
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/105848
Clean up the CALL sequencehttps://github.com/python/cpython/issues/105848#top
https://github.com/brandtbucher
3.13bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.13%22
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
triagedThe issue has been accepted as valid by a triager.https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22triaged%22
https://github.com/brandtbucher
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
on Jun 16, 2023https://github.com/python/cpython/issues/105848#issue-1759969934
GH-105848: Get rid of KW_NAMES #105849https://github.com/python/cpython/pull/105849
GH-105848: Simplify the arrangement of CALL's stack #107788https://github.com/python/cpython/pull/107788
GH-105848: Get rid of KW_NAMES (again) #108496https://github.com/python/cpython/pull/108496
GH-105848: Replace KW_NAMES + CALL with LOAD_CONST + CALL_KW #109300https://github.com/python/cpython/pull/109300
brandtbucherhttps://github.com/brandtbucher
3.13bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.13%22
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
triagedThe issue has been accepted as valid by a triager.https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22triaged%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.