René's URL Explorer Experiment


Title: Strange interaction between `typing.Protocol` and unrelated `isinstance()` checks · Issue #105144 · python/cpython · GitHub

Open Graph Title: Strange interaction between `typing.Protocol` and unrelated `isinstance()` checks · Issue #105144 · python/cpython

X Title: Strange interaction between `typing.Protocol` and unrelated `isinstance()` checks · Issue #105144 · python/cpython

Description: On main, an isinstance() check against Sized works just the same as it does on Python 3.11: >>> from typing import Sized >>> isinstance(1, Sized) False However! If you first subclass Sized like this, TypeError is raised on that isinstanc...

Open Graph Description: On main, an isinstance() check against Sized works just the same as it does on Python 3.11: >>> from typing import Sized >>> isinstance(1, Sized) False However! If you first subclass Sized like thi...

X Description: On main, an isinstance() check against Sized works just the same as it does on Python 3.11: >>> from typing import Sized >>> isinstance(1, Sized) False However! If you first subcl...

Opengraph URL: https://github.com/python/cpython/issues/105144

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Strange interaction between `typing.Protocol` and unrelated `isinstance()` checks","articleBody":"On `main`, an `isinstance()` check against `Sized` works just the same as it does on Python 3.11:\r\n\r\n```pycon\r\n\u003e\u003e\u003e from typing import Sized\r\n\u003e\u003e\u003e isinstance(1, Sized)\r\nFalse\r\n```\r\n\r\nHowever! If you first subclass `Sized` like this, `TypeError` is raised on that `isinstance()` check!\r\n\r\n```pycon\r\n\u003e\u003e\u003e from typing import Sized, Protocol\r\n\u003e\u003e\u003e class Foo(Sized, Protocol): pass\r\n...\r\n\u003e\u003e\u003e isinstance(1, Sized)\r\nTraceback (most recent call last):\r\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\r\n  File \"C:\\Users\\alexw\\coding\\cpython\\Lib\\typing.py\", line 1153, in __instancecheck__\r\n    return self.__subclasscheck__(type(obj))\r\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n  File \"C:\\Users\\alexw\\coding\\cpython\\Lib\\typing.py\", line 1428, in __subclasscheck__\r\n    return issubclass(cls, self.__origin__)\r\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n  File \"\u003cfrozen abc\u003e\", line 123, in __subclasscheck__\r\n  File \"C:\\Users\\alexw\\coding\\cpython\\Lib\\typing.py\", line 1793, in __subclasscheck__\r\n    return super().__subclasscheck__(other)\r\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n  File \"\u003cfrozen abc\u003e\", line 123, in __subclasscheck__\r\n  File \"C:\\Users\\alexw\\coding\\cpython\\Lib\\typing.py\", line 1876, in _proto_hook\r\n    raise TypeError(\"Instance and class checks can only be used with\"\r\nTypeError: Instance and class checks can only be used with @runtime_checkable protocols\r\n```\r\n\r\nThis was originally reported by @vnmabus in https://github.com/python/typing_extensions/issues/207.\r\n\r\nNote that (because of the `abc`-module cache), this _doesn't_ reproduce if you do an `isinstance()` check _before_ subclassing `typing.Sized`:\r\n\r\n```pycon\r\n\u003e\u003e\u003e import typing\r\n\u003e\u003e\u003e isinstance(1, typing.Sized)\r\nFalse\r\n\u003e\u003e\u003e class Foo(typing.Sized, typing.Protocol): pass\r\n...\r\n\u003e\u003e\u003e isinstance(1, typing.Sized)\r\nFalse\r\n```\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-105152\n* gh-105159\n* gh-105160\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/AlexWaygood","@type":"Person","name":"AlexWaygood"},"datePublished":"2023-05-31T14:30:55.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/105144/cpython/issues/105144"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:86bc7b32-40bf-6cbf-ac75-31c9ceb635c8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8AAE:2B0240:7CBB5:A56CA:6969CA7A
html-safe-noncee52936955ddea094cbc6d48273f52abecff1afb66a7694a8d23f121b095a4906
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUFFOjJCMDI0MDo3Q0JCNTpBNTZDQTo2OTY5Q0E3QSIsInZpc2l0b3JfaWQiOiI3MjA3MzczNzA3Njc0MjQxNjU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac90c447122f29acbce49e6a8d96427b261df110176d5292362960fe37c3512eef
hovercard-subject-tagissue:1734369501
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/105144/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ea447773547ce534228aff91b28e208ef2b6a1224cdb6461b6b41932da4b2265/python/cpython/issues/105144
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ea447773547ce534228aff91b28e208ef2b6a1224cdb6461b6b41932da4b2265/python/cpython/issues/105144
og:image:altOn main, an isinstance() check against Sized works just the same as it does on Python 3.11: >>> from typing import Sized >>> isinstance(1, Sized) False However! If you first subclass Sized like thi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAlexWaygood
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/105144#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F105144
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F105144
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/105144
Reloadhttps://github.com/python/cpython/issues/105144
Reloadhttps://github.com/python/cpython/issues/105144
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/105144
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/105144
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/105144
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/105144
Strange interaction between typing.Protocol and unrelated isinstance() checkshttps://github.com/python/cpython/issues/105144#top
https://github.com/AlexWaygood
3.12only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.12%22
3.13bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.13%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-typinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-typing%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/AlexWaygood
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on May 31, 2023https://github.com/python/cpython/issues/105144#issue-1734369501
@vnmabushttps://github.com/vnmabus
python/typing_extensions#207https://github.com/python/typing_extensions/issues/207
gh-105144: Runtime-checkable protocols: move all 'sanity checks' to _ProtocolMeta.__subclasscheck__ #105152https://github.com/python/cpython/pull/105152
gh-105144: abc: Suppress errors raised by unrelated other subclasses #105159https://github.com/python/cpython/pull/105159
[3.12] gh-105144: Runtime-checkable protocols: move all 'sanity checks' to _ProtocolMeta.__subclasscheck__ (GH-105152) #105160https://github.com/python/cpython/pull/105160
AlexWaygoodhttps://github.com/AlexWaygood
3.12only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.12%22
3.13bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.13%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-typinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-typing%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.