René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Certain Tkinter tests fail on Tk 8.7 due to TIP 577","articleBody":"One of the broader effects of [TIP 577](https://core.tcl-lang.org/tips/doc/trunk/tip/577.md) on Tk 8.7 (and to a greater degree under Tcl 9.0 than Tcl 8.7) is that it makes widget commands/options/etc. more consistent about using empty string as the reserved “none” value, rather than e.g. `\"none\"` or `-1`. python/cpython#103685 was one instance of this.\r\n\r\nSeveral options already accepted the empty string under Tk 8.6, but this was not reflected in the `bad option…` error messages. Tk 8.7 corrects this, which breaks several Tkinter tests with hardcoded error messages:\r\n\r\n```\r\n======================================================================\r\nFAIL: test_place_configure_relheight (test.test_tkinter.test_geometry_managers.PlaceTest.test_place_configure_relheight)\r\n----------------------------------------------------------------------\r\n_tkinter.TclError: expected floating-point number or \"\" but got \"abcd\"\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/test_geometry_managers.py\", line 426, in test_place_configure_relheight\r\n    with self.assertRaisesRegex(TclError, 'expected floating-point number '\r\nAssertionError: \"expected floating-point number but got \"abcd\"\" does not match \"expected floating-point number or \"\" but got \"abcd\"\"\r\n\r\n======================================================================\r\nFAIL: test_place_configure_relwidth (test.test_tkinter.test_geometry_managers.PlaceTest.test_place_configure_relwidth)\r\n----------------------------------------------------------------------\r\n_tkinter.TclError: expected floating-point number or \"\" but got \"abcd\"\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/test_geometry_managers.py\", line 414, in test_place_configure_relwidth\r\n    with self.assertRaisesRegex(TclError, 'expected floating-point number '\r\nAssertionError: \"expected floating-point number but got \"abcd\"\" does not match \"expected floating-point number or \"\" but got \"abcd\"\"\r\n\r\n======================================================================\r\nFAIL: test_configure_overrelief (test.test_tkinter.test_widgets.ButtonTest.test_configure_overrelief)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 448, in test_configure_overrelief\r\n    self.checkReliefParam(widget, 'overrelief')\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 161, in checkReliefParam\r\n    self.checkInvalidParam(widget, name, 'spam',\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 63, in checkInvalidParam\r\n    self.assertEqual(str(cm.exception), errmsg)\r\nAssertionError: 'bad relief \"spam\": must be flat, groove, raised, ridge, solid, sunken, or \"\"' != 'bad relief \"spam\": must be flat, groove, raised, ridge, solid, or sunken'\r\n- bad relief \"spam\": must be flat, groove, raised, ridge, solid, sunken, or \"\"\r\n?                                                                      -------\r\n+ bad relief \"spam\": must be flat, groove, raised, ridge, solid, or sunken\r\n?                                                                +++\r\n\r\n======================================================================\r\nFAIL: test_configure_overrelief (test.test_tkinter.test_widgets.CheckbuttonTest.test_configure_overrelief)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 448, in test_configure_overrelief\r\n    self.checkReliefParam(widget, 'overrelief')\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 161, in checkReliefParam\r\n    self.checkInvalidParam(widget, name, 'spam',\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 63, in checkInvalidParam\r\n    self.assertEqual(str(cm.exception), errmsg)\r\nAssertionError: 'bad relief \"spam\": must be flat, groove, raised, ridge, solid, sunken, or \"\"' != 'bad relief \"spam\": must be flat, groove, raised, ridge, solid, or sunken'\r\n- bad relief \"spam\": must be flat, groove, raised, ridge, solid, sunken, or \"\"\r\n?                                                                      -------\r\n+ bad relief \"spam\": must be flat, groove, raised, ridge, solid, or sunken\r\n?                                                                +++\r\n\r\n======================================================================\r\nFAIL: test_configure_proxyrelief (test.test_tkinter.test_widgets.PanedWindowTest.test_configure_proxyrelief)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/support.py\", line 94, in newtest\r\n    test(self)\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/test_widgets.py\", line 1245, in test_configure_proxyrelief\r\n    self.checkReliefParam(widget, 'proxyrelief')\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 161, in checkReliefParam\r\n    self.checkInvalidParam(widget, name, 'spam',\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 63, in checkInvalidParam\r\n    self.assertEqual(str(cm.exception), errmsg)\r\nAssertionError: 'bad relief \"spam\": must be flat, groove, raised, ridge, solid, sunken, or \"\"' != 'bad relief \"spam\": must be flat, groove, raised, ridge, solid, or sunken'\r\n- bad relief \"spam\": must be flat, groove, raised, ridge, solid, sunken, or \"\"\r\n?                                                                      -------\r\n+ bad relief \"spam\": must be flat, groove, raised, ridge, solid, or sunken\r\n?                                                                +++\r\n\r\n======================================================================\r\nFAIL: test_configure_overrelief (test.test_tkinter.test_widgets.RadiobuttonTest.test_configure_overrelief)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 448, in test_configure_overrelief\r\n    self.checkReliefParam(widget, 'overrelief')\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 161, in checkReliefParam\r\n    self.checkInvalidParam(widget, name, 'spam',\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 63, in checkInvalidParam\r\n    self.assertEqual(str(cm.exception), errmsg)\r\nAssertionError: 'bad relief \"spam\": must be flat, groove, raised, ridge, solid, sunken, or \"\"' != 'bad relief \"spam\": must be flat, groove, raised, ridge, solid, or sunken'\r\n- bad relief \"spam\": must be flat, groove, raised, ridge, solid, sunken, or \"\"\r\n?                                                                      -------\r\n+ bad relief \"spam\": must be flat, groove, raised, ridge, solid, or sunken\r\n?                                                                +++\r\n```\r\n\r\nIn a few other cases, empty string has become a valid input, so tests which expect an exception to be raised now fail instead:\r\n\r\n```\r\n======================================================================\r\nFAIL: test_configure_underline (test.test_tkinter.test_widgets.ButtonTest.test_configure_underline)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 418, in test_configure_underline\r\n    self.checkIntegerParam(widget, 'underline', 0, 1, 10)\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 77, in checkIntegerParam\r\n    self.checkInvalidParam(widget, name, '',\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 60, in checkInvalidParam\r\n    with self.assertRaises(tkinter.TclError) as cm:\r\nAssertionError: TclError not raised\r\n\r\n======================================================================\r\nFAIL: test_configure_underline (test.test_tkinter.test_widgets.CheckbuttonTest.test_configure_underline)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 418, in test_configure_underline\r\n    self.checkIntegerParam(widget, 'underline', 0, 1, 10)\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 77, in checkIntegerParam\r\n    self.checkInvalidParam(widget, name, '',\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 60, in checkInvalidParam\r\n    with self.assertRaises(tkinter.TclError) as cm:\r\nAssertionError: TclError not raised\r\n\r\n======================================================================\r\nFAIL: test_configure_underline (test.test_tkinter.test_widgets.LabelTest.test_configure_underline)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 418, in test_configure_underline\r\n    self.checkIntegerParam(widget, 'underline', 0, 1, 10)\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 77, in checkIntegerParam\r\n    self.checkInvalidParam(widget, name, '',\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 60, in checkInvalidParam\r\n    with self.assertRaises(tkinter.TclError) as cm:\r\nAssertionError: TclError not raised\r\n\r\n======================================================================\r\nFAIL: test_configure_underline (test.test_tkinter.test_widgets.MenubuttonTest.test_configure_underline)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 418, in test_configure_underline\r\n    self.checkIntegerParam(widget, 'underline', 0, 1, 10)\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 77, in checkIntegerParam\r\n    self.checkInvalidParam(widget, name, '',\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 60, in checkInvalidParam\r\n    with self.assertRaises(tkinter.TclError) as cm:\r\nAssertionError: TclError not raised\r\n\r\n======================================================================\r\nFAIL: test_configure_underline (test.test_tkinter.test_widgets.OptionMenuTest.test_configure_underline)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 418, in test_configure_underline\r\n    self.checkIntegerParam(widget, 'underline', 0, 1, 10)\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 77, in checkIntegerParam\r\n    self.checkInvalidParam(widget, name, '',\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 60, in checkInvalidParam\r\n    with self.assertRaises(tkinter.TclError) as cm:\r\nAssertionError: TclError not raised\r\n\r\n======================================================================\r\nFAIL: test_configure_underline (test.test_tkinter.test_widgets.RadiobuttonTest.test_configure_underline)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 418, in test_configure_underline\r\n    self.checkIntegerParam(widget, 'underline', 0, 1, 10)\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 77, in checkIntegerParam\r\n    self.checkInvalidParam(widget, name, '',\r\n  File \"/Users/user/git/cpython/Lib/test/test_tkinter/widget_tests.py\", line 60, in checkInvalidParam\r\n    with self.assertRaises(tkinter.TclError) as cm:\r\nAssertionError: TclError not raised\r\n```\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-105047\n* gh-120824\n* gh-120864\n* gh-120865\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/chrstphrchvz","@type":"Person","name":"chrstphrchvz"},"datePublished":"2023-05-24T11:15:23.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/104855/cpython/issues/104855"}