René's URL Explorer Experiment


Title: Typing: runtime-checkable protocols are broken on `main` · Issue #104555 · python/cpython · GitHub

Open Graph Title: Typing: runtime-checkable protocols are broken on `main` · Issue #104555 · python/cpython

X Title: Typing: runtime-checkable protocols are broken on `main` · Issue #104555 · python/cpython

Description: PEP-695 protocols don't work as intended: Here's the behaviour you get with protocols that use pre-PEP 695 syntax, which is correct: >>> from typing import Protocol, runtime_checkable, TypeVar >>> T_co = TypeVar("T_co", covariant=True) >...

Open Graph Description: PEP-695 protocols don't work as intended: Here's the behaviour you get with protocols that use pre-PEP 695 syntax, which is correct: >>> from typing import Protocol, runtime_checkable, TypeVar >>> ...

X Description: PEP-695 protocols don't work as intended: Here's the behaviour you get with protocols that use pre-PEP 695 syntax, which is correct: >>> from typing import Protocol, runtime_checka...

Opengraph URL: https://github.com/python/cpython/issues/104555

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Typing: runtime-checkable protocols are broken on `main`","articleBody":"PEP-695 protocols don't work as intended:\r\n\r\nHere's the behaviour you get with protocols that use pre-PEP 695 syntax, which is correct:\r\n\r\n```pycon\r\n\u003e\u003e\u003e from typing import Protocol, runtime_checkable, TypeVar\r\n\u003e\u003e\u003e T_co = TypeVar(\"T_co\", covariant=True)\r\n\u003e\u003e\u003e @runtime_checkable\r\n... class SupportsAbsOld(Protocol[T_co]):\r\n...     def __abs__(self) -\u003e T_co:\r\n...         ...\r\n...\r\n\u003e\u003e\u003e isinstance(0, SupportsAbsOld)\r\nTrue\r\n\u003e\u003e\u003e issubclass(float, SupportsAbsOld)\r\nTrue\r\n```\r\n\r\nAnd here's the behaviour you get on `main` with protocols that use PEP 695 syntax, which is incorrect:\r\n\r\n```pycon\r\n\u003e\u003e\u003e @runtime_checkable\r\n... class SupportsAbsNew[T_co](Protocol):\r\n...     def __abs__(self) -\u003e T_co:\r\n...         ...\r\n...\r\n\u003e\u003e\u003e isinstance(0, SupportsAbsNew)\r\nFalse\r\n\u003e\u003e\u003e issubclass(float, SupportsAbsNew)\r\nTraceback (most recent call last):\r\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\r\n  File \"C:\\Users\\alexw\\coding\\cpython\\Lib\\abc.py\", line 123, in __subclasscheck__\r\n    return _abc_subclasscheck(cls, subclass)\r\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n  File \"C:\\Users\\alexw\\coding\\cpython\\Lib\\typing.py\", line 1875, in _proto_hook\r\n    raise TypeError(\"Protocols with non-method members\"\r\nTypeError: Protocols with non-method members don't support issubclass()\r\n```\r\n\r\n\u003c!-- gh-linked-prs --\u003e\r\n### Linked PRs\r\n* gh-104556\r\n* gh-104559\n\u003c!-- /gh-linked-prs --\u003e\r\n","author":{"url":"https://github.com/AlexWaygood","@type":"Person","name":"AlexWaygood"},"datePublished":"2023-05-16T15:22:30.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":23},"url":"https://github.com/104555/cpython/issues/104555"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:b161f33a-0b6c-e100-0587-3248ebbc364c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAB22:2DA0A8:9363EF:C5F7F8:6969BF56
html-safe-nonce6a5b6958a3608620e7fc58df26344008f463521e16b22d367ac7afc7ee4c4638
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjIyOjJEQTBBODo5MzYzRUY6QzVGN0Y4OjY5NjlCRjU2IiwidmlzaXRvcl9pZCI6IjcwOTAxMDgxODk4MjE3NDcwMzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc96e527c7b597e6c5ede632e4f765253efca7e6fc612c7b7e8c2558495775a04
hovercard-subject-tagissue:1712247778
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/104555/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3f1b8c6dfa46d1e7112e51b976b56c1073e9e45d118af52a737217e5778387ea/python/cpython/issues/104555
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3f1b8c6dfa46d1e7112e51b976b56c1073e9e45d118af52a737217e5778387ea/python/cpython/issues/104555
og:image:altPEP-695 protocols don't work as intended: Here's the behaviour you get with protocols that use pre-PEP 695 syntax, which is correct: >>> from typing import Protocol, runtime_checkable, TypeVar >>> ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAlexWaygood
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/104555#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F104555
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F104555
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/104555
Reloadhttps://github.com/python/cpython/issues/104555
Reloadhttps://github.com/python/cpython/issues/104555
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/104555
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/104555
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/104555
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/104555
#104559https://github.com/python/cpython/pull/104559
#104556https://github.com/python/cpython/pull/104556
Typing: runtime-checkable protocols are broken on mainhttps://github.com/python/cpython/issues/104555#top
#104559https://github.com/python/cpython/pull/104559
#104556https://github.com/python/cpython/pull/104556
https://github.com/JelleZijlstra
https://github.com/AlexWaygood
topic-typinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-typing%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/AlexWaygood
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on May 16, 2023https://github.com/python/cpython/issues/104555#issue-1712247778
PEP-695https://peps.python.org/695
gh-104555: Fix isinstance() and issubclass() for runtime-checkable protocols that use PEP 695 #104556https://github.com/python/cpython/pull/104556
gh-104555: Runtime-checkable protocols: Don't let previous calls to isinstance() influence whether issubclass() raises an exception #104559https://github.com/python/cpython/pull/104559
AlexWaygoodhttps://github.com/AlexWaygood
JelleZijlstrahttps://github.com/JelleZijlstra
topic-typinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-typing%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.