René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Run `mypy` on `cases_generator`","articleBody":"# Feature or enhancement\r\n\r\nAfter https://github.com/python/cpython/pull/104421 is merged, we now have the precedent and the needed infrastructure to run `mypy` on things that support type annotations in `Tools/`\r\n\r\n# Pitch\r\n\r\nMaybe we should run it on `Tools/cases_generator`? It has all annotations in place, it needs very little work. Right now `mypy` finds only 24 errors.\r\n\r\nFull list:\r\n\r\n```python\r\n» mypy .\r\nparser.py:22: error: Return value expected  [return-value]\r\n                return\r\n                ^~~~~~\r\nparser.py:142: error: Missing return statement  [return]\r\n        def definition(self) -\u003e InstDef | Super | Macro | Family | None:\r\n        ^\r\nparser.py:168: error: Module has no attribute \"OVERRIDE\"  [attr-defined]\r\n            override = bool(self.expect(lx.OVERRIDE))\r\n                                        ^~~~~~~~~~~\r\nparser.py:169: error: Module has no attribute \"REGISTER\"  [attr-defined]\r\n            register = bool(self.expect(lx.REGISTER))\r\n                                        ^~~~~~~~~~~\r\nparser.py:177: error: Argument 3 to \"InstHeader\" has incompatible type \"str\";\r\nexpected \"Literal['inst', 'op', 'legacy']\"  [arg-type]\r\n    ...                 return InstHeader(override, register, kind, name, inp, outp...\r\n                                                              ^~~~\r\nparser.py:200: error: Incompatible return value type (got\r\n\"List[Union[StackEffect, CacheEffect, Node]]\", expected\r\n\"Optional[List[Union[StackEffect, CacheEffect]]]\")  [return-value]\r\n                        return [inp] + rest\r\n                               ^~~~~~~~~~~~\r\nparser.py:202: error: List item 0 has incompatible type \"Node\"; expected\r\n\"Union[StackEffect, CacheEffect]\"  [list-item]\r\n                return [inp]\r\n                        ^~~\r\nparser.py:228: error: Missing return statement  [return]\r\n        def cache_effect(self) -\u003e CacheEffect | None:\r\n        ^\r\nparser.py:241: error: Missing return statement  [return]\r\n        def stack_effect(self) -\u003e StackEffect | None:\r\n        ^\r\nparser.py:249: error: Module has no attribute \"IF\"  [attr-defined]\r\n                if self.expect(lx.IF):\r\n                               ^~~~~\r\nparser.py:284: error: Missing return statement  [return]\r\n        def super_def(self) -\u003e Super | None:\r\n        ^\r\nparser.py:295: error: Missing return statement  [return]\r\n        def ops(self) -\u003e list[OpName] | None:\r\n        ^\r\nparser.py:304: error: Missing return statement  [return]\r\n        def op(self) -\u003e OpName | None:\r\n        ^\r\nparser.py:309: error: Missing return statement  [return]\r\n        def macro_def(self) -\u003e Macro | None:\r\n        ^\r\nparser.py:320: error: Missing return statement  [return]\r\n        def uops(self) -\u003e list[UOp] | None:\r\n        ^\r\nparser.py:328: error: Incompatible return value type (got \"List[Node]\", expected\r\n\"Optional[List[Union[OpName, CacheEffect]]]\")  [return-value]\r\n                return uops\r\n                       ^~~~\r\nparser.py:331: error: Missing return statement  [return]\r\n        def uop(self) -\u003e UOp | None:\r\n        ^\r\nparser.py:384: error: Missing return statement  [return]\r\n        def block(self) -\u003e Block | None:\r\n        ^\r\ngenerate_cases.py:395: error: Item \"None\" of \"Optional[Context]\" has no attribute\r\n\"owner\"  [union-attr]\r\n            filename = context.owner.filename\r\n                       ^~~~~~~~~~~~~\r\ngenerate_cases.py:598: error: Incompatible types in assignment (expression has type\r\n\"Optional[Node]\", variable has type \"Union[InstDef, Super, Macro, Family, None]\") \r\n[assignment]\r\n            while thing := psr.definition():\r\n                           ^~~~~~~~~~~~~~~~\r\ngenerate_cases.py:664: error: Item \"None\" of \"Optional[Family]\" has no attribute\r\n\"name\"  [union-attr]\r\n                                f\"Instruction {member} is a member of multiple f...\r\n                                ^\r\ngenerate_cases.py:675: error: Item \"None\" of \"Optional[Family]\" has no attribute\r\n\"name\"  [union-attr]\r\n                                        f\"Component {part.instr.name} of macro {...\r\n                                        ^\r\ntest_generator.py:46: error: Missing positional argument \"metadata_filename\" in call\r\nto \"Analyzer\"  [call-arg]\r\n        a = generate_cases.Analyzer(temp_input.name, temp_output.name)\r\n            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\ntest_generator.py:46: error: Argument 1 to \"Analyzer\" has incompatible type \"str\";\r\nexpected \"List[str]\"  [arg-type]\r\n        a = generate_cases.Analyzer(temp_input.name, temp_output.name)\r\n                                    ^~~~~~~~~~~~~~~\r\nFound 24 errors in 3 files (checked 5 source files)\r\n```\r\n\r\nIf @gvanrossum finds it useful, I can surely work on this.\r\nCC @AlexWaygood \n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-108090\n* gh-108112\n* gh-108454\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/sobolevn","@type":"Person","name":"sobolevn"},"datePublished":"2023-05-15T10:21:09.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/104504/cpython/issues/104504"}