René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Error handling bugs in ast.c","articleBody":"in validate_pattern, there are two places where in case of error we break out of a loop, but we also need to break out of the switch.\r\n\r\n```\r\n--- a/Python/ast.c\r\n+++ b/Python/ast.c\r\n@@ -580,7 +580,9 @@ validate_pattern(struct validator *state, pattern_ty p, int star_ok)\r\n                     break;\r\n                 }\r\n             }\r\n-\r\n+            if (ret == 0) {\r\n+                break;\r\n+            }\r\n             ret = validate_patterns(state, p-\u003ev.MatchMapping.patterns, /*star_ok=*/0);\r\n             break;\r\n         case MatchClass_kind:\r\n@@ -620,6 +622,9 @@ validate_pattern(struct validator *state, pattern_ty p, int star_ok)\r\n                 }\r\n             }\r\n \r\n+            if (ret == 0) {\r\n+                break;\r\n+            }\r\n             if (!validate_patterns(state, p-\u003ev.MatchClass.patterns, /*star_ok=*/0)) {\r\n                 ret = 0;\r\n                 break;\r\n```\r\n\r\nIf we don't do this we can end up calling _PyAST_Compile with an error set.\r\n\r\n\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-104483\n* gh-104514\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/iritkatriel","@type":"Person","name":"iritkatriel"},"datePublished":"2023-05-14T18:51:50.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/104482/cpython/issues/104482"}