René's URL Explorer Experiment


Title: Add type annotations to clinic.py · Issue #104050 · python/cpython · GitHub

Open Graph Title: Add type annotations to clinic.py · Issue #104050 · python/cpython

X Title: Add type annotations to clinic.py · Issue #104050 · python/cpython

Description: Feature or enhancement Gradually add type hints to clinic.py. Pitch Adding type hints to clinic.py will make it easier to debug, fix bugs, do code review, add new features, and triage. IMO, the churn is worth the effort in the long run. ...

Open Graph Description: Feature or enhancement Gradually add type hints to clinic.py. Pitch Adding type hints to clinic.py will make it easier to debug, fix bugs, do code review, add new features, and triage. IMO, the chu...

X Description: Feature or enhancement Gradually add type hints to clinic.py. Pitch Adding type hints to clinic.py will make it easier to debug, fix bugs, do code review, add new features, and triage. IMO, the chu...

Opengraph URL: https://github.com/python/cpython/issues/104050

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Add type annotations to clinic.py","articleBody":"# Feature or enhancement\r\n\r\nGradually add type hints to clinic.py.\r\n\r\n# Pitch\r\n\r\nAdding type hints to clinic.py will make it easier to debug, fix bugs, do code review, add new features, and triage. IMO, the churn is worth the effort in the long run.\r\n\r\n# Previous discussion\r\n\r\nSince adding typing to the CPython code base has been a slightly controversial topic (obviously controversial for `Lib/`), I created a [topic on Discourse](https://discuss.python.org/t/consider-adding-type-hints-to-clinic-py/26320?u=erlendaasland) and asked for feedback. So far, I have not received any discouragements :)\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-104421\n* gh-104538\n* gh-104543\n* gh-104544\n* gh-104547\n* gh-104588\n* gh-104589\n* gh-104626\n* gh-104628\n* gh-104631\n* gh-104648\n* gh-104704\n* gh-104705\n* gh-104706\n* gh-106343\n* gh-106354\n* gh-106357\n* gh-106376\n* gh-106431\n* gh-106435\n* gh-106437\n* gh-106519\n* gh-106655\n* gh-106699\n* gh-106732\n* gh-106750\n* gh-106760\n* gh-106810\n* gh-106929\n* gh-106932\n* gh-106934\n* gh-106935\n* gh-107074\n* gh-107192\n* gh-107200\n* gh-107206\n* gh-107207\n* gh-107209\n* gh-107210\n* gh-107225\n* gh-107264\n* gh-107288\n* gh-107293\n* gh-107294\n* gh-107399\n* gh-107405\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/erlend-aasland","@type":"Person","name":"erlend-aasland"},"datePublished":"2023-05-01T17:47:45.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":9},"url":"https://github.com/104050/cpython/issues/104050"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:86d10d6e-25a9-61ec-b237-2763507af9eb
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8C8E:26AE24:664156:8A31ED:69695090
html-safe-nonce0434da1752e7377ea4b3ed1c0a763a785f45205c8701ed6405d5386c44d49043
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzhFOjI2QUUyNDo2NjQxNTY6OEEzMUVEOjY5Njk1MDkwIiwidmlzaXRvcl9pZCI6IjMwMjIyNzc5MzcxNjgyMDgwMTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac374b622288424247662c19deb2bcaecff8fe800b1cb836b31a342b4713a40fb6
hovercard-subject-tagissue:1691115674
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/104050/issue_layout
twitter:imagehttps://opengraph.githubassets.com/69c6f60dcb9971325c384ae2b150db3045270e7878d983131887cd958c99e17e/python/cpython/issues/104050
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/69c6f60dcb9971325c384ae2b150db3045270e7878d983131887cd958c99e17e/python/cpython/issues/104050
og:image:altFeature or enhancement Gradually add type hints to clinic.py. Pitch Adding type hints to clinic.py will make it easier to debug, fix bugs, do code review, add new features, and triage. IMO, the chu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameerlend-aasland
hostnamegithub.com
expected-hostnamegithub.com
None54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released69ac0477df0f87da03b8b06cebd187012d7a930
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/104050#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F104050
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F104050
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/104050
Reloadhttps://github.com/python/cpython/issues/104050
Reloadhttps://github.com/python/cpython/issues/104050
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/104050
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/104050
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/104050
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/104050
#107405https://github.com/python/cpython/pull/107405
Add type annotations to clinic.pyhttps://github.com/python/cpython/issues/104050#top
#107405https://github.com/python/cpython/pull/107405
https://github.com/erlend-aasland
topic-argument-clinichttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-argument-clinic%22
topic-typinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-typing%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com/erlend-aasland
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
on May 1, 2023https://github.com/python/cpython/issues/104050#issue-1691115674
topic on Discoursehttps://discuss.python.org/t/consider-adding-type-hints-to-clinic-py/26320?u=erlendaasland
gh-104050: Run mypy on clinic.py in CI #104421https://github.com/python/cpython/pull/104421
gh-104050: Add basic typing to CConverter in clinic.py #104538https://github.com/python/cpython/pull/104538
gh-104050: Don't star-import 'types' in Argument Clinic #104543https://github.com/python/cpython/pull/104543
gh-104050: Add more annotations to Tools/clinic.py #104544https://github.com/python/cpython/pull/104544
gh-104050: Add typing to Argument Clinic converters #104547https://github.com/python/cpython/pull/104547
gh-104050: Add type hints to Argument Clinic converter keywords #104588https://github.com/python/cpython/pull/104588
gh-104050: Add type annotations to sentinels in Argument Clinic #104589https://github.com/python/cpython/pull/104589
gh-104050: Improve some typing around defaults and sentinel values #104626https://github.com/python/cpython/pull/104626
gh-104050: Add more type annotations to Argument Clinic #104628https://github.com/python/cpython/pull/104628
gh-104050: Add more type annotations to Argument Clinic #104631https://github.com/python/cpython/pull/104631
gh-104050: Argument clinic: Add annotations to the LandMine class #104648https://github.com/python/cpython/pull/104648
gh-104050: Add basic type hints to Argument Clinic DSL parser #104704https://github.com/python/cpython/pull/104704
gh-104050: Add basic type hints to Argument Clinic clinic class #104705https://github.com/python/cpython/pull/104705
gh-104050: Annotate Argument Clinic return converters #104706https://github.com/python/cpython/pull/104706
gh-104050: Add more type hints to Argument Clinic DSLParser() #106343https://github.com/python/cpython/pull/106343
gh-104050: Add more type hints to Argument Clinic DSLParser() #106354https://github.com/python/cpython/pull/106354
gh-104050: Annotate Argument Clinic DSLParser attributes #106357https://github.com/python/cpython/pull/106357
gh-104050: Annotate more Argument Clinic DSLParser state methods #106376https://github.com/python/cpython/pull/106376
gh-104050: Annotate Argument Clinic parameter permutation helpers #106431https://github.com/python/cpython/pull/106431
gh-104050: Annotate toplevel functions in clinic.py #106435https://github.com/python/cpython/pull/106435
gh-104050: Partially annotate Argument Clinic CLanguage class #106437https://github.com/python/cpython/pull/106437
gh-104050: Argument Clinic: Annotate the Block class #106519https://github.com/python/cpython/pull/106519
gh-104050: Argument clinic: Annotate the Destination class #106655https://github.com/python/cpython/pull/106655
gh-104050: Argument Clinic: Annotate nested function parser_body() in the CLanguage class #106699https://github.com/python/cpython/pull/106699
gh-104050: Argument Clinic: Annotate output_templates() #106732https://github.com/python/cpython/pull/106732
gh-104050: Argument Clinic: Annotate BlockParser #106750https://github.com/python/cpython/pull/106750
gh-104050: Argument Clinic: Annotate Clinic.parse() #106760https://github.com/python/cpython/pull/106760
gh-104050: Improve Argument Clinic type annotation coverage #106810https://github.com/python/cpython/pull/106810
gh-104050: Argument Clinic: Annotate CLanguage.render_option_group_parsing() #106929https://github.com/python/cpython/pull/106929
gh-104050: Argument Clinic: Increase CConverter typing coverage #106932https://github.com/python/cpython/pull/106932
gh-104050: Argument Clinic: Annotate the IndentStack class #106934https://github.com/python/cpython/pull/106934
gh-104050: Argument Clinic: Annotate the BufferSeries class #106935https://github.com/python/cpython/pull/106935
gh-104050: Argument Clinic: Increase typing coverage #107074https://github.com/python/cpython/pull/107074
gh-104050: Argument Clinic: annotate main() #107192https://github.com/python/cpython/pull/107192
gh-104050: Argument clinic: annotate format_docstring() #107200https://github.com/python/cpython/pull/107200
gh-104050: Argument clinic: misc improvements to type annotation coverage #107206https://github.com/python/cpython/pull/107206
gh-104050: Argument Clinic: Annotate CRenderData.__init__ #107207https://github.com/python/cpython/pull/107207
gh-104050: Argument clinic: improve typing around adding C converters #107209https://github.com/python/cpython/pull/107209
gh-104050: Argument clinic: more misc typing coverage improvements #107210https://github.com/python/cpython/pull/107210
gh-104050: Argument clinic: annotate post_parsing() and cleanup() #107225https://github.com/python/cpython/pull/107225
gh-104050: Argument clinic: more misc typing improvements #107264https://github.com/python/cpython/pull/107264
gh-104050: Argument clinic: improve typing around parse_arg() methods #107288https://github.com/python/cpython/pull/107288
gh-104050: Argument clinic: Complete get_destination_buffer annotations #107293https://github.com/python/cpython/pull/107293
gh-104050: Argument clinic: Annotate str_converter_key() #107294https://github.com/python/cpython/pull/107294
gh-104050: Argument clinic: complete type annotations #107399https://github.com/python/cpython/pull/107399
gh-104050: Argument clinic: enable mypy's --warn-return-any setting #107405https://github.com/python/cpython/pull/107405
erlend-aaslandhttps://github.com/erlend-aasland
topic-argument-clinichttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-argument-clinic%22
topic-typinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-typing%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.