René's URL Explorer Experiment


Title: asyncio unix events test doesn't restore mocked unix_events.can_use_pidfd · Issue #103780 · python/cpython · GitHub

Open Graph Title: asyncio unix events test doesn't restore mocked unix_events.can_use_pidfd · Issue #103780 · python/cpython

X Title: asyncio unix events test doesn't restore mocked unix_events.can_use_pidfd · Issue #103780 · python/cpython

Description: Bug report in test_asyncio.test_unix_events.PolicyTest.test_get_default_child_watcher, unix_events.can_use_pidfd is mocked within the test body, but never restored to the original function. this doesn't cause test failures during regular...

Open Graph Description: Bug report in test_asyncio.test_unix_events.PolicyTest.test_get_default_child_watcher, unix_events.can_use_pidfd is mocked within the test body, but never restored to the original function. this do...

X Description: Bug report in test_asyncio.test_unix_events.PolicyTest.test_get_default_child_watcher, unix_events.can_use_pidfd is mocked within the test body, but never restored to the original function. this do...

Opengraph URL: https://github.com/python/cpython/issues/103780

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"asyncio unix events test doesn't restore mocked unix_events.can_use_pidfd","articleBody":"# Bug report\r\n\r\nin `test_asyncio.test_unix_events.PolicyTest.test_get_default_child_watcher`, `unix_events.can_use_pidfd` is mocked within the test body, but never restored to the original function.\r\n\r\nthis doesn't cause test failures during regular test runs, but during a refleak test run on MacOS it a `AttributeError: module 'os' has no attribute 'pidfd_open'` to be thrown (presumably due to another test using the non-mocked function in the second iteration).\r\n\r\nrepro:\r\n\r\n```\r\n./python.exe -m test test_asyncio -m '*.test_unix_events.*' -R 2:2\r\nWARNING: Running tests with --huntrleaks/-R and less than 3 warmup repetitions can give false positives!\r\n0:00:00 load avg: 3.79 Run tests sequentially\r\n0:00:00 load avg: 3.79 [1/1] test_asyncio\r\nbeginning 4 repetitions\r\n1234\r\n.Process ForkProcess-10:\r\nTraceback (most recent call last):\r\n...\r\n...\r\nAttributeError: module 'os' has no attribute 'pidfd_open'\r\n...\r\n...\r\n```\r\n\r\nthis can be fixed by patching instead of mocking in the `test_get_default_child_watcher` test (PR coming up).\r\n\r\n# Your environment\r\n\r\n- CPython versions tested on: main\r\n- Operating system and architecture: MacOS x86-64\r\n\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-103782\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/itamaro","@type":"Person","name":"itamaro"},"datePublished":"2023-04-24T18:28:56.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/103780/cpython/issues/103780"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2cf6ea46-0203-1745-18b4-8bc19201bbb3
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB180:9DE01:6F47F8:970E61:6969DA26
html-safe-nonce8bd7ee8966ad8fb8916479f5fd1cb63cc8562d7a4fc2baf26b5f34264325cef8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTgwOjlERTAxOjZGNDdGODo5NzBFNjE6Njk2OURBMjYiLCJ2aXNpdG9yX2lkIjoiNzkyMDM0Njc5MDQyNzcwMzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacedc871021d48ddfa3ac392ce5df52e466b5ce26fb3f50a0728401c0d6b721370
hovercard-subject-tagissue:1681810349
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/103780/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c9d932e9a116d714736d10e2933f015b19b0ae2fa772d2c2f8ced6598b85c20c/python/cpython/issues/103780
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c9d932e9a116d714736d10e2933f015b19b0ae2fa772d2c2f8ced6598b85c20c/python/cpython/issues/103780
og:image:altBug report in test_asyncio.test_unix_events.PolicyTest.test_get_default_child_watcher, unix_events.can_use_pidfd is mocked within the test body, but never restored to the original function. this do...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameitamaro
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/103780#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F103780
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F103780
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/103780
Reloadhttps://github.com/python/cpython/issues/103780
Reloadhttps://github.com/python/cpython/issues/103780
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/103780
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/103780
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/103780
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/103780
#103782https://github.com/python/cpython/pull/103782
asyncio unix events test doesn't restore mocked unix_events.can_use_pidfdhttps://github.com/python/cpython/issues/103780#top
#103782https://github.com/python/cpython/pull/103782
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/itamaro
https://github.com/itamaro
itamarohttps://github.com/itamaro
on Apr 24, 2023https://github.com/python/cpython/issues/103780#issue-1681810349
gh-103780: Use patch instead of mock in asyncio unix events test #103782https://github.com/python/cpython/pull/103782
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.