Title: Behavior change for opcode trace after PEP 669 · Issue #103615 · python/cpython · GitHub
Open Graph Title: Behavior change for opcode trace after PEP 669 · Issue #103615 · python/cpython
X Title: Behavior change for opcode trace after PEP 669 · Issue #103615 · python/cpython
Description: Before PEP 669, the opcode trace is togglable after trace function being set. So something like import sys def opcode_trace_func(frame, event, arg): print(frame, event) return opcode_trace_func sys.settrace(opcode_trace_func) sys._getfra...
Open Graph Description: Before PEP 669, the opcode trace is togglable after trace function being set. So something like import sys def opcode_trace_func(frame, event, arg): print(frame, event) return opcode_trace_func sys...
X Description: Before PEP 669, the opcode trace is togglable after trace function being set. So something like import sys def opcode_trace_func(frame, event, arg): print(frame, event) return opcode_trace_func sys...
Opengraph URL: https://github.com/python/cpython/issues/103615
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Behavior change for opcode trace after PEP 669","articleBody":"Before PEP 669, the opcode trace is togglable after trace function being set. So something like\r\n\r\n```python\r\nimport sys\r\n\r\ndef opcode_trace_func(frame, event, arg):\r\n print(frame, event)\r\n return opcode_trace_func\r\n\r\nsys.settrace(opcode_trace_func)\r\nsys._getframe().f_trace = opcode_trace_func\r\nsys._getframe().f_trace_opcodes = True\r\n\r\ndef f():\r\n a = [1, 2, 3]\r\n return a[0]\r\n\r\nf()\r\n```\r\n\r\nwould work.\r\n\r\nAfter PEP 669, the opcode event is set on `sys.settrace()` so it's impossible to enable it after enabling the trace.\r\n\r\n```python\r\nsys._getframe().f_trace_opcodes = True\r\nsys.settrace(opcode_trace_func)\r\nsys._getframe().f_trace = opcode_trace_func\r\n```\r\n\r\nkind of works but it's super intuitive.\r\n\r\nFor the current implementation, if we enabled opcode before we do `sys.settrace()`, it would be \"enabled\" forever. Meaning the event will be always on, the callback will be always triggered, but `frame.f_trace_opcode` will be checked in the callback function. Can we always have opcode callback on? It would be a performance hit(extra call for each opcode), but that happens if we want any opcode event at all, and I think that's basically how the old tracing system does it.\r\n\r\nAnother option would be making `f_trace_opcode` a descriptor and toggle(actually, probable just enable) opcode events there.\r\n\r\nIf we don't want to do that at all and just want to break the backward-compatibility because no one is doing insturction trace anyway (I only realized this when syncing https://github.com/python/cpython/pull/103050/ to the lastest change), we should probably document it - make sure the current frame's `f_trace_opcode` is set before calling `sys.settrace()` if you want opcode events.\r\n\r\nBTW we would've caught this if we already had the instruction level debugging :)\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-109472\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/gaogaotiantian","@type":"Person","name":"gaogaotiantian"},"datePublished":"2023-04-18T18:09:12.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/103615/cpython/issues/103615"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:af40aff5-1aee-b3b9-41c5-6728c94990b2 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BEAE:24CD64:159E455:1CC8EFA:696AE29B |
| html-safe-nonce | dce1ab8a290e6a63e123ba70f9b3ecd26c382be1fbc715817c5ec824562916fc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUFFOjI0Q0Q2NDoxNTlFNDU1OjFDQzhFRkE6Njk2QUUyOUIiLCJ2aXNpdG9yX2lkIjoiNTQ2NTkwMTQ0ODUzODI4NDY5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 01784cd4ed7de9571700e2fc59aaaa676660aea802e0cfcc78afac3eca0d82da |
| hovercard-subject-tag | issue:1673607411 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/103615/issue_layout |
| twitter:image | https://opengraph.githubassets.com/6133e1d1ae99655b591e1e73e7d0425b52e8986f9bfe14bb0752d41f48b91cb4/python/cpython/issues/103615 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6133e1d1ae99655b591e1e73e7d0425b52e8986f9bfe14bb0752d41f48b91cb4/python/cpython/issues/103615 |
| og:image:alt | Before PEP 669, the opcode trace is togglable after trace function being set. So something like import sys def opcode_trace_func(frame, event, arg): print(frame, event) return opcode_trace_func sys... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gaogaotiantian |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3d84d50b3c75fa36755c3cf392edbc09e626f979 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width