René's URL Explorer Experiment


Title: Improve `test_inspect` · Issue #103553 · python/cpython · GitHub

Open Graph Title: Improve `test_inspect` · Issue #103553 · python/cpython

X Title: Improve `test_inspect` · Issue #103553 · python/cpython

Description: While working on #103406 I've noticed that there are some problems with test_inspect that we can easily fix. List of problems I found: cpython/Lib/test/test_inspect.py Lines 1840 to 1845 in 2b6f5c3 f3 = self.makeCallable('**c') self.asse...

Open Graph Description: While working on #103406 I've noticed that there are some problems with test_inspect that we can easily fix. List of problems I found: cpython/Lib/test/test_inspect.py Lines 1840 to 1845 in 2b6f5c3...

X Description: While working on #103406 I've noticed that there are some problems with test_inspect that we can easily fix. List of problems I found: cpython/Lib/test/test_inspect.py Lines 1840 to 1845 in 2b6...

Opengraph URL: https://github.com/python/cpython/issues/103553

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Improve `test_inspect`","articleBody":"While working on https://github.com/python/cpython/issues/103406 I've noticed that there are some problems with `test_inspect` that we can easily fix.\r\n\r\nList of problems I found:\r\n1. https://github.com/python/cpython/blob/2b6f5c3483597abcb8422508aeffab04f500f568/Lib/test/test_inspect.py#L1840-L1845 Here `f4` is not ever used, but `f3` has duplicate asserts. It looks like a copy-paste error to me. I propose to add asserts for `f4` as well\r\n2. https://github.com/python/cpython/blob/2b6f5c3483597abcb8422508aeffab04f500f568/Lib/test/test_inspect.py#L1835-L1838 Unbound methods do not exist anymore, so this comment is outdated. Probably, it should be removed and assert should be restored\r\n3. https://github.com/python/cpython/blob/2b6f5c3483597abcb8422508aeffab04f500f568/Lib/test/test_inspect.py#L1823-L1824 It says that the result depends on the dict order. But, dicts are ordered now. Let's see if that possible to uncomment / modernize this test somehow\r\n4. https://github.com/python/cpython/blob/2b6f5c3483597abcb8422508aeffab04f500f568/Lib/test/test_inspect.py#L2991 This variable is not needed, because it is not used and there's an identical test right above it: https://github.com/python/cpython/blob/2b6f5c3483597abcb8422508aeffab04f500f568/Lib/test/test_inspect.py#L2987-L2989\r\n5. There are also several unsused variables that can be removed durin this cleanup\r\n\r\nHere's my PR :)\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-103554\n* gh-103568\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/sobolevn","@type":"Person","name":"sobolevn"},"datePublished":"2023-04-15T08:00:17.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/103553/cpython/issues/103553"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:75efb943-9439-0963-23da-c7a0a214db88
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBC80:EFB79:29890F:37D64E:6969A9E1
html-safe-nonce0963a1453bf67f6c0386fe6132239d9f5a7bdcf3eb31190fa1859e5062b1be09
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzgwOkVGQjc5OjI5ODkwRjozN0Q2NEU6Njk2OUE5RTEiLCJ2aXNpdG9yX2lkIjoiNDU2OTY0NjUzMjQxMDMyMTM3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4edee0332cecfc6e9ecb210dd4b3228803a5dd05c25e5beaf933dfc1d269b9af
hovercard-subject-tagissue:1669225415
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/103553/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bbd6f9e1e07b680a28fad3050769a705cf6837c1fd04d97de7b22ed993d89b70/python/cpython/issues/103553
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bbd6f9e1e07b680a28fad3050769a705cf6837c1fd04d97de7b22ed993d89b70/python/cpython/issues/103553
og:image:altWhile working on #103406 I've noticed that there are some problems with test_inspect that we can easily fix. List of problems I found: cpython/Lib/test/test_inspect.py Lines 1840 to 1845 in 2b6f5c3...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesobolevn
hostnamegithub.com
expected-hostnamegithub.com
None24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release124667f43168afb6c9c03b7c02eb5b1d2e1be3d9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/103553#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F103553
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F103553
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/103553
Reloadhttps://github.com/python/cpython/issues/103553
Reloadhttps://github.com/python/cpython/issues/103553
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/103553
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/103553
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/103553
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/103553
Improve test_inspecthttps://github.com/python/cpython/issues/103553#top
https://github.com/sobolevn
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/sobolevn
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Apr 15, 2023https://github.com/python/cpython/issues/103553#issue-1669225415
#103406https://github.com/python/cpython/issues/103406
cpython/Lib/test/test_inspect.pyhttps://github.com/python/cpython/blob/2b6f5c3483597abcb8422508aeffab04f500f568/Lib/test/test_inspect.py#L1840-L1845
2b6f5c3https://github.com/python/cpython/commit/2b6f5c3483597abcb8422508aeffab04f500f568
cpython/Lib/test/test_inspect.pyhttps://github.com/python/cpython/blob/2b6f5c3483597abcb8422508aeffab04f500f568/Lib/test/test_inspect.py#L1835-L1838
2b6f5c3https://github.com/python/cpython/commit/2b6f5c3483597abcb8422508aeffab04f500f568
cpython/Lib/test/test_inspect.pyhttps://github.com/python/cpython/blob/2b6f5c3483597abcb8422508aeffab04f500f568/Lib/test/test_inspect.py#L1823-L1824
2b6f5c3https://github.com/python/cpython/commit/2b6f5c3483597abcb8422508aeffab04f500f568
cpython/Lib/test/test_inspect.pyhttps://github.com/python/cpython/blob/2b6f5c3483597abcb8422508aeffab04f500f568/Lib/test/test_inspect.py#L2991
2b6f5c3https://github.com/python/cpython/commit/2b6f5c3483597abcb8422508aeffab04f500f568
cpython/Lib/test/test_inspect.pyhttps://github.com/python/cpython/blob/2b6f5c3483597abcb8422508aeffab04f500f568/Lib/test/test_inspect.py#L2987-L2989
2b6f5c3https://github.com/python/cpython/commit/2b6f5c3483597abcb8422508aeffab04f500f568
gh-103553: Improve test_inspect: add more assertions, remove unused #103554https://github.com/python/cpython/pull/103554
[3.11] gh-103553: Improve test_inspect: add more assertions, remove unused (GH-103554) #103568https://github.com/python/cpython/pull/103568
sobolevnhttps://github.com/sobolevn
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.