Title: Improve `test_inspect` · Issue #103553 · python/cpython · GitHub
Open Graph Title: Improve `test_inspect` · Issue #103553 · python/cpython
X Title: Improve `test_inspect` · Issue #103553 · python/cpython
Description: While working on #103406 I've noticed that there are some problems with test_inspect that we can easily fix. List of problems I found: cpython/Lib/test/test_inspect.py Lines 1840 to 1845 in 2b6f5c3 f3 = self.makeCallable('**c') self.asse...
Open Graph Description: While working on #103406 I've noticed that there are some problems with test_inspect that we can easily fix. List of problems I found: cpython/Lib/test/test_inspect.py Lines 1840 to 1845 in 2b6f5c3...
X Description: While working on #103406 I've noticed that there are some problems with test_inspect that we can easily fix. List of problems I found: cpython/Lib/test/test_inspect.py Lines 1840 to 1845 in 2b6...
Opengraph URL: https://github.com/python/cpython/issues/103553
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Improve `test_inspect`","articleBody":"While working on https://github.com/python/cpython/issues/103406 I've noticed that there are some problems with `test_inspect` that we can easily fix.\r\n\r\nList of problems I found:\r\n1. https://github.com/python/cpython/blob/2b6f5c3483597abcb8422508aeffab04f500f568/Lib/test/test_inspect.py#L1840-L1845 Here `f4` is not ever used, but `f3` has duplicate asserts. It looks like a copy-paste error to me. I propose to add asserts for `f4` as well\r\n2. https://github.com/python/cpython/blob/2b6f5c3483597abcb8422508aeffab04f500f568/Lib/test/test_inspect.py#L1835-L1838 Unbound methods do not exist anymore, so this comment is outdated. Probably, it should be removed and assert should be restored\r\n3. https://github.com/python/cpython/blob/2b6f5c3483597abcb8422508aeffab04f500f568/Lib/test/test_inspect.py#L1823-L1824 It says that the result depends on the dict order. But, dicts are ordered now. Let's see if that possible to uncomment / modernize this test somehow\r\n4. https://github.com/python/cpython/blob/2b6f5c3483597abcb8422508aeffab04f500f568/Lib/test/test_inspect.py#L2991 This variable is not needed, because it is not used and there's an identical test right above it: https://github.com/python/cpython/blob/2b6f5c3483597abcb8422508aeffab04f500f568/Lib/test/test_inspect.py#L2987-L2989\r\n5. There are also several unsused variables that can be removed durin this cleanup\r\n\r\nHere's my PR :)\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-103554\n* gh-103568\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/sobolevn","@type":"Person","name":"sobolevn"},"datePublished":"2023-04-15T08:00:17.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/103553/cpython/issues/103553"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:75efb943-9439-0963-23da-c7a0a214db88 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BC80:EFB79:29890F:37D64E:6969A9E1 |
| html-safe-nonce | 0963a1453bf67f6c0386fe6132239d9f5a7bdcf3eb31190fa1859e5062b1be09 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzgwOkVGQjc5OjI5ODkwRjozN0Q2NEU6Njk2OUE5RTEiLCJ2aXNpdG9yX2lkIjoiNDU2OTY0NjUzMjQxMDMyMTM3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4edee0332cecfc6e9ecb210dd4b3228803a5dd05c25e5beaf933dfc1d269b9af |
| hovercard-subject-tag | issue:1669225415 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/103553/issue_layout |
| twitter:image | https://opengraph.githubassets.com/bbd6f9e1e07b680a28fad3050769a705cf6837c1fd04d97de7b22ed993d89b70/python/cpython/issues/103553 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bbd6f9e1e07b680a28fad3050769a705cf6837c1fd04d97de7b22ed993d89b70/python/cpython/issues/103553 |
| og:image:alt | While working on #103406 I've noticed that there are some problems with test_inspect that we can easily fix. List of problems I found: cpython/Lib/test/test_inspect.py Lines 1840 to 1845 in 2b6f5c3... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sobolevn |
| hostname | github.com |
| expected-hostname | github.com |
| None | 24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 124667f43168afb6c9c03b7c02eb5b1d2e1be3d9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width