Title: Vestigial pathlib 'flavour' tests make assertions about internal method · Issue #103379 · python/cpython · GitHub
Open Graph Title: Vestigial pathlib 'flavour' tests make assertions about internal method · Issue #103379 · python/cpython
X Title: Vestigial pathlib 'flavour' tests make assertions about internal method · Issue #103379 · python/cpython
Description: Pathlib used to contain internal "flavour classes" with their own test suites. These were removed in a68e585 (#31691) and e5b08dd (#101002) along with most of their tests. Only the tests for the internal _parse_path() method remain now. ...
Open Graph Description: Pathlib used to contain internal "flavour classes" with their own test suites. These were removed in a68e585 (#31691) and e5b08dd (#101002) along with most of their tests. Only the tests for the in...
X Description: Pathlib used to contain internal "flavour classes" with their own test suites. These were removed in a68e585 (#31691) and e5b08dd (#101002) along with most of their tests. Only the tests ...
Opengraph URL: https://github.com/python/cpython/issues/103379
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Vestigial pathlib 'flavour' tests make assertions about internal method","articleBody":"Pathlib used to contain internal \"flavour classes\" with their own test suites. These were removed in a68e585c8b7b27323f67905868467ce0588a1dae (#31691) and e5b08ddddf1099f04bf65e63017de840bd4b5980 (#101002) along with most of their tests. Only the tests for the internal `_parse_path()` method remain now.\r\n\r\nThese tests make assertions about an _internal_ method that we're liable to change, rename or remove in future. They should instead make assertions about the public `PurePath.drive`, `root` and `parts` attributes. I think.\r\n\r\n\u003c!-- gh-linked-prs --\u003e\r\n### Linked PRs\r\n* gh-103380\r\n\u003c!-- /gh-linked-prs --\u003e\r\n","author":{"url":"https://github.com/barneygale","@type":"Person","name":"barneygale"},"datePublished":"2023-04-08T17:19:14.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/103379/cpython/issues/103379"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:b105690a-2063-6dde-4ed4-7f928fa16ca9 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BD10:282672:707588:9BC539:6969507F |
| html-safe-nonce | 0c01e34f6ae3b4e51346ecc3301bcff1162205285f7287126b027e7ba18f3962 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDEwOjI4MjY3Mjo3MDc1ODg6OUJDNTM5OjY5Njk1MDdGIiwidmlzaXRvcl9pZCI6Ijg3MjkxMjE5Mjk2NDI0NjMzNTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5ffcac7d99821035243cd0af1644e65e431af2045bd7136b1e5e0b3771a36d68 |
| hovercard-subject-tag | issue:1659587305 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/103379/issue_layout |
| twitter:image | https://opengraph.githubassets.com/be0ea178a13fee5dc2acc62f3dfe2bb775fa0f33cd56fd93c370ad48d408b9a3/python/cpython/issues/103379 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/be0ea178a13fee5dc2acc62f3dfe2bb775fa0f33cd56fd93c370ad48d408b9a3/python/cpython/issues/103379 |
| og:image:alt | Pathlib used to contain internal "flavour classes" with their own test suites. These were removed in a68e585 (#31691) and e5b08dd (#101002) along with most of their tests. Only the tests for the in... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | barneygale |
| hostname | github.com |
| expected-hostname | github.com |
| None | 54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d69ac0477df0f87da03b8b06cebd187012d7a930 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width