René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Tkinter: C API changes are needed for Tcl 8.7 and 9.0 value types","articleBody":"# Bug report\r\nI recently made changes to [Tcl.pm](http://tcl.pm/) (a Tcl wrapper for Perl) to support Tcl 8.7/9.0 (https://github.com/gisle/tcl.pm/pull/42). While I was doing so, I briefly looked at _tkinter.c for comparison (particularly `AsObj()` and `FromObj()`). Although I have not attempted to run Tkinter with Tcl 8.7/9.0, I do notice a few issues in the code which would need to be addressed first.\r\n\r\n* Tcl 9.0 currently renames the Tcl 8.5 \"booleanString\" value type to \"boolean\", which will break the existing check in `FromObj()`. Tcl has suggested an idiom for retrieving the `Tcl_ObjType *` of unregistered types like \"booleanString\", regardless of Tcl version (see https://core.tcl-lang.org/tcl/info/3bb3bcf2da5b); although I would think that approach entails initializing `v-\u003eBooleanType` from `Tkapp_New()` rather than lazily initializing `tkapp-\u003eBooleanType` from `FromObj()`.\r\n\r\n* [TIP 568](https://core.tcl-lang.org/tips/doc/trunk/tip/568.md): As of Tcl 9.0, \"bytearray\" is unregistered; the suggested idiom can be used instead.\r\n\r\n* [TIP 484](https://core.tcl-lang.org/tips/doc/trunk/tip/484.md): As of Tcl 8.7, on platforms with 32-bit `long`, there are no longer separate 32-bit \"int\" and 64-bit \"wideInt\" value types; there is only a single 64-bit type. And as of Tcl 9.0, the \"int\" type is unregistered. It is possible to reliably get the `Tcl_ObjType *` of \"int\" from a value created using `Tcl_NewIntObj(0)` and of \"wideInt\" (if present) using e.g. `Tcl_NewWideIntObj((Tcl_WideInt)(1) \u003c\u003c 32)`. However it would not be appropriate for `FromObj()` to continue using `Tcl_GetLongFromObj()` when `long` is 32-bit, as that would retrieve an overflowed result for values within \u0026#40;`LONG_MAX`,`ULONG_MAX`\u0026#93; rather than force `FromObj()` to try again with `Tcl_GetWideIntFromObj()` (via `fromWideIntObj()`); an alternative would be to always use  `Tcl_GetWideIntFromObj()` for both \"int\" and \"wideInt\" values.\r\n\r\nI am not familiar with contributing to Python, but I may be able to propose fixes for the above issues if no one else already has or intends to. I believe the fixes for the above issues are backward compatible with Tcl 8.5 and 8.6, and so can be implemented and tested without other changes that are likely also needed (such as for Tcl-syntax APIs) before Tkinter is usable with ~~Tcl 8.7/9.0 and Tk 8.7 (which will be compatible with both Tcl 8.7 and 9.0)~~ Tcl and Tk 8.7/9.0.\r\n\r\n\u003c!-- gh-linked-prs --\u003e\r\n### Linked PRs\r\n* gh-103846\r\n* gh-119830\n* gh-119831\n\u003c!-- /gh-linked-prs --\u003e\r\n","author":{"url":"https://github.com/chrstphrchvz","@type":"Person","name":"chrstphrchvz"},"datePublished":"2023-04-02T16:56:36.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":9},"url":"https://github.com/103194/cpython/issues/103194"}