René's URL Explorer Experiment


Title: unittest.mock.patch with autospec doesn't hold for classmethods nor staticmethods · Issue #102978 · python/cpython · GitHub

Open Graph Title: unittest.mock.patch with autospec doesn't hold for classmethods nor staticmethods · Issue #102978 · python/cpython

X Title: unittest.mock.patch with autospec doesn't hold for classmethods nor staticmethods · Issue #102978 · python/cpython

Description: Bug report Using patch with autospec=True does not work when a method is decorated with @classmethod or @staticmethod. The resulting mock can be called with any arguments without raising a TypeError. Example: from unittest.mock import pa...

Open Graph Description: Bug report Using patch with autospec=True does not work when a method is decorated with @classmethod or @staticmethod. The resulting mock can be called with any arguments without raising a TypeErro...

X Description: Bug report Using patch with autospec=True does not work when a method is decorated with @classmethod or @staticmethod. The resulting mock can be called with any arguments without raising a TypeErro...

Opengraph URL: https://github.com/python/cpython/issues/102978

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"unittest.mock.patch with autospec doesn't hold for classmethods nor staticmethods","articleBody":"# Bug report\r\n\r\nUsing `patch` with `autospec=True` does not work when a method is decorated with `@classmethod` or `@staticmethod`. The resulting mock can be called with any arguments without raising a `TypeError`.\r\n\r\nExample:\r\n```python\r\nfrom unittest.mock import patch\r\nimport pytest\r\n\r\nclass Foo:\r\n    def foo(self):\r\n        pass\r\n    @staticmethod\r\n    def bar():\r\n        pass\r\n    @classmethod\r\n    def baz(cls):\r\n        pass\r\n\r\n@pytest.mark.parametrize(\"method\", [\"foo\", \"bar\", \"baz\"])\r\ndef test_foo(method: str):\r\n    with patch.object(Foo, method, autospec=True):\r\n        getattr(Foo(), method)(5)\r\n```\r\n\r\nThe only subtest that fails is `foo`. The other two pass, even though they're clearly being called incorrectly.\r\n\r\nIf you prefer not to use `pytest` to demo/repro this:\r\n\r\n```python\r\nwith patch.object(Foo, \"foo\", autospec=True):\r\n    try:\r\n        Foo().foo(5)\r\n    except TypeError:\r\n        print(\"Correctly raises on foo\")\r\n    else:\r\n        print(\"Incorrectly does not raise with foo\")\r\n\r\nwith patch.object(Foo, \"bar\", autospec=True):\r\n    try:\r\n        Foo().bar(5)\r\n    except TypeError:\r\n        print(\"Correctly raises on bar\")\r\n    else:\r\n        print(\"Incorrectly does not raise with bar\")\r\n\r\nwith patch.object(Foo, \"baz\", autospec=True):\r\n    try:\r\n        Foo().baz(5)\r\n    except TypeError:\r\n        print(\"Correctly raises on baz\")\r\n    else:\r\n        print(\"Incorrectly does not raise with baz\")\r\n```\r\n\r\nThis has output:\r\n```\r\nCorrectly raises on foo\r\nIncorrectly does not raise with bar\r\nIncorrectly does not raise with baz\r\n```\r\n\r\n# Your environment\r\n\r\n- CPython versions tested on: 3.10, 3.11\r\n- Operating system and architecture: macOS 12.6 with Apple M1 chip\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-103228\n* gh-103499\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/rileyjohngibbs","@type":"Person","name":"rileyjohngibbs"},"datePublished":"2023-03-23T21:52:34.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/102978/cpython/issues/102978"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:520066c2-5b3d-3802-24de-8a7cab517c5b
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCAF8:31FE0A:2D3D9:40036:696A0BB0
html-safe-nonce4d780061f0be84b57ed3ef362d9b28e1312df49fb3f61c8414b5c345eddeadb7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUY4OjMxRkUwQToyRDNEOTo0MDAzNjo2OTZBMEJCMCIsInZpc2l0b3JfaWQiOiI4MTY2MDMwMzc5NzM5Mzg0NzUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4fcc4fd742a2abccaeb88a189dd0068a313db8872a55a80733630c12f7115095
hovercard-subject-tagissue:1638390110
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/102978/issue_layout
twitter:imagehttps://opengraph.githubassets.com/73969f8e827e2dc99eb0db19c9555e8324d06263e300a4605a511746268a7f13/python/cpython/issues/102978
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/73969f8e827e2dc99eb0db19c9555e8324d06263e300a4605a511746268a7f13/python/cpython/issues/102978
og:image:altBug report Using patch with autospec=True does not work when a method is decorated with @classmethod or @staticmethod. The resulting mock can be called with any arguments without raising a TypeErro...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerileyjohngibbs
hostnamegithub.com
expected-hostnamegithub.com
None699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7266b2d935baa1c6474b16dd9feaa5ca30607261
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/102978#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F102978
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F102978
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/102978
Reloadhttps://github.com/python/cpython/issues/102978
Reloadhttps://github.com/python/cpython/issues/102978
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/102978
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/102978
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/102978
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/102978
#103228https://github.com/python/cpython/pull/103228
unittest.mock.patch with autospec doesn't hold for classmethods nor staticmethodshttps://github.com/python/cpython/issues/102978#top
#103228https://github.com/python/cpython/pull/103228
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/rileyjohngibbs
https://github.com/rileyjohngibbs
rileyjohngibbshttps://github.com/rileyjohngibbs
on Mar 23, 2023https://github.com/python/cpython/issues/102978#issue-1638390110
gh-102978: Fix mock.patch function signatures for class and staticmethod decorators #103228https://github.com/python/cpython/pull/103228
[3.11] gh-102978: Fix mock.patch function signatures for class and staticmethod decorators (GH-103228) #103499https://github.com/python/cpython/pull/103499
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.