René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"It is possible for python_tzpath_context to fail in test_zoneinfo","articleBody":"# Bug report\r\n\r\n[This code](https://github.com/python/cpython/blob/11a2c6ce516b24b2435cb627742a6c4df92d411c/Lib/test/test_zoneinfo/test_zoneinfo.py#L1544-L1555) started failing the `pylint` check on `backports.zoneinfo` recently:\r\n\r\n```python\r\n@staticmethod\r\n@contextlib.contextmanager\r\ndef python_tzpath_context(value):\r\n    path_var = \"PYTHONTZPATH\"\r\n    try:\r\n        with OS_ENV_LOCK:\r\n           old_env = os.environ.get(path_var, None)\r\n           os.environ[path_var] = value\r\n           yield\r\n    finally:\r\n        if old_env is None:\r\n            del os.environ[path_var]\r\n        else:\r\n            os.environ[path_var] = old_env  # pragma: nocover\r\n```\r\n\r\nIt's kind of a non-issue, but it *is* true that if an error is raised while acquiring `OS_ENV_LOCK` or when calling `os.environ.get`, `old_env` won't be set, which will raise a `NameError`. This is a kind of rare situation anyway, and it would probably only come up during a non-recoverable error, but we may as well fix it — if only so that people who use CPython as an example of \"good code\" will have an example of the right way to handle this sort of situation.\r\n\r\nProbably this is trivial enough that we can skip an issue and news, but I'll just create one anyway 😛\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-102538\n* gh-102586\n* gh-102587\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/pganssle","@type":"Person","name":"pganssle"},"datePublished":"2023-03-08T18:51:24.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/102537/cpython/issues/102537"}