Title: Make inspect.Parameter.__hash__ use _default instead of default · Issue #102302 · python/cpython · GitHub
Open Graph Title: Make inspect.Parameter.__hash__ use _default instead of default · Issue #102302 · python/cpython
X Title: Make inspect.Parameter.__hash__ use _default instead of default · Issue #102302 · python/cpython
Description: Feature or enhancement Enable subclasses of Parameter to add a default property accessing hash(self) rather than having hash rely on the default property Pitch I wanted to make a subclass of Parameter which would store as _default the st...
Open Graph Description: Feature or enhancement Enable subclasses of Parameter to add a default property accessing hash(self) rather than having hash rely on the default property Pitch I wanted to make a subclass of Parame...
X Description: Feature or enhancement Enable subclasses of Parameter to add a default property accessing hash(self) rather than having hash rely on the default property Pitch I wanted to make a subclass of Parame...
Opengraph URL: https://github.com/python/cpython/issues/102302
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Make inspect.Parameter.__hash__ use _default instead of default","articleBody":"# Feature or enhancement\r\n\r\nEnable subclasses of Parameter to add a `default` property accessing hash(self) rather than having hash rely on the `default` property\r\n\r\n# Pitch\r\n\r\nI wanted to make a subclass of Parameter which would store as _default the string eval-ing to the actual default value, and which would only eval it when accessed, and memorize it at that time.\r\nSo, I coded this :\r\n```py\r\nclass Parameter(inspect.Parameter):\r\n __slots__ = ()\r\n @property\r\n @functools.cache\r\n def default(self):\r\n return renpy.python.py_eval(super(Parameter, self).default)\r\n```\r\n(not using @cached_property because I want to keep the empty slots)\r\nThis doesn't work, because `cache` tries to hash `self`, and Parameter.\\_\\_hash\\_\\_ accesses `self.default`, rather than `self._default` (so it does an infinite recursion loop).\r\n\r\nThe last edit to the hash method was purportedly to \"fix a discrepancy between eq and hash\". However, the eq still accesses the raw _default, and hash did so too before the \"fix\".\r\nOverall, apart from my selfish use-case, I think it makes more sense for an immutable class to hash relative to the actual value instead of the less-reliable propertied value.\r\nAnd there's a minor performance bonus too.\r\n\r\n\u003c!-- gh-linked-prs --\u003e\r\n### Linked PRs\r\n* gh-102303\r\n\u003c!-- /gh-linked-prs --\u003e\r\n","author":{"url":"https://github.com/Gouvernathor","@type":"Person","name":"Gouvernathor"},"datePublished":"2023-02-27T15:52:06.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":13},"url":"https://github.com/102302/cpython/issues/102302"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:79f14b2a-74f2-9e1c-c22f-e292f3baa617 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9E7A:217FCE:F33AB4:14F830F:6969F1C1 |
| html-safe-nonce | 85669744103a18a59f07e2d63f06db9732e8f53a0ceee7286512c65dd4f742b5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTdBOjIxN0ZDRTpGMzNBQjQ6MTRGODMwRjo2OTY5RjFDMSIsInZpc2l0b3JfaWQiOiI1MDA0MjkwMzUwODE3ODY2MTc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d1db633cc4dd34a06ff97e085b9739e7a265f33e8194ee7016c6f9b7a13a9881 |
| hovercard-subject-tag | issue:1601453190 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/102302/issue_layout |
| twitter:image | https://opengraph.githubassets.com/d8b2ffed1574d0789821eabbbfa41b47a641fee5c8a739b1a488abda9f5639ee/python/cpython/issues/102302 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d8b2ffed1574d0789821eabbbfa41b47a641fee5c8a739b1a488abda9f5639ee/python/cpython/issues/102302 |
| og:image:alt | Feature or enhancement Enable subclasses of Parameter to add a default property accessing hash(self) rather than having hash rely on the default property Pitch I wanted to make a subclass of Parame... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Gouvernathor |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width