Title: test_implied_dirs_performance is flaky · Issue #102209 · python/cpython · GitHub
Open Graph Title: test_implied_dirs_performance is flaky · Issue #102209 · python/cpython
X Title: test_implied_dirs_performance is flaky · Issue #102209 · python/cpython
Description: Reported in discord, since #102018, the timing check was added to test_implied_dirs_performance and this check is frequently failing (example): ERROR: test_implied_dirs_performance (test.test_zipfile.test_path.TestPath.test_implied_dirs_...
Open Graph Description: Reported in discord, since #102018, the timing check was added to test_implied_dirs_performance and this check is frequently failing (example): ERROR: test_implied_dirs_performance (test.test_zipfi...
X Description: Reported in discord, since #102018, the timing check was added to test_implied_dirs_performance and this check is frequently failing (example): ERROR: test_implied_dirs_performance (test.test_zipfi...
Opengraph URL: https://github.com/python/cpython/issues/102209
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"test_implied_dirs_performance is flaky","articleBody":"Reported [in discord](https://discord.com/channels/854719841091715092/868504620970962944/1078325012651593768), since #102018, the timing check was added to `test_implied_dirs_performance` and this check is frequently failing ([example](https://github.com/python/cpython/actions/runs/4248047744/jobs/7386765925)):\r\n\r\n```\r\nERROR: test_implied_dirs_performance (test.test_zipfile.test_path.TestPath.test_implied_dirs_performance)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n File \"D:\\a\\cpython\\cpython\\Lib\\contextlib.py\", line 80, in inner\r\n with self._recreate_cm():\r\n File \"D:\\a\\cpython\\cpython\\Lib\\test\\test_zipfile\\_context.py\", line 30, in __exit__\r\n raise DeadlineExceeded(duration, self.max_duration)\r\ntest.test_zipfile._context.DeadlineExceeded: (3.140999999999849, 3)\r\n```\r\n\r\nThese failures aren't occurring on [zipp](/jaraco/zipp), where the check has been running for years without fail.\r\n\r\nFurthermore, the check is currently not capturing the failure case because the invocation fails to consume the generator:\r\n\r\nhttps://github.com/python/cpython/blob/9f3ecd1aa3566947648a053bd9716ed67dd9a718/Lib/test/test_zipfile/test_path.py#L336\r\n\r\nThat indicates that the flaky failures are due to the construction of test data:\r\n\r\nhttps://github.com/python/cpython/blob/9f3ecd1aa3566947648a053bd9716ed67dd9a718/Lib/test/test_zipfile/test_path.py#L335\r\n\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-102225\n* gh-102232\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/jaraco","@type":"Person","name":"jaraco"},"datePublished":"2023-02-24T09:58:25.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/102209/cpython/issues/102209"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:978860dd-ebe1-b829-cedb-893f562e3eda |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DAF4:FB3A6:B71A4C:FC31FB:6969EC87 |
| html-safe-nonce | 95ecdee26411b3c10b8026453164c352e5afe322f05e57d56db6ae5fe7461de8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUY0OkZCM0E2OkI3MUE0QzpGQzMxRkI6Njk2OUVDODciLCJ2aXNpdG9yX2lkIjoiNjU0MTM5NTY5NjUwNDQwMTAzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 29d1a6eb87ddde709d7139b891d82996d67d17043171e39df5cc747eab33242e |
| hovercard-subject-tag | issue:1598300037 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/102209/issue_layout |
| twitter:image | https://opengraph.githubassets.com/1e96de9664b40d7424139e985c03cfd8bfc8931ca4df9fbe9a0ff860401a6b39/python/cpython/issues/102209 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1e96de9664b40d7424139e985c03cfd8bfc8931ca4df9fbe9a0ff860401a6b39/python/cpython/issues/102209 |
| og:image:alt | Reported in discord, since #102018, the timing check was added to test_implied_dirs_performance and this check is frequently failing (example): ERROR: test_implied_dirs_performance (test.test_zipfi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jaraco |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width