René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"blake2-config.h `HAVE_SSE4_1` typo fix","articleBody":"# Bug report\r\n\r\n### Unable to compile cpython on Windows with **`AVX`** enable\r\n1. adding `\u003cEnableEnhancedInstructionSet\u003eAdvancedVectorExtensions\u003c/EnableEnhancedInstructionSet\u003e` for `\u003c/ClCompile\u003e` in vcxproj files (result `/arch:AVX` in cl.exe cmd line)\r\n2. `MSBuild.exe C:\\sdk\\src\\python\\PCbuild\\pcbuild.proj /nologo /nr:false /m:16 /p:Turbo=true /p:CL_MPCount=16 /p:RunCodeAnalysis=false /p:DebugType=None /p:DebugSymbols=true /p:WindowsTargetPlatformVersion=10.0.22621.0 /p:PlatformToolset=v143 /clp:EnableMPLogging;Summary;ShowCommandLine /v:d /p:Configuration=Release /p:Platform=\"x64\" /p:IncludeExtensions=true /p:IncludeExternals=true /p:IncludeTests=false /p:IncludeCTypes=true /p:IncludeSSL=true /p:IncludeTkinter=false /p:IncludeUwp=true /t:RebuildAll /p:EXTERNALS_DIR=\"C:\\sdk\\release\\vs17_x64-avx\" /p:ExternalsSrcDir=\"C:\\sdk\\src\" /p:_DLLSuffix=-81_3-x64 /p:SqliteVersionStrToParse=3.40.1.0 /nowarn:C4244`\r\n3. result:\r\n\u003e C:\\sdk\\src\\python\\Modules\\_blake2\\impl\\blake2-config.h(67,1): fatal  error C1189: #error:  \"This code requires at least SSE2.\" (compiling source file ..\\Modules\\_blake2\\blake2s_impl.c) [C:\\sdk\\src\\python\\PCbuild\\pythoncore.vcxproj]\r\n\u003e C:\\sdk\\src\\python\\Modules\\_blake2\\impl\\blake2-config.h(67,1): fatal  error C1189: #error:  \"This code requires at least SSE2.\" (compiling source file ..\\Modules\\_blake2\\blake2b_impl.c) [C:\\sdk\\src\\python\\PCbuild\\pythoncore.vcxproj]\r\n\r\n\r\n### It's just a typo issue in `Modules/_blake2/impl/blake2-config.h`\r\n\r\n```diff\r\ndiff --git \"a/Modules/_blake2/impl/blake2-config.h\" \"b/Modules/_blake2/impl/blake2-config.h\"\r\nindex f5dd6faa9e..c09cb4bcf0 100644\r\n--- \"a/Modules/_blake2/impl/blake2-config.h\"\r\n+++ \"b/Modules/_blake2/impl/blake2-config.h\"\r\n@@ -53,7 +53,7 @@\r\n #endif\r\n #endif\r\n \r\n-#ifdef HAVE_SSE41\r\n+#ifdef HAVE_SSE4_1\r\n #ifndef HAVE_SSSE3\r\n #define HAVE_SSSE3\r\n #endif\r\n\r\n```\r\n\r\nThe patch fix the issue\r\nSeems to be present on every branch\r\n\r\n# Your environment\r\n\r\n\u003c!-- Include as many relevant details as possible about the environment you experienced the bug in --\u003e\r\n\r\n- CPython versions tested on: branch 3.8 / tag 3.8.16\r\n- Operating system and architecture: Win64 vs17 AVX\r\n\r\n\u003c!--\r\nYou can freely edit this text. Remove any lines you believe are unnecessary.\r\n--\u003e\r\n\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-102124\n* gh-102916\n* gh-102917\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/nono303","@type":"Person","name":"nono303"},"datePublished":"2023-02-18T14:19:10.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/102027/cpython/issues/102027"}