René's URL Explorer Experiment

Title: `Py_EnterRecursiveCall()`/`_Py_EnterRecursiveCall()` return value misused in a number of places · Issue #101965 · python/cpython · GitHub

Open Graph Title: `Py_EnterRecursiveCall()`/`_Py_EnterRecursiveCall()` return value misused in a number of places · Issue #101965 · python/cpython

X Title: `Py_EnterRecursiveCall()`/`_Py_EnterRecursiveCall()` return value misused in a number of places · Issue #101965 · python/cpython

Description: Using grep, I identified 3 instances in main where code checks if Py_EnterRecursiveCall(...) < 0 (which just returns _Py_EnterRecursiveCall(...)) or _Py_EnterRecursiveCall(...) < 0. Py_EnterRecursiveCall() documentation only guarantees t...

Open Graph Description: Using grep, I identified 3 instances in main where code checks if Py_EnterRecursiveCall(...) < 0 (which just returns _Py_EnterRecursiveCall(...)) or _Py_EnterRecursiveCall(...) < 0. Py_EnterRecursi...

X Description: Using grep, I identified 3 instances in main where code checks if Py_EnterRecursiveCall(...) < 0 (which just returns _Py_EnterRecursiveCall(...)) or _Py_EnterRecursiveCall(...) < 0. Py_EnterR...

Opengraph URL: https://github.com/python/cpython/issues/101965

X: @github

direct link

Domain: github.com

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`Py_EnterRecursiveCall()`/`_Py_EnterRecursiveCall()` return value misused in a number of places","articleBody":"Using ``grep``, I identified 3 instances in `main` where code checks if ``Py_EnterRecursiveCall(...) \u003c 0`` (which just returns ``_Py_EnterRecursiveCall(...)``) or ``_Py_EnterRecursiveCall(...) \u003c 0``.\r\n\r\n1. ``Py_EnterRecursiveCall()`` [documentation](https://docs.python.org/3/c-api/exceptions.html#c.Py_EnterRecursiveCall) only guarantees that a **nonzero** value is returned in the event of an error.\r\n2. The actual implementation can't return a negative value:\r\n\r\nhttps://github.com/python/cpython/blob/76449350b3467b85bcb565f9e2bf945bd150a66e/Include/internal/pycore_ceval.h#L130-L138\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-101966\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/OTheDev","@type":"Person","name":"OTheDev"},"datePublished":"2023-02-16T22:55:43.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/101965/cpython/issues/101965"}

Links:

Viewport: width=device-width