Title: Duplicated st_ino calculation · Issue #101810 · python/cpython · GitHub
Open Graph Title: Duplicated st_ino calculation · Issue #101810 · python/cpython
X Title: Duplicated st_ino calculation · Issue #101810 · python/cpython
Description: Feature or enhancement The status->st_ino = (((uint64_t)info.nFileIndexHigh) << 32) + info.nFileIndexLow; in function _Py_fstat_noraise() in file Python/fileutils.c is already calculated and assigned in the function _Py_attribute_data_to...
Open Graph Description: Feature or enhancement The status->st_ino = (((uint64_t)info.nFileIndexHigh) << 32) + info.nFileIndexLow; in function _Py_fstat_noraise() in file Python/fileutils.c is already calculated and assign...
X Description: Feature or enhancement The status->st_ino = (((uint64_t)info.nFileIndexHigh) << 32) + info.nFileIndexLow; in function _Py_fstat_noraise() in file Python/fileutils.c is already calculated a...
Opengraph URL: https://github.com/python/cpython/issues/101810
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Duplicated st_ino calculation","articleBody":"# Feature or enhancement\r\nThe `status-\u003est_ino = (((uint64_t)info.nFileIndexHigh) \u003c\u003c 32) + info.nFileIndexLow;` in function `_Py_fstat_noraise()` in file `Python/fileutils.c` is already calculated and assigned in the function `_Py_attribute_data_to_stat()` in same file.\r\nSo I'm proposing removing the duplicated code.\r\n\r\n# Pitch\r\nIt's a duplicated code that is already done in the previous function call `_Py_attribute_data_to_stat()`.\r\n\r\n# Previous discussion\r\n\r\n\u003c!--\r\n New features to Python should first be discussed elsewhere before creating issues on GitHub,\r\n for example in the \"ideas\" category (https://discuss.python.org/c/ideas/6) of discuss.python.org,\r\n or the python-ideas mailing list (https://mail.python.org/mailman3/lists/python-ideas.python.org/).\r\n Use this space to post links to the places where you have already discussed this feature proposal:\r\n--\u003e\r\n\r\n\r\n\u003c!--\r\nYou can freely edit this text. Remove any lines you believe are unnecessary.\r\n--\u003e\r\n\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-101811\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/juria90","@type":"Person","name":"juria90"},"datePublished":"2023-02-10T21:36:35.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/101810/cpython/issues/101810"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:07c89f31-2d95-2963-3636-0030c1a8f797 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A4B6:16E0FE:E702F4:140C26E:696A3026 |
| html-safe-nonce | 832174d1984fe6e7657366d348a6c3d64ef73ef5b622b38c50f6db298afcd51c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEI2OjE2RTBGRTpFNzAyRjQ6MTQwQzI2RTo2OTZBMzAyNiIsInZpc2l0b3JfaWQiOiIzNDM2MDI3NjI0NDQ0MDE0NjMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 58af2b84b8eb83aad00f3bd8d3a675913c466f28e94b2bf5db3c370435ce8137 |
| hovercard-subject-tag | issue:1580367377 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/101810/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5a6b311e2738d6cbdc9b6baef789b1c516d9483ce54ddd0169e567d3f23ed74f/python/cpython/issues/101810 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5a6b311e2738d6cbdc9b6baef789b1c516d9483ce54ddd0169e567d3f23ed74f/python/cpython/issues/101810 |
| og:image:alt | Feature or enhancement The status->st_ino = (((uint64_t)info.nFileIndexHigh) << 32) + info.nFileIndexLow; in function _Py_fstat_noraise() in file Python/fileutils.c is already calculated and assign... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | juria90 |
| hostname | github.com |
| expected-hostname | github.com |
| None | ade130928b3890d20ecf9c887468a17e88d5c9a740ea2a85c2c2162e7c58e623 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c00842167ca2e5b13e8171812965d503e925ece6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width