René's URL Explorer Experiment


Title: Undocumented risky behaviour in subprocess module · Issue #101283 · python/cpython · GitHub

Open Graph Title: Undocumented risky behaviour in subprocess module · Issue #101283 · python/cpython

X Title: Undocumented risky behaviour in subprocess module · Issue #101283 · python/cpython

Description: Bug report - Undocumented risky behaviour in subprocess module When using subprocess.Popen with shell=True on Windows and without a COMSPEC environment variable, a cmd.exe is launched. The problem is the cmd.exe full path is not written,...

Open Graph Description: Bug report - Undocumented risky behaviour in subprocess module When using subprocess.Popen with shell=True on Windows and without a COMSPEC environment variable, a cmd.exe is launched. The problem ...

X Description: Bug report - Undocumented risky behaviour in subprocess module When using subprocess.Popen with shell=True on Windows and without a COMSPEC environment variable, a cmd.exe is launched. The problem ...

Opengraph URL: https://github.com/python/cpython/issues/101283

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Undocumented risky behaviour in subprocess module","articleBody":"# Bug report - Undocumented risky behaviour in subprocess module\r\n\r\nWhen using `subprocess.Popen` with `shell=True` on Windows and without a `COMSPEC` environment variable, a `cmd.exe` is launched. The problem is the `cmd.exe` full path is not written, Windows will search the executable in the current directory and in the PATH. If an arbitrary executable file is written to the current directory or to a directory in the PATH, it can be run instead of the real cmd.exe.\r\n\r\nSee the code [here](https://github.com/python/cpython/blob/38cc24f119346e2947e316478b58e58f0dde307c/Lib/subprocess.py#L1480) and a POC [here](https://github.com/mauricelambert/PythonSubprocessVulnerabilityPOC).\r\n\r\n - This risky behaviour can be patched by replacing `cmd.exe` string by `C:\\WINDOWS\\system32\\cmd.exe`.\r\n - If the behavior was chosen by python developers, it should be documented.\r\n\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-101286\n* gh-101708\n* gh-101709\n* gh-101710\n* gh-101711\n* gh-101712\n* gh-101713\n* gh-101719\n* gh-101721\n* gh-101728\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/mauricelambert","@type":"Person","name":"mauricelambert"},"datePublished":"2023-01-24T11:19:13.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/101283/cpython/issues/101283"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:4b7fe5bb-3482-0767-86b9-b532807dd496
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE100:20B5CF:84E8C9:BA9E79:6968E565
html-safe-nonceac80c546bd7d6e6f49154f2441a2f2446b716b58f1cb5ad7e3649e843dbbb0ef
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTAwOjIwQjVDRjo4NEU4Qzk6QkE5RTc5OjY5NjhFNTY1IiwidmlzaXRvcl9pZCI6IjUzOTUwMzY0NTA5NTQyMDg2MTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac862f5de9cb03853b124b0ec7251c28ce8c84a030beda1a620419d787e618fdfe
hovercard-subject-tagissue:1554792320
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/101283/issue_layout
twitter:imagehttps://opengraph.githubassets.com/df058aa3fd29ff72e5479a044012ba03e4faffbe6a268fa8e57d7cbeb030323f/python/cpython/issues/101283
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/df058aa3fd29ff72e5479a044012ba03e4faffbe6a268fa8e57d7cbeb030323f/python/cpython/issues/101283
og:image:altBug report - Undocumented risky behaviour in subprocess module When using subprocess.Popen with shell=True on Windows and without a COMSPEC environment variable, a cmd.exe is launched. The problem ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemauricelambert
hostnamegithub.com
expected-hostnamegithub.com
Noneb5416305695900bdab7d289f90ea3d96bf36397112f2ab16f5a5a120f38de085
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release366035abf3d5b1e31841c97e2fa2ce02a3007a7b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/101283#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F101283
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F101283
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/101283
Reloadhttps://github.com/python/cpython/issues/101283
Reloadhttps://github.com/python/cpython/issues/101283
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/101283
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/101283
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/101283
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/101283
Undocumented risky behaviour in subprocess modulehttps://github.com/python/cpython/issues/101283#top
3.10only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.10%22
3.11only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.11%22
3.7 (EOL)end of lifehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.7%20(EOL)%22
3.8 (EOL)end of lifehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.8%20(EOL)%22
3.9 (EOL)end of lifehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.9%20(EOL)%22
OS-windowshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22OS-windows%22
release-blockerhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22release-blocker%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
type-securityA security issuehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-security%22
https://github.com/mauricelambert
https://github.com/mauricelambert
mauricelamberthttps://github.com/mauricelambert
on Jan 24, 2023https://github.com/python/cpython/issues/101283#issue-1554792320
herehttps://github.com/python/cpython/blob/38cc24f119346e2947e316478b58e58f0dde307c/Lib/subprocess.py#L1480
herehttps://github.com/mauricelambert/PythonSubprocessVulnerabilityPOC
gh-101283: Try to load the fallback cmd.exe by an absolute path #101286https://github.com/python/cpython/pull/101286
[3.10] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) #101708https://github.com/python/cpython/pull/101708
[3.9] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) #101709https://github.com/python/cpython/pull/101709
[3.8] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) #101710https://github.com/python/cpython/pull/101710
[3.11] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) #101711https://github.com/python/cpython/pull/101711
gh-101283: Fix use of unbound variable #101712https://github.com/python/cpython/pull/101712
[3.7] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) #101713https://github.com/python/cpython/pull/101713
gh-101283: Version was just released, so should be changed in 3.11.3 #101719https://github.com/python/cpython/pull/101719
[3.11] gh-101283: Version was just released, so should be changed in 3.11.3 (GH-101719) #101721https://github.com/python/cpython/pull/101721
gh-101283: Fix the versionchanged of gh-101283 (3.12 only) #101728https://github.com/python/cpython/pull/101728
3.10only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.10%22
3.11only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.11%22
3.7 (EOL)end of lifehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.7%20(EOL)%22
3.8 (EOL)end of lifehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.8%20(EOL)%22
3.9 (EOL)end of lifehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.9%20(EOL)%22
OS-windowshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22OS-windows%22
release-blockerhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22release-blocker%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
type-securityA security issuehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-security%22
Release and Deferred blockers 🚫https://github.com/orgs/python/projects/2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.