René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`zipfile.Path.read_text` \u0026 `.open` methods with a positional `encoding` arg causes a TypeError","articleBody":"This is a regression from 3.9 behavior seen in Python 3.10.\r\n\r\nzipfile.Path.read_text passes *args and **kwargs to it's own `open()` method, but in 3.10+ is also blindly sets `kwargs[\"encodings\"]` to a value. So code that was previously passing an encoding as a positional argument now sees:\r\n\r\n```\r\n  File \"/\u003cstdlib\u003e/zipfile.py\", line 2362, in read_text\r\n    with self.open('r', *args, **kwargs) as strm:\r\n  File \"/\u003cstdlib\u003e/zipfile.py\", line 2350, in open\r\n    return io.TextIOWrapper(stream, *args, **kwargs)\r\nTypeError: Failed to construct dataset imagenet2012: argument for TextIOWrapper() given by name ('encoding') and position (2)\r\n```\r\n\r\n3.10's Lib/zipfile.py (and main's Lib/zipfile/_path.py) contain:\r\n\r\n```\r\n    def read_text(self, *args, **kwargs):\r\n        kwargs[\"encoding\"] = io.text_encoding(kwargs.get(\"encoding\"))  # \u003c-- new in 3.10, source of bug\r\n        with self.open('r', *args, **kwargs) as strm:\r\n            return strm.read()\r\n```\r\n\r\nAs this is a regression, we should avoid setting that value in kwargs when `\"encodings\" not in kwargs` to match 3.9 and earlier behavior.\r\n\r\nTODO list:\r\n\r\n- [x] @jaraco will port the change to [zipp](/jaraco/zipp).\r\n\r\n\u003c!-- gh-linked-prs --\u003e\r\n### Linked PRs\r\n* gh-101145\r\n* gh-101179\r\n* gh-101182\r\n\u003c!-- /gh-linked-prs --\u003e\r\n","author":{"url":"https://github.com/gpshead","@type":"Person","name":"gpshead"},"datePublished":"2023-01-19T01:47:13.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/101144/cpython/issues/101144"}