René's URL Explorer Experiment


Title: Remove `check_string` and `check_mapping` from `test_xml_etree` · Issue #100933 · python/cpython · GitHub

Open Graph Title: Remove `check_string` and `check_mapping` from `test_xml_etree` · Issue #100933 · python/cpython

X Title: Remove `check_string` and `check_mapping` from `test_xml_etree` · Issue #100933 · python/cpython

Description: Right now one test in test_xml_etree contains two helpers called check_mapping and check_string: cpython/Lib/test/test_xml_etree.py Lines 206 to 241 in 8dd2766 def check_string(string): len(string) for char in string: self.assertEqual(le...

Open Graph Description: Right now one test in test_xml_etree contains two helpers called check_mapping and check_string: cpython/Lib/test/test_xml_etree.py Lines 206 to 241 in 8dd2766 def check_string(string): len(string)...

X Description: Right now one test in test_xml_etree contains two helpers called check_mapping and check_string: cpython/Lib/test/test_xml_etree.py Lines 206 to 241 in 8dd2766 def check_string(string): len(string)...

Opengraph URL: https://github.com/python/cpython/issues/100933

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Remove `check_string` and `check_mapping` from `test_xml_etree`","articleBody":"Right now one test in `test_xml_etree` contains two helpers called `check_mapping` and `check_string`:\r\n\r\nhttps://github.com/python/cpython/blob/8dd2766d99f8f51ad62dc0fde8282483590c6cd0/Lib/test/test_xml_etree.py#L206-L241\r\n\r\nIt originates from very old code: https://github.com/python/cpython/blob/d9a550b5e14db2748f4fe089c2637c3462ad7d8d/Lib/test/test_xml_etree.py#L140-L169\r\n\r\nIt is half-baked with lots of obvious things to be improved.\r\n\r\nI think that it is safe just to replace them with:\r\n- `check_string` to `assertIsInstance(str)`\r\n- `check_mapping` to `assertIsInstance(dict)`\r\n\r\nIt is more correct, because both Python and C implementations only use `str` and `dict` for checked attributes. And in this case we can skip re-inventing tests for mapping and string.\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-100934\n* gh-101686\n* gh-101687\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/sobolevn","@type":"Person","name":"sobolevn"},"datePublished":"2023-01-11T09:59:32.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/100933/cpython/issues/100933"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:39706e35-5f55-7443-f2be-de153216871b
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAECC:2542A6:1568D30:1D3D013:69694CD3
html-safe-nonce210428f6f1687d68b47b69cb106c7a03d8cd36ef9b12140e746cccd91ac22664
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUNDOjI1NDJBNjoxNTY4RDMwOjFEM0QwMTM6Njk2OTRDRDMiLCJ2aXNpdG9yX2lkIjoiNzgyMDMxNzM5ODI0ODU0MTM5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac58911eb84abd937f538cd306e2c2b585ced8a04afd9ae49e3bf2bc4dd4ac9790
hovercard-subject-tagissue:1528748256
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/100933/issue_layout
twitter:imagehttps://opengraph.githubassets.com/8c86853ab43e415e32ee18efc51ef8e89fc1526ab6c3735f892ee51a89178216/python/cpython/issues/100933
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8c86853ab43e415e32ee18efc51ef8e89fc1526ab6c3735f892ee51a89178216/python/cpython/issues/100933
og:image:altRight now one test in test_xml_etree contains two helpers called check_mapping and check_string: cpython/Lib/test/test_xml_etree.py Lines 206 to 241 in 8dd2766 def check_string(string): len(string)...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesobolevn
hostnamegithub.com
expected-hostnamegithub.com
None54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released69ac0477df0f87da03b8b06cebd187012d7a930
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/100933#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F100933
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F100933
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/100933
Reloadhttps://github.com/python/cpython/issues/100933
Reloadhttps://github.com/python/cpython/issues/100933
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/100933
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/100933
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/100933
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/100933
Remove check_string and check_mapping from test_xml_etreehttps://github.com/python/cpython/issues/100933#top
https://github.com/sobolevn
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
topic-XMLhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-XML%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/sobolevn
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Jan 11, 2023https://github.com/python/cpython/issues/100933#issue-1528748256
cpython/Lib/test/test_xml_etree.pyhttps://github.com/python/cpython/blob/8dd2766d99f8f51ad62dc0fde8282483590c6cd0/Lib/test/test_xml_etree.py#L206-L241
8dd2766https://github.com/python/cpython/commit/8dd2766d99f8f51ad62dc0fde8282483590c6cd0
cpython/Lib/test/test_xml_etree.pyhttps://github.com/python/cpython/blob/d9a550b5e14db2748f4fe089c2637c3462ad7d8d/Lib/test/test_xml_etree.py#L140-L169
d9a550bhttps://github.com/python/cpython/commit/d9a550b5e14db2748f4fe089c2637c3462ad7d8d
gh-100933: Improve check_element helper in test_xml_etree #100934https://github.com/python/cpython/pull/100934
[3.11] gh-100933: Improve check_element helper in test_xml_etree (GH-100934) #101686https://github.com/python/cpython/pull/101686
[3.10] gh-100933: Improve check_element helper in test_xml_etree (GH-100934) #101687https://github.com/python/cpython/pull/101687
sobolevnhttps://github.com/sobolevn
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
topic-XMLhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-XML%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.