Title: Mock spec not respected for attributes prefixed with assert · Issue #100739 · python/cpython · GitHub
Open Graph Title: Mock spec not respected for attributes prefixed with assert · Issue #100739 · python/cpython
X Title: Mock spec not respected for attributes prefixed with assert · Issue #100739 · python/cpython
Description: Bug report Example: from unittest.mock import Mock class Foo: def assert_something(self): pass m = Mock(spec=Foo) m.assert_something() An exception is raised: Traceback (most recent call last): File "
Open Graph Description: Bug report Example: from unittest.mock import Mock class Foo: def assert_something(self): pass m = Mock(spec=Foo) m.assert_something() An exception is raised: Traceback (most recent call last): Fil...
X Description: Bug report Example: from unittest.mock import Mock class Foo: def assert_something(self): pass m = Mock(spec=Foo) m.assert_something() An exception is raised: Traceback (most recent call last): Fil...
Opengraph URL: https://github.com/python/cpython/issues/100739
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Mock spec not respected for attributes prefixed with assert","articleBody":"# Bug report\r\n\r\nExample:\r\n\r\n```python \r\nfrom unittest.mock import Mock\r\nclass Foo:\r\n def assert_something(self):\r\n pass\r\n\r\nm = Mock(spec=Foo)\r\nm.assert_something()\r\n```\r\n\r\nAn exception is raised:\r\n\r\n```pytb\r\nTraceback (most recent call last):\r\n File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\r\n File \"/Users/cklein/github/cklein/cpython/Lib/unittest/mock.py\", line 657, in __getattr__\r\n raise AttributeError(\r\nAttributeError: 'assert_something' is not a valid assertion. Use a spec for the mock if 'assert_something' is meant to be an attribute.\r\n```\r\n\r\nPython 3.9 and lower:\r\n\r\n```pytb\r\nTraceback (most recent call last):\r\n File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\r\n File \"/opt/local/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/unittest/mock.py\", line 635, in __getattr__\r\n raise AttributeError(\"Attributes cannot start with 'assert' \"\r\nAttributeError: Attributes cannot start with 'assert' or 'assret'\r\n```\r\n\r\nThe error message suggests that accessing attributes with prefix \"assert_\" should work when using a spec.\r\n\r\nSee https://github.com/cklein/cpython/commit/735ffc4afa02e832441f563f5c551f83c98bade8 for a possible fix\r\n\r\n# Your environment\r\n\r\n- CPython versions tested on:\r\n - 3.12.0a3+\r\n - 3.11.1\r\n - 3.10.9\r\n - 3.9.16\r\n - 3.8.16\r\n - 3.7.16\r\n- Operating system and architecture:\r\n - Darwin 21.6.0 on arm64\r\n - Linux 5.4.0-1088-aws on x86_64 (only Python 3.7.5 and 3.8.0)\r\n \r\n\r\n\u003c!-- gh-linked-prs --\u003e\r\n### Linked PRs\r\n* gh-100740\r\n* gh-100760\n* gh-100761\n\u003c!-- /gh-linked-prs --\u003e\r\n","author":{"url":"https://github.com/cklein","@type":"Person","name":"cklein"},"datePublished":"2023-01-04T07:16:03.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/100739/cpython/issues/100739"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:0303e974-ecb2-8f6b-28e8-15fee0464eb9 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 88A0:2016E2:1D3A76:27E2B5:6969D57D |
| html-safe-nonce | 41c5cbb0b36910ad3b41215e25467422b25ecf59e4025b7aa6908b79ad4e2646 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OEEwOjIwMTZFMjoxRDNBNzY6MjdFMkI1OjY5NjlENTdEIiwidmlzaXRvcl9pZCI6IjkwNjU3MzA1MDM4ODM3NDA1NDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b8f1afeaa2eb424c5d237aac7484ca00fb8e6c5b4b38e3072e19f31f7c166d3e |
| hovercard-subject-tag | issue:1518452895 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/100739/issue_layout |
| twitter:image | https://opengraph.githubassets.com/4c35896bdd2e549af35cdd038f46c5c5573bbb0e35de46d0e304c75752ababe3/python/cpython/issues/100739 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4c35896bdd2e549af35cdd038f46c5c5573bbb0e35de46d0e304c75752ababe3/python/cpython/issues/100739 |
| og:image:alt | Bug report Example: from unittest.mock import Mock class Foo: def assert_something(self): pass m = Mock(spec=Foo) m.assert_something() An exception is raised: Traceback (most recent call last): Fil... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cklein |
| hostname | github.com |
| expected-hostname | github.com |
| None | acedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 83c08c21cdda978090dc44364b71aa5bc6dcea79 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width