René's URL Explorer Experiment


Title: Mock spec not respected for attributes prefixed with assert · Issue #100739 · python/cpython · GitHub

Open Graph Title: Mock spec not respected for attributes prefixed with assert · Issue #100739 · python/cpython

X Title: Mock spec not respected for attributes prefixed with assert · Issue #100739 · python/cpython

Description: Bug report Example: from unittest.mock import Mock class Foo: def assert_something(self): pass m = Mock(spec=Foo) m.assert_something() An exception is raised: Traceback (most recent call last): File "", line 1, in File "/...

Open Graph Description: Bug report Example: from unittest.mock import Mock class Foo: def assert_something(self): pass m = Mock(spec=Foo) m.assert_something() An exception is raised: Traceback (most recent call last): Fil...

X Description: Bug report Example: from unittest.mock import Mock class Foo: def assert_something(self): pass m = Mock(spec=Foo) m.assert_something() An exception is raised: Traceback (most recent call last): Fil...

Opengraph URL: https://github.com/python/cpython/issues/100739

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Mock spec not respected for attributes prefixed with assert","articleBody":"# Bug report\r\n\r\nExample:\r\n\r\n```python \r\nfrom unittest.mock import Mock\r\nclass Foo:\r\n    def assert_something(self):\r\n         pass\r\n\r\nm = Mock(spec=Foo)\r\nm.assert_something()\r\n```\r\n\r\nAn exception is raised:\r\n\r\n```pytb\r\nTraceback (most recent call last):\r\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\r\n  File \"/Users/cklein/github/cklein/cpython/Lib/unittest/mock.py\", line 657, in __getattr__\r\n    raise AttributeError(\r\nAttributeError: 'assert_something' is not a valid assertion. Use a spec for the mock if 'assert_something' is meant to be an attribute.\r\n```\r\n\r\nPython 3.9 and lower:\r\n\r\n```pytb\r\nTraceback (most recent call last):\r\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\r\n  File \"/opt/local/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/unittest/mock.py\", line 635, in __getattr__\r\n    raise AttributeError(\"Attributes cannot start with 'assert' \"\r\nAttributeError: Attributes cannot start with 'assert' or 'assret'\r\n```\r\n\r\nThe error message suggests that accessing attributes with prefix \"assert_\" should work when using a spec.\r\n\r\nSee https://github.com/cklein/cpython/commit/735ffc4afa02e832441f563f5c551f83c98bade8 for a possible fix\r\n\r\n# Your environment\r\n\r\n- CPython versions tested on:\r\n - 3.12.0a3+\r\n - 3.11.1\r\n - 3.10.9\r\n - 3.9.16\r\n - 3.8.16\r\n - 3.7.16\r\n- Operating system and architecture:\r\n  - Darwin 21.6.0 on arm64\r\n  - Linux 5.4.0-1088-aws on x86_64 (only Python 3.7.5 and 3.8.0)\r\n  \r\n\r\n\u003c!-- gh-linked-prs --\u003e\r\n### Linked PRs\r\n* gh-100740\r\n* gh-100760\n* gh-100761\n\u003c!-- /gh-linked-prs --\u003e\r\n","author":{"url":"https://github.com/cklein","@type":"Person","name":"cklein"},"datePublished":"2023-01-04T07:16:03.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/100739/cpython/issues/100739"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:0303e974-ecb2-8f6b-28e8-15fee0464eb9
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id88A0:2016E2:1D3A76:27E2B5:6969D57D
html-safe-nonce41c5cbb0b36910ad3b41215e25467422b25ecf59e4025b7aa6908b79ad4e2646
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OEEwOjIwMTZFMjoxRDNBNzY6MjdFMkI1OjY5NjlENTdEIiwidmlzaXRvcl9pZCI6IjkwNjU3MzA1MDM4ODM3NDA1NDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb8f1afeaa2eb424c5d237aac7484ca00fb8e6c5b4b38e3072e19f31f7c166d3e
hovercard-subject-tagissue:1518452895
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/100739/issue_layout
twitter:imagehttps://opengraph.githubassets.com/4c35896bdd2e549af35cdd038f46c5c5573bbb0e35de46d0e304c75752ababe3/python/cpython/issues/100739
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4c35896bdd2e549af35cdd038f46c5c5573bbb0e35de46d0e304c75752ababe3/python/cpython/issues/100739
og:image:altBug report Example: from unittest.mock import Mock class Foo: def assert_something(self): pass m = Mock(spec=Foo) m.assert_something() An exception is raised: Traceback (most recent call last): Fil...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecklein
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/100739#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F100739
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F100739
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/100739
Reloadhttps://github.com/python/cpython/issues/100739
Reloadhttps://github.com/python/cpython/issues/100739
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/100739
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/100739
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/100739
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/100739
Mock spec not respected for attributes prefixed with asserthttps://github.com/python/cpython/issues/100739#top
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/cklein
https://github.com/cklein
ckleinhttps://github.com/cklein
on Jan 4, 2023https://github.com/python/cpython/issues/100739#issue-1518452895
cklein@735ffc4https://github.com/cklein/cpython/commit/735ffc4afa02e832441f563f5c551f83c98bade8
gh-100739: Respect mock spec when checking for unsafe prefixes #100740https://github.com/python/cpython/pull/100740
[3.11] gh-100739: Respect mock spec when checking for unsafe prefixes (GH-100740) #100760https://github.com/python/cpython/pull/100760
[3.10] gh-100739: Respect mock spec when checking for unsafe prefixes (GH-100740) #100761https://github.com/python/cpython/pull/100761
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.