René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Errors in specialisation stats for STORE_ATTR","articleBody":"There seem to be some copy-paste errors in specialize.c, which cause failures for STORE_ATTR to be attributed to LOAD_ATTR:\r\n\r\n```\r\n@@ -860,7 +860,7 @@ _Py_Specialize_StoreAttr(PyObject *owner, _Py_CODEUNIT *instr, PyObject *name)\r\n         // We *might* not really need this check, but we inherited it from\r\n         // PyObject_GenericSetAttr and friends... and this way we still do the\r\n         // right thing if someone forgets to call PyType_Ready(type):\r\n-        SPECIALIZATION_FAIL(LOAD_ATTR, SPEC_FAIL_OTHER);\r\n+        SPECIALIZATION_FAIL(STORE_ATTR, SPEC_FAIL_OTHER);\r\n         goto fail;\r\n     }\r\n     if (PyModule_CheckExact(owner)) {\r\n@@ -915,16 +915,16 @@ _Py_Specialize_StoreAttr(PyObject *owner, _Py_CODEUNIT *instr, PyObject *name)\r\n             SPECIALIZATION_FAIL(STORE_ATTR, SPEC_FAIL_OVERRIDDEN);\r\n             goto fail;\r\n         case BUILTIN_CLASSMETHOD:\r\n-            SPECIALIZATION_FAIL(LOAD_ATTR, SPEC_FAIL_ATTR_BUILTIN_CLASS_METHOD_OBJ);\r\n+            SPECIALIZATION_FAIL(STORE_ATTR, SPEC_FAIL_ATTR_BUILTIN_CLASS_METHOD_OBJ);\r\n             goto fail;\r\n         case PYTHON_CLASSMETHOD:\r\n-            SPECIALIZATION_FAIL(LOAD_ATTR, SPEC_FAIL_ATTR_CLASS_METHOD_OBJ);\r\n+            SPECIALIZATION_FAIL(STORE_ATTR, SPEC_FAIL_ATTR_CLASS_METHOD_OBJ);\r\n             goto fail;\r\n         case NON_OVERRIDING:\r\n-            SPECIALIZATION_FAIL(LOAD_ATTR, SPEC_FAIL_ATTR_CLASS_ATTR_DESCRIPTOR);\r\n+            SPECIALIZATION_FAIL(STORE_ATTR, SPEC_FAIL_ATTR_CLASS_ATTR_DESCRIPTOR);\r\n             goto fail;\r\n         case NON_DESCRIPTOR:\r\n-            SPECIALIZATION_FAIL(LOAD_ATTR, SPEC_FAIL_ATTR_CLASS_ATTR_SIMPLE);\r\n+            SPECIALIZATION_FAIL(STORE_ATTR, SPEC_FAIL_ATTR_CLASS_ATTR_SIMPLE);\r\n             goto fail;\r\n         case ABSENT:\r\n             if (specialize_dict_access(owner, instr, type, kind, name, STORE_ATTR,\r\n```\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-100460\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/iritkatriel","@type":"Person","name":"iritkatriel"},"datePublished":"2022-12-23T14:12:02.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/100459/cpython/issues/100459"}