René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"unittest.mock.seal doesn't work as expected with AsyncMock","articleBody":"I noticed this while reviewing https://github.com/python/cpython/pull/100252#discussion_r1050456588\r\n\r\nI believe the following test case should pass, but it doesn't on main\r\n\r\n```python\r\nimport unittest\r\nfrom unittest.mock import Mock, seal\r\n\r\nclass AsyncClass:\r\n    async def async_method(self): pass\r\n    def normal_method(self): pass\r\n\r\nclass Case(unittest.TestCase):\r\n    def test_spec_normal_methods_on_class_with_mock_seal(self):\r\n        mock = Mock(AsyncClass)\r\n        seal(mock)\r\n        # test passes, aka this raises AttributError\r\n        with self.assertRaises(AttributeError):\r\n            mock.normal_method\r\n        # test fails, aka this does not raise AttributError\r\n        with self.assertRaises(AttributeError):\r\n            mock.async_method\r\n\r\nunittest.main()\r\n```\r\n\r\nIt's easy to fix, just need to move the clause that handles AsyncMock after the `if self._mock_sealed:` check.\r\n\r\ncc @sobolevn who moved the `if self._mock_sealed:` check earlier in https://github.com/python/cpython/pull/28300/files , but not all the way\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-100496\n* gh-100506\n* gh-100508\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/hauntsaninja","@type":"Person","name":"hauntsaninja"},"datePublished":"2022-12-16T08:15:09.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/100287/cpython/issues/100287"}