René's URL Explorer Experiment


Title: Improve duck type compatibility of int with float · Issue #100268 · python/cpython · GitHub

Open Graph Title: Improve duck type compatibility of int with float · Issue #100268 · python/cpython

X Title: Improve duck type compatibility of int with float · Issue #100268 · python/cpython

Description: Feature or enhancement Function arguments and variables annotated with float should not allow value of type int. Pitch PEP484 suggested that when an argument is annotated as having type float, an argument of type int is acceptable;. This...

Open Graph Description: Feature or enhancement Function arguments and variables annotated with float should not allow value of type int. Pitch PEP484 suggested that when an argument is annotated as having type float, an a...

X Description: Feature or enhancement Function arguments and variables annotated with float should not allow value of type int. Pitch PEP484 suggested that when an argument is annotated as having type float, an a...

Opengraph URL: https://github.com/python/cpython/issues/100268

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Improve duck type compatibility of int with float","articleBody":"# Feature or enhancement\r\n\r\nFunction arguments and variables annotated with `float` should not allow value of type `int.`\r\n\r\n# Pitch\r\n\r\n[PEP484](https://peps.python.org/pep-0484/) suggested that `when an argument is annotated as having type float, an argument of type int is acceptable;`. This allows this kind of typing to be valid:\r\n\r\n`x: float = 2`\r\n\r\nBut `int` is not subtype of `float` and doesn't provide the same interface. Float provides methods that are not available in `int`:\r\n\r\n- `is_integer`\r\n- `fromhex`\r\n- `hex`\r\n\r\nThis violates LSP and is problematic especially with `is_integer`:\r\n\r\n```python\r\ndef method_requiring_whole_number_float(number: float):\r\n    if number.is_integer():\r\n        ...\r\n```\r\n\r\nThis method clearly states that it requires `float` and as an author of such code, I would expect that `is_integer` would be available if my typing is correct.\r\n\r\nThere are workarounds (`if int(number) == number:`) but they render the `is_integer` useless as it can never be safely used.\r\n\r\nJust adding the missing methods to `int` (or removing the extra methods from `float`) would not be valid solution as there are other problems stemming from the fact that `int` is not `float`. Eg.:\r\n\r\n```python\r\ndef split_whole_and_decimal(number: float) -\u003e tuple[str, str]:\r\n    return str(number).split('.')  # it's reasonable to expect that the output contains a dot `.` as  `float` does but `int` doesn't \r\n```\r\n\r\nI'm proposing an errata to PEP484 that will remove `when an argument is annotated as having type float, an argument of type int is acceptable;`.\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-100439\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/JakubTesarek","@type":"Person","name":"JakubTesarek"},"datePublished":"2022-12-15T14:17:07.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":12},"url":"https://github.com/100268/cpython/issues/100268"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:394c22e6-afd3-2ed1-0fe4-d857e99f5d2b
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE690:4D9DF:2301713:3164712:69691AA7
html-safe-noncee97f53f257f19fdac9cd8ce4938a23e744b0b8a8c6a447552040a9213645b60c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjkwOjREOURGOjIzMDE3MTM6MzE2NDcxMjo2OTY5MUFBNyIsInZpc2l0b3JfaWQiOiI0NzQwNDU4MTc2MzQxMTU0NDcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb594c4de445442fe22510830ecfef9ed4a00dfc4116a6b379fe0da68fce7b881
hovercard-subject-tagissue:1498520249
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/100268/issue_layout
twitter:imagehttps://opengraph.githubassets.com/6269845910eef895008327be6d6b84da9818a2ca927b51e09a60d4340eaa9048/python/cpython/issues/100268
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6269845910eef895008327be6d6b84da9818a2ca927b51e09a60d4340eaa9048/python/cpython/issues/100268
og:image:altFeature or enhancement Function arguments and variables annotated with float should not allow value of type int. Pitch PEP484 suggested that when an argument is annotated as having type float, an a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJakubTesarek
hostnamegithub.com
expected-hostnamegithub.com
None0e60568924309a021b51adabdce15c2a2f285b556f3130d1a2fa2a5bce11c55f
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd206f7ed6207863172be4a783826e86bd2375c3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/100268#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F100268
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F100268
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/100268
Reloadhttps://github.com/python/cpython/issues/100268
Reloadhttps://github.com/python/cpython/issues/100268
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/100268
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/100268
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/100268
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/100268
Improve duck type compatibility of int with floathttps://github.com/python/cpython/issues/100268#top
topic-typinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-typing%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com/JakubTesarek
https://github.com/JakubTesarek
JakubTesarekhttps://github.com/JakubTesarek
on Dec 15, 2022https://github.com/python/cpython/issues/100268#issue-1498520249
PEP484https://peps.python.org/pep-0484/
gh-100268: Add is_integer method to int #100439https://github.com/python/cpython/pull/100439
topic-typinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-typing%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.