René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`make sharedinstall` does not return failure if install commands fail","articleBody":"# Bug report\r\n\r\nIf `make sharedinstall` fails to install some Python extensions, the make target wrongly succeeds. For example, I'm seeing:\r\n\r\n```\r\n/usr/bin/install -c -m 755 Modules/array.cpython-312-x86_64-linux-gnu.so /usr/lib/python3.12/lib-dynload/array.cpython-312-x86_64-linux-gnu.so\r\n/usr/bin/install: cannot create regular file '/var/tmp/portage/dev-lang/python-3.12.0_alpha3/image/usr/lib/python3.12/lib-dynload/array.cpython-312-x86_64-linux-gnu.so': No such file or directory\r\n/usr/bin/install -c -m 755 Modules/_asyncio.cpython-312-x86_64-linux-gnu.so /usr/lib/python3.12/lib-dynload/_asyncio.cpython-312-x86_64-linux-gnu.so\r\n/usr/bin/install: cannot create regular file '/var/tmp/portage/dev-lang/python-3.12.0_alpha3/image/usr/lib/python3.12/lib-dynload/_asyncio.cpython-312-x86_64-linux-gnu.so': No such file or directory\r\n/usr/bin/install -c -m 755 Modules/_bisect.cpython-312-x86_64-linux-gnu.so /usr/lib/python3.12/lib-dynload/_bisect.cpython-312-x86_64-linux-gnu.so\r\n[...]\r\n```\r\n\r\nNevertheless, `make install` returns successfully in this case. This causes major problems for automated builds since they end up with broken Python installs when the make target should have failed.\r\n\r\nI need to investigate why it's failing but that's a separate issue.\r\n\r\nComplete build log (1.2M): [dev-lang:python-3.12.0_alpha3:20221207-142002.log](https://github.com/python/cpython/files/10218273/dev-lang.python-3.12.0_alpha3.20221207-142002.log)\r\n\r\nThe problem seems to be that the `sharedinstall` targets runs a single shell command and make doesn't check the exit status until its very end.\r\n\r\nI suspect the same problem may apply to other install rules.\r\n\r\n# Your environment\r\n\r\n- CPython versions tested on: 3.12.0a3\r\n- Operating system and architecture: Gentoo Linux/amd64\r\n\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-100328\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/mgorny","@type":"Person","name":"mgorny"},"datePublished":"2022-12-13T13:32:38.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/100220/cpython/issues/100220"}