Title: Mark PRs based on their stage of review · Issue #94 · python/core-workflow · GitHub
Open Graph Title: Mark PRs based on their stage of review · Issue #94 · python/core-workflow
X Title: Mark PRs based on their stage of review · Issue #94 · python/core-workflow
Description: The idea is to make it so that it's very clear to a core dev waiting for review comments to be addressed that the PR is ready for another round of review. Probably something along the lines of when a core dev leaves a "Changes Requested"...
Open Graph Description: The idea is to make it so that it's very clear to a core dev waiting for review comments to be addressed that the PR is ready for another round of review. Probably something along the lines of when...
X Description: The idea is to make it so that it's very clear to a core dev waiting for review comments to be addressed that the PR is ready for another round of review. Probably something along the lines of ...
Opengraph URL: https://github.com/python/core-workflow/issues/94
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Mark PRs based on their stage of review","articleBody":"The idea is to make it so that it's very clear to a core dev waiting for review comments to be addressed that the PR is ready for another round of review. Probably something along the lines of when a core dev leaves a \"Changes Requested\" review that a label is applied like \"WIP\" and then a comment left for the PR submitter saying that they should send a message to the reviewer like `@brettcannon ready for review` (changing the title was shot down by Guido at the PyCon US 2017 language summit). That way the reviewer gets a mention notification and the bot can then remove the label. This should lead to the PR showing up in GitHub's notification in a visible way that it's ready for another round of reviews.\r\n\r\nI'm not sure if a label signaling another round of review is necessary as the absence of the \"WIP\" label is a visual signal of that. But perhaps an explicitly \"waiting for review\" label would also be helpful? This could also be automatically applied to all new PRs to signal when a PR is awaiting an initial review (or an alternative \"initial review needed\" label?). I also don't know how external reviews play into this, e.g. do we have \"need core review\" when an external person left a review but a core dev has yet to review?","author":{"url":"https://github.com/brettcannon","@type":"Person","name":"brettcannon"},"datePublished":"2017-05-18T22:17:55.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":11},"url":"https://github.com/94/core-workflow/issues/94"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6b859015-d5e0-74dd-8da7-4ce6009dc021 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E620:16BCD3:6729B40:919D964:6A4FE217 |
| html-safe-nonce | ffd5308a1853ee46e128d32d908c9baa06363f6da8749abda1859de5d43869d1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjIwOjE2QkNEMzo2NzI5QjQwOjkxOUQ5NjQ6NkE0RkUyMTciLCJ2aXNpdG9yX2lkIjoiNTIyMDYyMjI5NTg0NDc3NDQyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5911e11ae9e11121ff4b3f782bdc351b4fb21cd5558692533685f5b503dd6431 |
| hovercard-subject-tag | issue:229820521 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/core-workflow/94/issue_layout |
| twitter:image | https://opengraph.githubassets.com/68cd705c59cdaf05766e3fc2045e26b62e2ae794d4f786308def393ee48b8f74/python/core-workflow/issues/94 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/68cd705c59cdaf05766e3fc2045e26b62e2ae794d4f786308def393ee48b8f74/python/core-workflow/issues/94 |
| og:image:alt | The idea is to make it so that it's very clear to a core dev waiting for review comments to be addressed that the PR is ready for another round of review. Probably something along the lines of when... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | brettcannon |
| hostname | github.com |
| expected-hostname | github.com |
| None | 19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c |
| turbo-cache-control | no-preview |
| go-import | github.com/python/core-workflow git https://github.com/python/core-workflow.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 76080865 |
| octolytics-dimension-repository_nwo | python/core-workflow |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 76080865 |
| octolytics-dimension-repository_network_root_nwo | python/core-workflow |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 142593e66413bbae27fd485859993597d5a3b104 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width