Title: Replace deprecated `readthedocs/actions/preview` · Issue #587 · python/core-workflow · GitHub
Open Graph Title: Replace deprecated `readthedocs/actions/preview` · Issue #587 · python/core-workflow
X Title: Replace deprecated `readthedocs/actions/preview` · Issue #587 · python/core-workflow
Description: As I was reviewing the python/cpython workflows for security issues, I noticed that documentation-links.yml uses pull_request_target, which is potentially dangerous: https://securitylab.github.com/resources/github-actions-preventing-pwn-...
Open Graph Description: As I was reviewing the python/cpython workflows for security issues, I noticed that documentation-links.yml uses pull_request_target, which is potentially dangerous: https://securitylab.github.com/...
X Description: As I was reviewing the python/cpython workflows for security issues, I noticed that documentation-links.yml uses pull_request_target, which is potentially dangerous: https://securitylab.github.com/...
Opengraph URL: https://github.com/python/core-workflow/issues/587
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Replace deprecated `readthedocs/actions/preview`","articleBody":"As I was reviewing the `python/cpython` workflows for security issues, I noticed that [`documentation-links.yml`](https://github.com/python/cpython/blob/main/.github/workflows/documentation-links.yml#L6) uses `pull_request_target`, which is potentially dangerous:\n* https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/\n* https://github.com/readthedocs/actions/issues/45\n\nThis is apparently required by `readthedocs/actions/preview` in order to edit the first PR message and add the link to the doc preview.\n\nHowever I also noticed that [`readthedocs/actions/preview`](https://github.com/readthedocs/actions?tab=readme-ov-file) is now deprecated and that its README states:\n\n\u003e [!WARNING] \n\u003e **This action is deprecated and it shouldn't be used.**\n\u003e This feature was included in the Read the Docs application itself.\n\u003e For more information, check [our documentation](https://docs.readthedocs.com/platform/stable/visual-diff.html#show-build-overview-in-pull-requests).\n\nAs an alternative they suggest to connect their GitHub app and use that instead. Instead of editing the first comment, the app will add a comment which will list and link to changed/added/deleted files.\nNote that [the app](https://about.readthedocs.com/blog/2025/06/announcing-our-github-app-beta/) is still in beta.\n\nIf we switch to the app we can stop using the deprecated action get rid of the `documentation-links.yml` workflow and `pull_request_target` use.\n\nI brought this up to @hugovk attention, and he suggested to try the app on one of the other (smaller) repos first:\n* [ ] [`devguide`](https://github.com/python/devguide/blob/main/.github/workflows/documentation-links.yml): [devguide#1713](https://github.com/python/devguide/pull/1713)\n* [ ] [`peps`](https://github.com/python/peps/blob/1b13e95ea8713f0d90b020e1a7ba4e65de735e06/.github/workflows/documentation-links.yml#L21)\n* [ ] [`python-docs-theme`](https://github.com/python/python-docs-theme/blob/ae83e69a9ce370c9f7f4c27bd37ad5e6536fea76/.github/workflows/documentation-links.yml#L21)\n* [ ] [`docs-community`](https://github.com/python/docs-community/blob/b9aa7830fdc1ea2c29c1f335ec6face1791a1d2e/.github/workflows/documentation-links.yml#L15)\n\nIf it works fine and we are happy with it, we can then update all the other repos (including `cpython`).\n\n* [ ] `cpython`\n\ncc @humitos","author":{"url":"https://github.com/ezio-melotti","@type":"Person","name":"ezio-melotti"},"datePublished":"2025-11-10T12:53:30.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/587/core-workflow/issues/587"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:728d8c1f-ac45-0dd0-4a67-dfd275ad3842 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | EBAE:3244AB:14113B7:1B0644A:6969B23E |
| html-safe-nonce | ad014f791a123cc7631651f779bd97bc0c9ea49baeefdc8a48a76cc270f6f374 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkFFOjMyNDRBQjoxNDExM0I3OjFCMDY0NEE6Njk2OUIyM0UiLCJ2aXNpdG9yX2lkIjoiNDI0MDA4MzU1OTk2MDM5MjI1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ba23b28925477d08be44285d22f1ca5a8ea306d3dba4d3f8db5d4cd8b1714c85 |
| hovercard-subject-tag | issue:3607926439 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/core-workflow/587/issue_layout |
| twitter:image | https://opengraph.githubassets.com/912861fec24295679f63b5595ce09a6bdfb67d0f79b94118e01682683dbea9f7/python/core-workflow/issues/587 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/912861fec24295679f63b5595ce09a6bdfb67d0f79b94118e01682683dbea9f7/python/core-workflow/issues/587 |
| og:image:alt | As I was reviewing the python/cpython workflows for security issues, I noticed that documentation-links.yml uses pull_request_target, which is potentially dangerous: https://securitylab.github.com/... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ezio-melotti |
| hostname | github.com |
| expected-hostname | github.com |
| None | b23b8fcc855cd29bb04d6c94aafa62d336bf44eefa8229444eecc968cad03aee |
| turbo-cache-control | no-preview |
| go-import | github.com/python/core-workflow git https://github.com/python/core-workflow.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 76080865 |
| octolytics-dimension-repository_nwo | python/core-workflow |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 76080865 |
| octolytics-dimension-repository_network_root_nwo | python/core-workflow |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0672399d88424758731ec07fe24509e23bb17fb5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width