Title: Should we make the Docs CI mandatory on the Python main branch? · Issue #424 · python/core-workflow · GitHub
Open Graph Title: Should we make the Docs CI mandatory on the Python main branch? · Issue #424 · python/core-workflow
X Title: Should we make the Docs CI mandatory on the Python main branch? · Issue #424 · python/core-workflow
Description: Hi, When I wanted to merge my fix GH fix, I saw that the Docs CI failed. After looking at the failure, I saw that it was unrelated to my change, but was caused by a recent enum documentation change: https://bugs.python.org/issue40066#msg...
Open Graph Description: Hi, When I wanted to merge my fix GH fix, I saw that the Docs CI failed. After looking at the failure, I saw that it was unrelated to my change, but was caused by a recent enum documentation change...
X Description: Hi, When I wanted to merge my fix GH fix, I saw that the Docs CI failed. After looking at the failure, I saw that it was unrelated to my change, but was caused by a recent enum documentation change...
Opengraph URL: https://github.com/python/core-workflow/issues/424
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Should we make the Docs CI mandatory on the Python main branch?","articleBody":"Hi,\r\n\r\nWhen I wanted to merge my [fix GH](https://github.com/python/cpython/pull/30631) fix, I saw that the Docs CI failed. After looking at the failure, I saw that it was unrelated to my change, but was caused by a recent enum documentation change: https://bugs.python.org/issue40066#msg410711\r\n\r\nI reverted the enum change to merge my PR. The enum PR was merged even if the Docs CI failed. Well, the Docs job is not mandatory.\r\n\r\nShould we make the Docs CI mandatory on the Python main branch? cc @tiran @zware \r\n\r\nIs there a reason to not make the Docs CI mandatory? Was it flaky last months? cc @willingc @JulienPalard \r\n\r\nBy the way, who has access to the Python branch protection now? I used to ping Brett, but he wrote that he prefers to no longer be responsible for that. https://mail.python.org/archives/list/python-committers@python.org/thread/GB7T23XWLNKR24V5IWBADYSLFK6KWCY6/\r\n\r\nVictor","author":{"url":"https://github.com/vstinner","@type":"Person","name":"vstinner"},"datePublished":"2022-01-17T16:06:10.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":9},"url":"https://github.com/424/core-workflow/issues/424"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:5cb33550-9e24-ea67-79e0-adddea2ee95f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9E92:2B46F2:CDFFC7:12005E2:696A664D |
| html-safe-nonce | 52879672078a8dfff618d2059052d041203039a9a69787a8a38eb28536c323c7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTkyOjJCNDZGMjpDREZGQzc6MTIwMDVFMjo2OTZBNjY0RCIsInZpc2l0b3JfaWQiOiI3MzQ2NjgxMzk3MTIxODAzODUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c886a6d0d81b33bc2d8c6c363a31532cf1a1ae5c7b79b4f07b3046dbc6cd87dc |
| hovercard-subject-tag | issue:1106032642 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/core-workflow/424/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b87684a86d117a02542a00673a694ebf47ac3bc5efbd00e6641b15e066e01af3/python/core-workflow/issues/424 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b87684a86d117a02542a00673a694ebf47ac3bc5efbd00e6641b15e066e01af3/python/core-workflow/issues/424 |
| og:image:alt | Hi, When I wanted to merge my fix GH fix, I saw that the Docs CI failed. After looking at the failure, I saw that it was unrelated to my change, but was caused by a recent enum documentation change... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | vstinner |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/core-workflow git https://github.com/python/core-workflow.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 76080865 |
| octolytics-dimension-repository_nwo | python/core-workflow |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 76080865 |
| octolytics-dimension-repository_network_root_nwo | python/core-workflow |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87cbd411c2982752221b5751d583a515b23bf5fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width