René's URL Explorer Experiment


Title: Review dismissal · Issue #36 · python/core-workflow · GitHub

Open Graph Title: Review dismissal · Issue #36 · python/core-workflow

X Title: Review dismissal · Issue #36 · python/core-workflow

Description: It appears that a 'request changes' review blocks merge even if another core-dev approves. I'm not sure whether two approvals would override a 'request changes', but it is possible to dismiss a review; we should decide criteria for dismi...

Open Graph Description: It appears that a 'request changes' review blocks merge even if another core-dev approves. I'm not sure whether two approvals would override a 'request changes', but it is possible to dismiss a rev...

X Description: It appears that a 'request changes' review blocks merge even if another core-dev approves. I'm not sure whether two approvals would override a 'request changes', but it is possi...

Opengraph URL: https://github.com/python/core-workflow/issues/36

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Review dismissal","articleBody":"It appears that a 'request changes' review blocks merge even if another core-dev approves.  I'm not sure whether two approvals would override a 'request changes', but it is possible to dismiss a review; we should decide criteria for dismissing another core-dev's review here and document it in the devguide.\r\n\r\nFor example, python/cpython#27 was blocked by my outdated review, even though @methane had made the changes I had requested and @ncoghlan had approved the change.  Frankly, I had forgotten that I had reviewed that PR, so I would have had no problem with either of the other involved core-devs dismissing my review.","author":{"url":"https://github.com/zware","@type":"Person","name":"zware"},"datePublished":"2017-02-19T23:54:00.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":8},"url":"https://github.com/36/core-workflow/issues/36"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:58b3150d-ac36-1296-39ce-8294c2ab79df
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC4F6:345820:F75CDD:153F1F6:6969F7F1
html-safe-nonce5822b9f5d886e448718b4c3fea4b09ade4c7ef31a089641b53a5e09f56f1dda4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNEY2OjM0NTgyMDpGNzVDREQ6MTUzRjFGNjo2OTY5RjdGMSIsInZpc2l0b3JfaWQiOiIzODE0ODkwNzk5OTA3ODYyNTEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9e1e7376be6046b137ab22865c883f374d5a9f96db69e659c2fb97d71f2a994b
hovercard-subject-tagissue:208757605
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/core-workflow/36/issue_layout
twitter:imagehttps://opengraph.githubassets.com/6e7768e3524082f41796656d16f13f231e35957e8d77e74c9d7c71b617263b71/python/core-workflow/issues/36
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6e7768e3524082f41796656d16f13f231e35957e8d77e74c9d7c71b617263b71/python/core-workflow/issues/36
og:image:altIt appears that a 'request changes' review blocks merge even if another core-dev approves. I'm not sure whether two approvals would override a 'request changes', but it is possible to dismiss a rev...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezware
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/python/core-workflow git https://github.com/python/core-workflow.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id76080865
octolytics-dimension-repository_nwopython/core-workflow
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id76080865
octolytics-dimension-repository_network_root_nwopython/core-workflow
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/core-workflow/issues/36#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcore-workflow%2Fissues%2F36
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcore-workflow%2Fissues%2F36
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcore-workflow
Reloadhttps://github.com/python/core-workflow/issues/36
Reloadhttps://github.com/python/core-workflow/issues/36
Reloadhttps://github.com/python/core-workflow/issues/36
python https://github.com/python
core-workflowhttps://github.com/python/core-workflow
Please reload this pagehttps://github.com/python/core-workflow/issues/36
Notifications https://github.com/login?return_to=%2Fpython%2Fcore-workflow
Fork 59 https://github.com/login?return_to=%2Fpython%2Fcore-workflow
Star 104 https://github.com/login?return_to=%2Fpython%2Fcore-workflow
Code https://github.com/python/core-workflow
Issues 8 https://github.com/python/core-workflow/issues
Pull requests 0 https://github.com/python/core-workflow/pulls
Actions https://github.com/python/core-workflow/actions
Projects 2 https://github.com/python/core-workflow/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/core-workflow/security
Please reload this pagehttps://github.com/python/core-workflow/issues/36
Insights https://github.com/python/core-workflow/pulse
Code https://github.com/python/core-workflow
Issues https://github.com/python/core-workflow/issues
Pull requests https://github.com/python/core-workflow/pulls
Actions https://github.com/python/core-workflow/actions
Projects https://github.com/python/core-workflow/projects
Security https://github.com/python/core-workflow/security
Insights https://github.com/python/core-workflow/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/core-workflow/issues/36
New issuehttps://github.com/login?return_to=https://github.com/python/core-workflow/issues/36
Review dismissalhttps://github.com/python/core-workflow/issues/36#top
https://github.com/zware
https://github.com/zware
zwarehttps://github.com/zware
on Feb 19, 2017https://github.com/python/core-workflow/issues/36#issue-208757605
python/cpython#27https://github.com/python/cpython/pull/27
@methanehttps://github.com/methane
@ncoghlanhttps://github.com/ncoghlan
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.