Title: Review dismissal · Issue #36 · python/core-workflow · GitHub
Open Graph Title: Review dismissal · Issue #36 · python/core-workflow
X Title: Review dismissal · Issue #36 · python/core-workflow
Description: It appears that a 'request changes' review blocks merge even if another core-dev approves. I'm not sure whether two approvals would override a 'request changes', but it is possible to dismiss a review; we should decide criteria for dismi...
Open Graph Description: It appears that a 'request changes' review blocks merge even if another core-dev approves. I'm not sure whether two approvals would override a 'request changes', but it is possible to dismiss a rev...
X Description: It appears that a 'request changes' review blocks merge even if another core-dev approves. I'm not sure whether two approvals would override a 'request changes', but it is possi...
Opengraph URL: https://github.com/python/core-workflow/issues/36
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Review dismissal","articleBody":"It appears that a 'request changes' review blocks merge even if another core-dev approves. I'm not sure whether two approvals would override a 'request changes', but it is possible to dismiss a review; we should decide criteria for dismissing another core-dev's review here and document it in the devguide.\r\n\r\nFor example, python/cpython#27 was blocked by my outdated review, even though @methane had made the changes I had requested and @ncoghlan had approved the change. Frankly, I had forgotten that I had reviewed that PR, so I would have had no problem with either of the other involved core-devs dismissing my review.","author":{"url":"https://github.com/zware","@type":"Person","name":"zware"},"datePublished":"2017-02-19T23:54:00.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":8},"url":"https://github.com/36/core-workflow/issues/36"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:58b3150d-ac36-1296-39ce-8294c2ab79df |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C4F6:345820:F75CDD:153F1F6:6969F7F1 |
| html-safe-nonce | 5822b9f5d886e448718b4c3fea4b09ade4c7ef31a089641b53a5e09f56f1dda4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNEY2OjM0NTgyMDpGNzVDREQ6MTUzRjFGNjo2OTY5RjdGMSIsInZpc2l0b3JfaWQiOiIzODE0ODkwNzk5OTA3ODYyNTEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9e1e7376be6046b137ab22865c883f374d5a9f96db69e659c2fb97d71f2a994b |
| hovercard-subject-tag | issue:208757605 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/core-workflow/36/issue_layout |
| twitter:image | https://opengraph.githubassets.com/6e7768e3524082f41796656d16f13f231e35957e8d77e74c9d7c71b617263b71/python/core-workflow/issues/36 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6e7768e3524082f41796656d16f13f231e35957e8d77e74c9d7c71b617263b71/python/core-workflow/issues/36 |
| og:image:alt | It appears that a 'request changes' review blocks merge even if another core-dev approves. I'm not sure whether two approvals would override a 'request changes', but it is possible to dismiss a rev... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zware |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/core-workflow git https://github.com/python/core-workflow.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 76080865 |
| octolytics-dimension-repository_nwo | python/core-workflow |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 76080865 |
| octolytics-dimension-repository_network_root_nwo | python/core-workflow |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width