René's URL Explorer Experiment


Title: Delay closing SubprocessStreamProtocol's Transport until all pipes are closed. by sethmlarson · Pull Request #485 · python/asyncio · GitHub

Open Graph Title: Delay closing SubprocessStreamProtocol's Transport until all pipes are closed. by sethmlarson · Pull Request #485 · python/asyncio

X Title: Delay closing SubprocessStreamProtocol's Transport until all pipes are closed. by sethmlarson · Pull Request #485 · python/asyncio

Description: I believe this change fixes #484. Delays the closing for SubprocessStreamProtocol._transport until all pipes have been closed and the process has exited rather than just the process exiting. This allows for reading data from the subprocess that is still pending in the pipe after the process has exited. I haven't run tests or created a test for this exact issue but I will create a few tests later.

Open Graph Description: I believe this change fixes #484. Delays the closing for SubprocessStreamProtocol._transport until all pipes have been closed and the process has exited rather than just the process exiting. This a...

X Description: I believe this change fixes #484. Delays the closing for SubprocessStreamProtocol._transport until all pipes have been closed and the process has exited rather than just the process exiting. This a...

Opengraph URL: https://github.com/python/asyncio/pull/485

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a1dae549-79e1-1b7c-9dad-7ee571c8972e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC34:15E5F9:250CD48:3285256:6B003A3F
html-safe-nonce6311d5a042f86d0aac5aebfbd2e6dcdfcfce6143eac4f8f09564c100acab5025
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzM0OjE1RTVGOToyNTBDRDQ4OjMyODUyNTY6NkIwMDNBM0YiLCJ2aXNpdG9yX2lkIjoiMzcwNDczMzA2NTM4NjU0MjcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac869e9871db9a506eb4fb5c2774c83018053d72963f718bc72b01525befa77572
hovercard-subject-tagpull_request:101521253
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/asyncio/pull/485/files
twitter:imagehttps://avatars.githubusercontent.com/u/18519037?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/18519037?s=400&v=4
og:image:altI believe this change fixes #484. Delays the closing for SubprocessStreamProtocol._transport until all pipes have been closed and the process has exited rather than just the process exiting. This a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/asyncio git https://github.com/python/asyncio.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id33739295
octolytics-dimension-repository_nwopython/asyncio
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id33739295
octolytics-dimension-repository_network_root_nwopython/asyncio
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/asyncio/pull/485/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fasyncio%2Fpull%2F485%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fasyncio%2Fpull%2F485%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fasyncio
Reloadhttps://github.com/python/asyncio/pull/485/files
Reloadhttps://github.com/python/asyncio/pull/485/files
Reloadhttps://github.com/python/asyncio/pull/485/files
pythonhttps://github.com/python
asynciohttps://github.com/python/asyncio
Codehttps://github.com/python/asyncio
Issues76 (76)https://github.com/python/asyncio/issues
Pull requests10 (10)https://github.com/python/asyncio/pulls
Actionshttps://github.com/python/asyncio/actions
Projectshttps://github.com/python/asyncio/projects
Wikihttps://github.com/python/asyncio/wiki
Security and qualityhttps://github.com/python/asyncio/security
Insightshttps://github.com/python/asyncio/insights
sethmlarsonhttps://github.com/sethmlarson
python:masterhttps://github.com/python/asyncio/tree/master
Conversation 21 https://github.com/python/asyncio/pull/485
Commits 5 https://github.com/python/asyncio/pull/485/commits
Checks 0 https://github.com/python/asyncio/pull/485/checks
Files changed https://github.com/python/asyncio/pull/485/files
Please reload this pagehttps://github.com/python/asyncio/pull/485/files
Delay closing SubprocessStreamProtocol's Transport until all pipes are closed. https://github.com/python/asyncio/pull/485/files#top
Show all changes 5 commits https://github.com/python/asyncio/pull/485/files
c73df72 Delay SubprocessStreamProtocol closing transport SethMichaelLarson Jan 13, 2017 https://github.com/python/asyncio/pull/485/commits/c73df721994e2a1f996b2d8dcd969abeec3cca2f
12428a2 Add simple test for patch sethmlarson Jan 18, 2017 https://github.com/python/asyncio/pull/485/commits/12428a229888891c10b5441f1f28acd57cf7e0b6
33cd1c5 Remove comment about /dev/urandom SethMichaelLarson Feb 28, 2017 https://github.com/python/asyncio/pull/485/commits/33cd1c55507f4e7e9b7353494b2104b7995bd674
16a04d2 Allow _maybe_close_transport to close even if... SethMichaelLarson Mar 2, 2017 https://github.com/python/asyncio/pull/485/commits/16a04d2bdef89038fdd9b108eadf2822d731e226
dc23e3f Add flag for process_exited, separate this from... SethMichaelLarson Mar 2, 2017 https://github.com/python/asyncio/pull/485/commits/dc23e3fdb6e319022565902a8f1b03c283b01c36
Clear filters https://github.com/python/asyncio/pull/485/files
Please reload this pagehttps://github.com/python/asyncio/pull/485/files
Please reload this pagehttps://github.com/python/asyncio/pull/485/files
subprocess.py https://github.com/python/asyncio/pull/485/files#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf
test_subprocess.py https://github.com/python/asyncio/pull/485/files#diff-7e60be2cc399747c399c70e76689347d6dd20f349e08c323d2c9e595bb56f2c3
asyncio/subprocess.pyhttps://github.com/python/asyncio/pull/485/files#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf
View file https://github.com/python/asyncio/blob/dc23e3fdb6e319022565902a8f1b03c283b01c36/asyncio/subprocess.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/asyncio/pull/485/{{ revealButtonHref }}
https://github.com/python/asyncio/pull/485/files#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf
https://github.com/python/asyncio/pull/485/files#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf
https://github.com/python/asyncio/pull/485/files#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf
https://github.com/python/asyncio/pull/485/files#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf
https://github.com/python/asyncio/pull/485/files#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf
tests/test_subprocess.pyhttps://github.com/python/asyncio/pull/485/files#diff-7e60be2cc399747c399c70e76689347d6dd20f349e08c323d2c9e595bb56f2c3
View file https://github.com/python/asyncio/blob/dc23e3fdb6e319022565902a8f1b03c283b01c36/tests/test_subprocess.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/asyncio/pull/485/{{ revealButtonHref }}
https://github.com/python/asyncio/pull/485/files#diff-7e60be2cc399747c399c70e76689347d6dd20f349e08c323d2c9e595bb56f2c3
https://github.com/python/asyncio/pull/485/files#diff-7e60be2cc399747c399c70e76689347d6dd20f349e08c323d2c9e595bb56f2c3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.