| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a1dae549-79e1-1b7c-9dad-7ee571c8972e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BC34:15E5F9:250CD48:3285256:6B003A3F |
| html-safe-nonce | 6311d5a042f86d0aac5aebfbd2e6dcdfcfce6143eac4f8f09564c100acab5025 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzM0OjE1RTVGOToyNTBDRDQ4OjMyODUyNTY6NkIwMDNBM0YiLCJ2aXNpdG9yX2lkIjoiMzcwNDczMzA2NTM4NjU0MjcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 869e9871db9a506eb4fb5c2774c83018053d72963f718bc72b01525befa77572 |
| hovercard-subject-tag | pull_request:101521253 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/asyncio/pull/485/files |
| twitter:image | https://avatars.githubusercontent.com/u/18519037?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/18519037?s=400&v=4 |
| og:image:alt | I believe this change fixes #484.
Delays the closing for SubprocessStreamProtocol._transport until all pipes have been closed and the process has exited rather than just the process exiting. This a... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/asyncio git https://github.com/python/asyncio.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 33739295 |
| octolytics-dimension-repository_nwo | python/asyncio |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 33739295 |
| octolytics-dimension-repository_network_root_nwo | python/asyncio |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/asyncio/pull/485/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fasyncio%2Fpull%2F485%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fasyncio%2Fpull%2F485%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fasyncio |
| Reload | https://github.com/python/asyncio/pull/485/files |
| Reload | https://github.com/python/asyncio/pull/485/files |
| Reload | https://github.com/python/asyncio/pull/485/files |
| python | https://github.com/python |
| asyncio | https://github.com/python/asyncio |
| Code | https://github.com/python/asyncio |
| Issues76 (76) | https://github.com/python/asyncio/issues |
| Pull requests10 (10) | https://github.com/python/asyncio/pulls |
| Actions | https://github.com/python/asyncio/actions |
| Projects | https://github.com/python/asyncio/projects |
| Wiki | https://github.com/python/asyncio/wiki |
| Security and quality | https://github.com/python/asyncio/security |
| Insights | https://github.com/python/asyncio/insights |
| sethmlarson | https://github.com/sethmlarson |
| python:master | https://github.com/python/asyncio/tree/master |
|
Conversation
21
| https://github.com/python/asyncio/pull/485 |
|
Commits
5
| https://github.com/python/asyncio/pull/485/commits |
|
Checks
0
| https://github.com/python/asyncio/pull/485/checks |
|
Files changed
| https://github.com/python/asyncio/pull/485/files |
| Please reload this page | https://github.com/python/asyncio/pull/485/files |
|
Delay closing SubprocessStreamProtocol's Transport until all pipes are closed.
| https://github.com/python/asyncio/pull/485/files#top |
|
Show all changes
5 commits
| https://github.com/python/asyncio/pull/485/files |
|
c73df72
Delay SubprocessStreamProtocol closing transport
SethMichaelLarson Jan 13, 2017
| https://github.com/python/asyncio/pull/485/commits/c73df721994e2a1f996b2d8dcd969abeec3cca2f |
|
12428a2
Add simple test for patch
sethmlarson Jan 18, 2017
| https://github.com/python/asyncio/pull/485/commits/12428a229888891c10b5441f1f28acd57cf7e0b6 |
|
33cd1c5
Remove comment about /dev/urandom
SethMichaelLarson Feb 28, 2017
| https://github.com/python/asyncio/pull/485/commits/33cd1c55507f4e7e9b7353494b2104b7995bd674 |
|
16a04d2
Allow _maybe_close_transport to close even if...
SethMichaelLarson Mar 2, 2017
| https://github.com/python/asyncio/pull/485/commits/16a04d2bdef89038fdd9b108eadf2822d731e226 |
|
dc23e3f
Add flag for process_exited, separate this from...
SethMichaelLarson Mar 2, 2017
| https://github.com/python/asyncio/pull/485/commits/dc23e3fdb6e319022565902a8f1b03c283b01c36 |
|
Clear filters
| https://github.com/python/asyncio/pull/485/files |
| Please reload this page | https://github.com/python/asyncio/pull/485/files |
| Please reload this page | https://github.com/python/asyncio/pull/485/files |
|
subprocess.py
| https://github.com/python/asyncio/pull/485/files#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf |
|
test_subprocess.py
| https://github.com/python/asyncio/pull/485/files#diff-7e60be2cc399747c399c70e76689347d6dd20f349e08c323d2c9e595bb56f2c3 |
| asyncio/subprocess.py | https://github.com/python/asyncio/pull/485/files#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf |
|
View file
| https://github.com/python/asyncio/blob/dc23e3fdb6e319022565902a8f1b03c283b01c36/asyncio/subprocess.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/asyncio/pull/485/{{ revealButtonHref }} |
|
| https://github.com/python/asyncio/pull/485/files#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf |
|
| https://github.com/python/asyncio/pull/485/files#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf |
|
| https://github.com/python/asyncio/pull/485/files#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf |
|
| https://github.com/python/asyncio/pull/485/files#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf |
|
| https://github.com/python/asyncio/pull/485/files#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf |
| tests/test_subprocess.py | https://github.com/python/asyncio/pull/485/files#diff-7e60be2cc399747c399c70e76689347d6dd20f349e08c323d2c9e595bb56f2c3 |
|
View file
| https://github.com/python/asyncio/blob/dc23e3fdb6e319022565902a8f1b03c283b01c36/tests/test_subprocess.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/asyncio/pull/485/{{ revealButtonHref }} |
|
| https://github.com/python/asyncio/pull/485/files#diff-7e60be2cc399747c399c70e76689347d6dd20f349e08c323d2c9e595bb56f2c3 |
|
| https://github.com/python/asyncio/pull/485/files#diff-7e60be2cc399747c399c70e76689347d6dd20f349e08c323d2c9e595bb56f2c3 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |