René's URL Explorer Experiment


Title: Delay closing SubprocessStreamProtocol's Transport until all pipes are closed. by sethmlarson · Pull Request #485 · python/asyncio · GitHub

Open Graph Title: Delay closing SubprocessStreamProtocol's Transport until all pipes are closed. by sethmlarson · Pull Request #485 · python/asyncio

X Title: Delay closing SubprocessStreamProtocol's Transport until all pipes are closed. by sethmlarson · Pull Request #485 · python/asyncio

Description: asyncio historical repository. Contribute to python/asyncio development by creating an account on GitHub.

Open Graph Description: I believe this change fixes #484. Delays the closing for SubprocessStreamProtocol._transport until all pipes have been closed and the process has exited rather than just the process exiting. This a...

X Description: I believe this change fixes #484. Delays the closing for SubprocessStreamProtocol._transport until all pipes have been closed and the process has exited rather than just the process exiting. This a...

Opengraph URL: https://github.com/python/asyncio/pull/485

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:68b21872-3ca6-9d74-5f48-f6bfe6126807
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C58:1A2F85:53F85A:712C94:6B003107
html-safe-noncef9d03f8761aa7c8b3f67c090faf61ac06051d049f261f9528e6ac09b4888dc9e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzU4OjFBMkY4NTo1M0Y4NUE6NzEyQzk0OjZCMDAzMTA3IiwidmlzaXRvcl9pZCI6IjM3MjQwMTE0NTY2MTQ2NDE5MjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac84af991b5b75e98c37c8548d833e80e0c3b81684b8889718e222218160a21ea9
hovercard-subject-tagpull_request:101521253
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/asyncio/485/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8fb35b5f90733e10e9a795d9801063102daa368e4783c9fe7a19eb762031d878/python/asyncio/pull/485
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8fb35b5f90733e10e9a795d9801063102daa368e4783c9fe7a19eb762031d878/python/asyncio/pull/485
og:image:altI believe this change fixes #484. Delays the closing for SubprocessStreamProtocol._transport until all pipes have been closed and the process has exited rather than just the process exiting. This a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesethmlarson
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/asyncio git https://github.com/python/asyncio.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id33739295
octolytics-dimension-repository_nwopython/asyncio
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id33739295
octolytics-dimension-repository_network_root_nwopython/asyncio
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/asyncio/pull/485#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fasyncio%2Fpull%2F485
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fasyncio%2Fpull%2F485
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fasyncio
Reloadhttps://github.com/python/asyncio/pull/485
Reloadhttps://github.com/python/asyncio/pull/485
Reloadhttps://github.com/python/asyncio/pull/485
pythonhttps://github.com/python
asynciohttps://github.com/python/asyncio
Codehttps://github.com/python/asyncio
Issues76 (76)https://github.com/python/asyncio/issues
Pull requests10 (10)https://github.com/python/asyncio/pulls
Actionshttps://github.com/python/asyncio/actions
Projectshttps://github.com/python/asyncio/projects
Wikihttps://github.com/python/asyncio/wiki
Security and qualityhttps://github.com/python/asyncio/security
Insightshttps://github.com/python/asyncio/insights
https://github.com/python/asyncio
sethmlarsonhttps://github.com/sethmlarson
python:masterhttps://github.com/python/asyncio/tree/master
Conversationhttps://github.com/python/asyncio/pull/485
Commits5 (5)https://github.com/python/asyncio/pull/485/commits
Checkshttps://github.com/python/asyncio/pull/485/checks
Files changedhttps://github.com/python/asyncio/pull/485/files
Delay closing SubprocessStreamProtocol's Transport until all pipes are closed.https://github.com/python/asyncio/pull/485#top
sethmlarsonhttps://github.com/sethmlarson
python:masterhttps://github.com/python/asyncio/tree/master
https://github.com/sethmlarson
sethmlarsonhttps://github.com/sethmlarson
Jan 13, 2017https://github.com/python/asyncio/pull/485#issue-200736645
#484https://github.com/python/asyncio/issues/484
Please reload this pagehttps://github.com/python/asyncio/pull/485
https://github.com/SethMichaelLarson
Delay SubprocessStreamProtocol closing transporthttps://github.com/python/asyncio/pull/485/commits/c73df721994e2a1f996b2d8dcd969abeec3cca2f
c73df72https://github.com/python/asyncio/pull/485/commits/c73df721994e2a1f996b2d8dcd969abeec3cca2f
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/asyncio/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jan 13, 2017https://github.com/python/asyncio/pull/485#event-922865779
https://github.com/sethmlarson
sethmlarsonhttps://github.com/sethmlarson
Jan 13, 2017 https://github.com/python/asyncio/pull/485#ref-issue-200727755
subprocess._loop deleted too soon causing exception when trying to read from pipe #484 https://github.com/python/asyncio/issues/484
https://github.com/sethmlarson
sethmlarsonhttps://github.com/sethmlarson
Jan 18, 2017https://github.com/python/asyncio/pull/485#issuecomment-273503047
@Haypohttps://github.com/Haypo
Please reload this pagehttps://github.com/python/asyncio/pull/485
https://github.com/1st1
1st1https://github.com/1st1
Jan 18, 2017https://github.com/python/asyncio/pull/485#issuecomment-273510120
@asvetlovhttps://github.com/asvetlov
Please reload this pagehttps://github.com/python/asyncio/pull/485
https://github.com/sethmlarson
sethmlarsonhttps://github.com/sethmlarson
Jan 18, 2017https://github.com/python/asyncio/pull/485#issuecomment-273510818
@1st1https://github.com/1st1
Please reload this pagehttps://github.com/python/asyncio/pull/485
https://github.com/1st1
1st1https://github.com/1st1
Jan 18, 2017https://github.com/python/asyncio/pull/485#issuecomment-273520386
Please reload this pagehttps://github.com/python/asyncio/pull/485
https://github.com/sethmlarson
Add simple test for patchhttps://github.com/python/asyncio/pull/485/commits/12428a229888891c10b5441f1f28acd57cf7e0b6
12428a2https://github.com/python/asyncio/pull/485/commits/12428a229888891c10b5441f1f28acd57cf7e0b6
https://github.com/sethmlarson
sethmlarsonhttps://github.com/sethmlarson
Jan 18, 2017https://github.com/python/asyncio/pull/485#issuecomment-273524334
Please reload this pagehttps://github.com/python/asyncio/pull/485
Please reload this pagehttps://github.com/python/asyncio/pull/485
https://github.com/BotoX
BotoXhttps://github.com/BotoX
Feb 7, 2017https://github.com/python/asyncio/pull/485#issuecomment-278097370
#484https://github.com/python/asyncio/issues/484
Please reload this pagehttps://github.com/python/asyncio/pull/485
https://github.com/SethMichaelLarson
Remove comment about /dev/urandomhttps://github.com/python/asyncio/pull/485/commits/33cd1c55507f4e7e9b7353494b2104b7995bd674
33cd1c5https://github.com/python/asyncio/pull/485/commits/33cd1c55507f4e7e9b7353494b2104b7995bd674
https://github.com/1st1
1st1https://github.com/1st1
Mar 2, 2017 https://github.com/python/asyncio/pull/485#pullrequestreview-24852973
View reviewed changes https://github.com/python/asyncio/pull/485/files/33cd1c55507f4e7e9b7353494b2104b7995bd674
asyncio/subprocess.pyhttps://github.com/python/asyncio/pull/485/files/33cd1c55507f4e7e9b7353494b2104b7995bd674#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf
1st1https://github.com/1st1
Mar 2, 2017https://github.com/python/asyncio/pull/485#discussion_r104038882
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/asyncio/pull/485
sethmlarsonhttps://github.com/sethmlarson
Mar 2, 2017https://github.com/python/asyncio/pull/485#discussion_r104039450
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/asyncio/pull/485
https://github.com/SethMichaelLarson
Allow _maybe_close_transport to close even if...https://github.com/python/asyncio/pull/485/commits/16a04d2bdef89038fdd9b108eadf2822d731e226
16a04d2https://github.com/python/asyncio/pull/485/commits/16a04d2bdef89038fdd9b108eadf2822d731e226
https://github.com/1st1
1st1https://github.com/1st1
Mar 2, 2017 https://github.com/python/asyncio/pull/485#pullrequestreview-24854918
View reviewed changes https://github.com/python/asyncio/pull/485/files/16a04d2bdef89038fdd9b108eadf2822d731e226
asyncio/subprocess.pyhttps://github.com/python/asyncio/pull/485/files/16a04d2bdef89038fdd9b108eadf2822d731e226#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf
1st1https://github.com/1st1
Mar 2, 2017https://github.com/python/asyncio/pull/485#discussion_r104040674
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/asyncio/pull/485
sethmlarsonhttps://github.com/sethmlarson
Mar 2, 2017https://github.com/python/asyncio/pull/485#discussion_r104040828
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/asyncio/pull/485
sethmlarsonhttps://github.com/sethmlarson
Mar 2, 2017https://github.com/python/asyncio/pull/485#discussion_r104040955
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/asyncio/pull/485
1st1https://github.com/1st1
Mar 2, 2017https://github.com/python/asyncio/pull/485#discussion_r104041242
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/asyncio/pull/485
sethmlarsonhttps://github.com/sethmlarson
Mar 2, 2017https://github.com/python/asyncio/pull/485#discussion_r104041706
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/asyncio/pull/485
https://github.com/1st1
1st1https://github.com/1st1
Mar 2, 2017 https://github.com/python/asyncio/pull/485#pullrequestreview-24855198
View reviewed changes https://github.com/python/asyncio/pull/485/files/16a04d2bdef89038fdd9b108eadf2822d731e226
asyncio/subprocess.pyhttps://github.com/python/asyncio/pull/485/files/16a04d2bdef89038fdd9b108eadf2822d731e226#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf
1st1https://github.com/1st1
Mar 2, 2017https://github.com/python/asyncio/pull/485#discussion_r104040914
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/asyncio/pull/485
sethmlarsonhttps://github.com/sethmlarson
Mar 2, 2017https://github.com/python/asyncio/pull/485#discussion_r104041237
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/asyncio/pull/485
1st1https://github.com/1st1
Mar 2, 2017https://github.com/python/asyncio/pull/485#discussion_r104041294
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/asyncio/pull/485
sethmlarsonhttps://github.com/sethmlarson
Mar 2, 2017https://github.com/python/asyncio/pull/485#discussion_r104041770
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/asyncio/pull/485
https://github.com/SethMichaelLarson
Add flag for process_exited, separate this from...https://github.com/python/asyncio/pull/485/commits/dc23e3fdb6e319022565902a8f1b03c283b01c36
dc23e3fhttps://github.com/python/asyncio/pull/485/commits/dc23e3fdb6e319022565902a8f1b03c283b01c36
https://github.com/1st1
1st1https://github.com/1st1
Mar 2, 2017https://github.com/python/asyncio/pull/485#issuecomment-283798546
http://github.com/python/cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/asyncio/pull/485
https://github.com/sethmlarson
sethmlarsonhttps://github.com/sethmlarson
Mar 2, 2017https://github.com/python/asyncio/pull/485#issuecomment-283798620
Please reload this pagehttps://github.com/python/asyncio/pull/485
https://github.com/sethmlarson
sethmlarsonhttps://github.com/sethmlarson
Mar 2, 2017https://github.com/python/asyncio/pull/485#issuecomment-283798819
Please reload this pagehttps://github.com/python/asyncio/pull/485
@1st1https://github.com/1st1
Please reload this pagehttps://github.com/python/asyncio/pull/485
https://github.com/sethmlarson
sethmlarsonhttps://github.com/sethmlarson
Mar 2, 2017 https://github.com/python/asyncio/pull/485#ref-pullrequest-211535686
bpo-29704: Fix asyncio.SubprocessStreamProtocol closing python/cpython#405 https://github.com/python/cpython/pull/405
https://github.com/1st1
1st1https://github.com/1st1
Mar 2, 2017https://github.com/python/asyncio/pull/485#issuecomment-283800777
Please reload this pagehttps://github.com/python/asyncio/pull/485
https://github.com/1st1
1st1https://github.com/1st1
Mar 2, 2017https://github.com/python/asyncio/pull/485#event-984505203
https://github.com/sethmlarson
sethmlarsonhttps://github.com/sethmlarson
March 2, 2017 22:25https://github.com/python/asyncio/pull/485#event-984515479
https://github.co/hiddenchars
https://github.com/python/asyncio/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fasyncio%2Fpull%2F485
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/python/asyncio/pull/485/files/16a04d2bdef89038fdd9b108eadf2822d731e226
Please reload this pagehttps://github.com/python/asyncio/pull/485
CLA signed https://github.com/python/asyncio/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Please reload this pagehttps://github.com/python/asyncio/pull/485
https://github.com/sethmlarson
https://github.com/1st1
https://github.com/BotoX
https://github.com/the-knights-who-say-ni
https://github.com/SethMichaelLarson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.