| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:68b21872-3ca6-9d74-5f48-f6bfe6126807 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8C58:1A2F85:53F85A:712C94:6B003107 |
| html-safe-nonce | f9d03f8761aa7c8b3f67c090faf61ac06051d049f261f9528e6ac09b4888dc9e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzU4OjFBMkY4NTo1M0Y4NUE6NzEyQzk0OjZCMDAzMTA3IiwidmlzaXRvcl9pZCI6IjM3MjQwMTE0NTY2MTQ2NDE5MjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 84af991b5b75e98c37c8548d833e80e0c3b81684b8889718e222218160a21ea9 |
| hovercard-subject-tag | pull_request:101521253 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/asyncio/485/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8fb35b5f90733e10e9a795d9801063102daa368e4783c9fe7a19eb762031d878/python/asyncio/pull/485 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8fb35b5f90733e10e9a795d9801063102daa368e4783c9fe7a19eb762031d878/python/asyncio/pull/485 |
| og:image:alt | I believe this change fixes #484.
Delays the closing for SubprocessStreamProtocol._transport until all pipes have been closed and the process has exited rather than just the process exiting. This a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sethmlarson |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/asyncio git https://github.com/python/asyncio.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 33739295 |
| octolytics-dimension-repository_nwo | python/asyncio |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 33739295 |
| octolytics-dimension-repository_network_root_nwo | python/asyncio |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/asyncio/pull/485#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fasyncio%2Fpull%2F485 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fasyncio%2Fpull%2F485 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fasyncio |
| Reload | https://github.com/python/asyncio/pull/485 |
| Reload | https://github.com/python/asyncio/pull/485 |
| Reload | https://github.com/python/asyncio/pull/485 |
| python | https://github.com/python |
| asyncio | https://github.com/python/asyncio |
| Code | https://github.com/python/asyncio |
| Issues76 (76) | https://github.com/python/asyncio/issues |
| Pull requests10 (10) | https://github.com/python/asyncio/pulls |
| Actions | https://github.com/python/asyncio/actions |
| Projects | https://github.com/python/asyncio/projects |
| Wiki | https://github.com/python/asyncio/wiki |
| Security and quality | https://github.com/python/asyncio/security |
| Insights | https://github.com/python/asyncio/insights |
| https://github.com/python/asyncio |
| sethmlarson | https://github.com/sethmlarson |
| python:master | https://github.com/python/asyncio/tree/master |
| Conversation | https://github.com/python/asyncio/pull/485 |
| Commits5 (5) | https://github.com/python/asyncio/pull/485/commits |
| Checks | https://github.com/python/asyncio/pull/485/checks |
| Files changed | https://github.com/python/asyncio/pull/485/files |
| Delay closing SubprocessStreamProtocol's Transport until all pipes are closed. | https://github.com/python/asyncio/pull/485#top |
| sethmlarson | https://github.com/sethmlarson |
| python:master | https://github.com/python/asyncio/tree/master |
|
| https://github.com/sethmlarson |
| sethmlarson | https://github.com/sethmlarson |
| Jan 13, 2017 | https://github.com/python/asyncio/pull/485#issue-200736645 |
| #484 | https://github.com/python/asyncio/issues/484 |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
|
| https://github.com/SethMichaelLarson |
| Delay SubprocessStreamProtocol closing transport | https://github.com/python/asyncio/pull/485/commits/c73df721994e2a1f996b2d8dcd969abeec3cca2f |
| c73df72 | https://github.com/python/asyncio/pull/485/commits/c73df721994e2a1f996b2d8dcd969abeec3cca2f |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/asyncio/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Jan 13, 2017 | https://github.com/python/asyncio/pull/485#event-922865779 |
| https://github.com/sethmlarson |
| sethmlarson | https://github.com/sethmlarson |
|
Jan 13, 2017
| https://github.com/python/asyncio/pull/485#ref-issue-200727755 |
|
subprocess._loop deleted too soon causing exception when trying to read from pipe
#484
| https://github.com/python/asyncio/issues/484 |
| https://github.com/sethmlarson |
| sethmlarson | https://github.com/sethmlarson |
| Jan 18, 2017 | https://github.com/python/asyncio/pull/485#issuecomment-273503047 |
| @Haypo | https://github.com/Haypo |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| Jan 18, 2017 | https://github.com/python/asyncio/pull/485#issuecomment-273510120 |
| @asvetlov | https://github.com/asvetlov |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| https://github.com/sethmlarson |
| sethmlarson | https://github.com/sethmlarson |
| Jan 18, 2017 | https://github.com/python/asyncio/pull/485#issuecomment-273510818 |
| @1st1 | https://github.com/1st1 |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| Jan 18, 2017 | https://github.com/python/asyncio/pull/485#issuecomment-273520386 |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
|
| https://github.com/sethmlarson |
| Add simple test for patch | https://github.com/python/asyncio/pull/485/commits/12428a229888891c10b5441f1f28acd57cf7e0b6 |
| 12428a2 | https://github.com/python/asyncio/pull/485/commits/12428a229888891c10b5441f1f28acd57cf7e0b6 |
| https://github.com/sethmlarson |
| sethmlarson | https://github.com/sethmlarson |
| Jan 18, 2017 | https://github.com/python/asyncio/pull/485#issuecomment-273524334 |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| https://github.com/BotoX |
| BotoX | https://github.com/BotoX |
| Feb 7, 2017 | https://github.com/python/asyncio/pull/485#issuecomment-278097370 |
| #484 | https://github.com/python/asyncio/issues/484 |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
|
| https://github.com/SethMichaelLarson |
| Remove comment about /dev/urandom | https://github.com/python/asyncio/pull/485/commits/33cd1c55507f4e7e9b7353494b2104b7995bd674 |
| 33cd1c5 | https://github.com/python/asyncio/pull/485/commits/33cd1c55507f4e7e9b7353494b2104b7995bd674 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
|
Mar 2, 2017
| https://github.com/python/asyncio/pull/485#pullrequestreview-24852973 |
|
View reviewed changes
| https://github.com/python/asyncio/pull/485/files/33cd1c55507f4e7e9b7353494b2104b7995bd674 |
| asyncio/subprocess.py | https://github.com/python/asyncio/pull/485/files/33cd1c55507f4e7e9b7353494b2104b7995bd674#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf |
| 1st1 | https://github.com/1st1 |
| Mar 2, 2017 | https://github.com/python/asyncio/pull/485#discussion_r104038882 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| sethmlarson | https://github.com/sethmlarson |
| Mar 2, 2017 | https://github.com/python/asyncio/pull/485#discussion_r104039450 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
|
| https://github.com/SethMichaelLarson |
| Allow _maybe_close_transport to close even if... | https://github.com/python/asyncio/pull/485/commits/16a04d2bdef89038fdd9b108eadf2822d731e226 |
| 16a04d2 | https://github.com/python/asyncio/pull/485/commits/16a04d2bdef89038fdd9b108eadf2822d731e226 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
|
Mar 2, 2017
| https://github.com/python/asyncio/pull/485#pullrequestreview-24854918 |
|
View reviewed changes
| https://github.com/python/asyncio/pull/485/files/16a04d2bdef89038fdd9b108eadf2822d731e226 |
| asyncio/subprocess.py | https://github.com/python/asyncio/pull/485/files/16a04d2bdef89038fdd9b108eadf2822d731e226#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf |
| 1st1 | https://github.com/1st1 |
| Mar 2, 2017 | https://github.com/python/asyncio/pull/485#discussion_r104040674 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| sethmlarson | https://github.com/sethmlarson |
| Mar 2, 2017 | https://github.com/python/asyncio/pull/485#discussion_r104040828 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| sethmlarson | https://github.com/sethmlarson |
| Mar 2, 2017 | https://github.com/python/asyncio/pull/485#discussion_r104040955 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| 1st1 | https://github.com/1st1 |
| Mar 2, 2017 | https://github.com/python/asyncio/pull/485#discussion_r104041242 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| sethmlarson | https://github.com/sethmlarson |
| Mar 2, 2017 | https://github.com/python/asyncio/pull/485#discussion_r104041706 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
|
Mar 2, 2017
| https://github.com/python/asyncio/pull/485#pullrequestreview-24855198 |
|
View reviewed changes
| https://github.com/python/asyncio/pull/485/files/16a04d2bdef89038fdd9b108eadf2822d731e226 |
| asyncio/subprocess.py | https://github.com/python/asyncio/pull/485/files/16a04d2bdef89038fdd9b108eadf2822d731e226#diff-17d5886068b614ff3223db663238aa68ed0172c8b9efe64ee31e04d8e25d2ecf |
| 1st1 | https://github.com/1st1 |
| Mar 2, 2017 | https://github.com/python/asyncio/pull/485#discussion_r104040914 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| sethmlarson | https://github.com/sethmlarson |
| Mar 2, 2017 | https://github.com/python/asyncio/pull/485#discussion_r104041237 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| 1st1 | https://github.com/1st1 |
| Mar 2, 2017 | https://github.com/python/asyncio/pull/485#discussion_r104041294 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| sethmlarson | https://github.com/sethmlarson |
| Mar 2, 2017 | https://github.com/python/asyncio/pull/485#discussion_r104041770 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
|
| https://github.com/SethMichaelLarson |
| Add flag for process_exited, separate this from... | https://github.com/python/asyncio/pull/485/commits/dc23e3fdb6e319022565902a8f1b03c283b01c36 |
| dc23e3f | https://github.com/python/asyncio/pull/485/commits/dc23e3fdb6e319022565902a8f1b03c283b01c36 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| Mar 2, 2017 | https://github.com/python/asyncio/pull/485#issuecomment-283798546 |
| http://github.com/python/cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| https://github.com/sethmlarson |
| sethmlarson | https://github.com/sethmlarson |
| Mar 2, 2017 | https://github.com/python/asyncio/pull/485#issuecomment-283798620 |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| https://github.com/sethmlarson |
| sethmlarson | https://github.com/sethmlarson |
| Mar 2, 2017 | https://github.com/python/asyncio/pull/485#issuecomment-283798819 |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| @1st1 | https://github.com/1st1 |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| https://github.com/sethmlarson |
| sethmlarson | https://github.com/sethmlarson |
|
Mar 2, 2017
| https://github.com/python/asyncio/pull/485#ref-pullrequest-211535686 |
|
bpo-29704: Fix asyncio.SubprocessStreamProtocol closing
python/cpython#405
| https://github.com/python/cpython/pull/405 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| Mar 2, 2017 | https://github.com/python/asyncio/pull/485#issuecomment-283800777 |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| Mar 2, 2017 | https://github.com/python/asyncio/pull/485#event-984505203 |
| https://github.com/sethmlarson |
| sethmlarson | https://github.com/sethmlarson |
| March 2, 2017 22:25 | https://github.com/python/asyncio/pull/485#event-984515479 |
| https://github.co/hiddenchars |
| https://github.com/python/asyncio/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fasyncio%2Fpull%2F485 |
|
| https://github.com/1st1 |
|
1st1
| https://github.com/1st1 |
|
| https://github.com/python/asyncio/pull/485/files/16a04d2bdef89038fdd9b108eadf2822d731e226 |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
|
CLA signed
| https://github.com/python/asyncio/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Please reload this page | https://github.com/python/asyncio/pull/485 |
|
| https://github.com/sethmlarson |
|
| https://github.com/1st1 |
|
| https://github.com/BotoX |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com/SethMichaelLarson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |