| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e9f1c5af-17cf-6d4d-1637-822e6862ef13 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 90EA:144C84:8DE09E:C72AB8:696A225E |
| html-safe-nonce | f7a099abf286e9d59f7158d951e00014a1f34a02a52142ba07a7387407681621 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEVBOjE0NEM4NDo4REUwOUU6QzcyQUI4OjY5NkEyMjVFIiwidmlzaXRvcl9pZCI6IjU1ODEzNzM3NjE3MTAwNzI0MTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | cf352a10588ec0e918dadb2f209f64451a1736b1256ec9e6baa400229f4f5984 |
| hovercard-subject-tag | pull_request:86753853 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/asyncio/428/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/890b663f62895a30db4cc67e794adace6971533653ab4637b1a4b0fa96e53e2f/python/asyncio/pull/428 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/890b663f62895a30db4cc67e794adace6971533653ab4637b1a4b0fa96e53e2f/python/asyncio/pull/428 |
| og:image:alt | Dear all,
Following the bug #414, here is a patch which makes the fork + exec operation non blocking on Unix.
The patch is probably not ready to land, but I believe it's in pretty good shape.
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Martiusweb |
| hostname | github.com |
| expected-hostname | github.com |
| None | 014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/asyncio git https://github.com/python/asyncio.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 33739295 |
| octolytics-dimension-repository_nwo | python/asyncio |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 33739295 |
| octolytics-dimension-repository_network_root_nwo | python/asyncio |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d515f6f09fa57a93bf90355cb894eb84ca4f458f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/asyncio/pull/428#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fasyncio%2Fpull%2F428 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fasyncio%2Fpull%2F428 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fasyncio |
| Reload | https://github.com/python/asyncio/pull/428 |
| Reload | https://github.com/python/asyncio/pull/428 |
| Reload | https://github.com/python/asyncio/pull/428 |
|
python
| https://github.com/python |
| asyncio | https://github.com/python/asyncio |
| Please reload this page | https://github.com/python/asyncio/pull/428 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fasyncio |
|
Fork
185
| https://github.com/login?return_to=%2Fpython%2Fasyncio |
|
Star
1.1k
| https://github.com/login?return_to=%2Fpython%2Fasyncio |
|
Code
| https://github.com/python/asyncio |
|
Issues
76
| https://github.com/python/asyncio/issues |
|
Pull requests
10
| https://github.com/python/asyncio/pulls |
|
Actions
| https://github.com/python/asyncio/actions |
|
Projects
0
| https://github.com/python/asyncio/projects |
|
Wiki
| https://github.com/python/asyncio/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/asyncio/security |
| Please reload this page | https://github.com/python/asyncio/pull/428 |
|
Insights
| https://github.com/python/asyncio/pulse |
|
Code
| https://github.com/python/asyncio |
|
Issues
| https://github.com/python/asyncio/issues |
|
Pull requests
| https://github.com/python/asyncio/pulls |
|
Actions
| https://github.com/python/asyncio/actions |
|
Projects
| https://github.com/python/asyncio/projects |
|
Wiki
| https://github.com/python/asyncio/wiki |
|
Security
| https://github.com/python/asyncio/security |
|
Insights
| https://github.com/python/asyncio/pulse |
| Martiusweb | https://github.com/Martiusweb |
| python:master | https://github.com/python/asyncio/tree/master |
| Martiusweb:non_blocking_popen | https://github.com/Martiusweb/asyncio/tree/non_blocking_popen |
|
make fork + exec non blocking on unix
| https://github.com/python/asyncio/pull/428#top |
| Martiusweb | https://github.com/Martiusweb |
| python:master | https://github.com/python/asyncio/tree/master |
| Martiusweb:non_blocking_popen | https://github.com/Martiusweb/asyncio/tree/non_blocking_popen |
|
Conversation
9
| https://github.com/python/asyncio/pull/428 |
|
Commits
7
| https://github.com/python/asyncio/pull/428/commits |
|
Checks
0
| https://github.com/python/asyncio/pull/428/checks |
|
Files changed
| https://github.com/python/asyncio/pull/428/files |
| Please reload this page | https://github.com/python/asyncio/pull/428 |
| https://github.co/hiddenchars |
| https://github.com/python/asyncio/pull/{{ revealButtonHref }} |
|
| https://github.com/Martiusweb |
| Martiusweb | https://github.com/Martiusweb |
| Sep 26, 2016 | https://github.com/python/asyncio/pull/428#issue-179245373 |
| #414 | https://github.com/python/asyncio/issues/414 |
| Please reload this page | https://github.com/python/asyncio/pull/428 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Sep 26, 2016 | https://github.com/python/asyncio/pull/428#issuecomment-249608514 |
| @gpshead | https://github.com/gpshead |
| Please reload this page | https://github.com/python/asyncio/pull/428 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Sep 26, 2016 | https://github.com/python/asyncio/pull/428#issuecomment-249611908 |
| @Martiusweb | https://github.com/Martiusweb |
| Please reload this page | https://github.com/python/asyncio/pull/428 |
| https://github.com/1st1 |
| 1st1 | https://github.com/1st1 |
| Sep 26, 2016 | https://github.com/python/asyncio/pull/428#issuecomment-249612608 |
| @gvanrossum | https://github.com/gvanrossum |
| Please reload this page | https://github.com/python/asyncio/pull/428 |
| https://github.com/Martiusweb |
| Martiusweb | https://github.com/Martiusweb |
| Sep 27, 2016 | https://github.com/python/asyncio/pull/428#issuecomment-249883170 |
| http://bugs.python.org/issue28287 | http://bugs.python.org/issue28287 |
| Please reload this page | https://github.com/python/asyncio/pull/428 |
| Martiusweb | https://github.com/Martiusweb |
| November 8, 2016 17:50 | https://github.com/python/asyncio/pull/428#commits-pushed-8fef3fe |
|
| https://github.com/Martiusweb |
| make fork + exec non blocking on unix | https://github.com/python/asyncio/pull/428/commits/8fef3fe7317390a3b1f61dfebaff541e23811633 |
| 8fef3fe | https://github.com/python/asyncio/pull/428/commits/8fef3fe7317390a3b1f61dfebaff541e23811633 |
|
| https://github.com/Martiusweb |
| compatibility with Python 3.3 | https://github.com/python/asyncio/pull/428/commits/6aa4e300b0d45a8cbf38ffa96aa473fddd580ebb |
| 6aa4e30 | https://github.com/python/asyncio/pull/428/commits/6aa4e300b0d45a8cbf38ffa96aa473fddd580ebb |
|
| https://github.com/Martiusweb |
| preexec_fn not supported on windows | https://github.com/python/asyncio/pull/428/commits/71cf40645e41d83e89261df70197f2ed39945d03 |
| 71cf406 | https://github.com/python/asyncio/pull/428/commits/71cf40645e41d83e89261df70197f2ed39945d03 |
|
| https://github.com/Martiusweb |
| handle asynchronous exceptions when creating SubprocessTransport | https://github.com/python/asyncio/pull/428/commits/a77c0ffe1a41e6fe076aaa87ea299a20ec80f8b5 |
| a77c0ff | https://github.com/python/asyncio/pull/428/commits/a77c0ffe1a41e6fe076aaa87ea299a20ec80f8b5 |
|
| https://github.com/Martiusweb |
| errpipe_read must be non-blocking | https://github.com/python/asyncio/pull/428/commits/0cf2e73a93c9d0b99698ae2fcceaad9fdf9e4bae |
| 0cf2e73 | https://github.com/python/asyncio/pull/428/commits/0cf2e73a93c9d0b99698ae2fcceaad9fdf9e4bae |
|
| https://github.com/Martiusweb |
| make asyncio backward compatible with older Popen | https://github.com/python/asyncio/pull/428/commits/ef41fc838a00ce182f58bd36b487e2fa7039d4ce |
| ef41fc8 | https://github.com/python/asyncio/pull/428/commits/ef41fc838a00ce182f58bd36b487e2fa7039d4ce |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
| Nov 9, 2016 | https://github.com/python/asyncio/pull/428#issuecomment-259385842 |
| bugs.python.org | http://bugs.python.org/ |
| create one | http://bugs.python.org/user?@template=register |
| PSF contributor agreement | https://www.python.org/psf/contrib/contrib-form/ |
| Please reload this page | https://github.com/python/asyncio/pull/428 |
| https://github.com/Martiusweb |
| Martiusweb | https://github.com/Martiusweb |
| force-pushed | https://github.com/python/asyncio/compare/875b00e50f403ad9d34b3c38ec4e22829c6d6859..ef41fc838a00ce182f58bd36b487e2fa7039d4ce |
| 875b00e | https://github.com/python/asyncio/commit/875b00e50f403ad9d34b3c38ec4e22829c6d6859 |
| ef41fc8 | https://github.com/python/asyncio/commit/ef41fc838a00ce182f58bd36b487e2fa7039d4ce |
|
Compare
| https://github.com/python/asyncio/compare/875b00e50f403ad9d34b3c38ec4e22829c6d6859..ef41fc838a00ce182f58bd36b487e2fa7039d4ce |
| November 9, 2016 10:48 | https://github.com/python/asyncio/pull/428#event-852799947 |
|
| https://github.com/Martiusweb |
| drop the mockey-patch of Popen in python 3.3 | https://github.com/python/asyncio/pull/428/commits/b3a81e057ae161e67189e4768c62725593fee8cb |
| b3a81e0 | https://github.com/python/asyncio/pull/428/commits/b3a81e057ae161e67189e4768c62725593fee8cb |
| https://github.com/Martiusweb |
| Martiusweb | https://github.com/Martiusweb |
| Nov 9, 2016 | https://github.com/python/asyncio/pull/428#issuecomment-259388206 |
| Please reload this page | https://github.com/python/asyncio/pull/428 |
| @the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
| Please reload this page | https://github.com/python/asyncio/pull/428 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Nov 9, 2016 | https://github.com/python/asyncio/pull/428#issuecomment-259455510 |
| Please reload this page | https://github.com/python/asyncio/pull/428 |
| https://github.com/Martiusweb |
| Martiusweb | https://github.com/Martiusweb |
| Nov 9, 2016 | https://github.com/python/asyncio/pull/428#issuecomment-259456405 |
| http://bugs.python.org/issue28287 | http://bugs.python.org/issue28287 |
| Please reload this page | https://github.com/python/asyncio/pull/428 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Nov 9, 2016 | https://github.com/python/asyncio/pull/428#issuecomment-259469928 |
| Please reload this page | https://github.com/python/asyncio/pull/428 |
| https://github.com/brettcannon |
| brettcannon | https://github.com/brettcannon |
|
CLA not signed
| https://github.com/python/asyncio/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22 |
|
CLA not signed
| https://github.com/python/asyncio/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22 |
| Nov 18, 2016 | https://github.com/python/asyncio/pull/428#event-863715654 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/asyncio/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Nov 18, 2016 | https://github.com/python/asyncio/pull/428#event-863715745 |
| https://github.com/soonum |
| soonum | https://github.com/soonum |
|
Nov 27, 2017
| https://github.com/python/asyncio/pull/428#ref-issue-277036054 |
|
Blocking loop.subprocess_shell() and loop.subprocess_exec()
MagicStack/uvloop#118
| https://github.com/MagicStack/uvloop/issues/118 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fasyncio%2Fpull%2F428 |
|
CLA signed
| https://github.com/python/asyncio/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Please reload this page | https://github.com/python/asyncio/pull/428 |
|
| https://github.com/Martiusweb |
|
| https://github.com/gvanrossum |
|
| https://github.com/1st1 |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com/brettcannon |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |