| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9e3ce02e-a0c6-e0d2-8278-6a71fcf255cd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D6DE:2C34B4:535F7:6F76A:6AFBD8E0 |
| html-safe-nonce | 62547e82d3702342c79c9317a24ae8905597861f9275ef341be579a5004703b4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENkRFOjJDMzRCNDo1MzVGNzo2Rjc2QTo2QUZCRDhFMCIsInZpc2l0b3JfaWQiOiIxNzkxODcxNzkwODg5MDMxOTA0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 18135fd7c5088828c943234b09cb9fa681290e0ebb0339b948f19577ae6d056e |
| hovercard-subject-tag | pull_request:923549713 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/purescript-node/purescript-node-streams/43/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9745645d0003b84d4542b79a2c983415570a66c02b8be8422343ac147c1fcdca/purescript-node/purescript-node-streams/pull/43 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9745645d0003b84d4542b79a2c983415570a66c02b8be8422343ac147c1fcdca/purescript-node/purescript-node-streams/pull/43 |
| og:image:alt | Description of the change
Properly fixes #35
Checklist:
Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)&quo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JordanMartinez |
| hostname | github.com |
| expected-hostname | github.com |
| None | 18742cb872ec73544356e60359266b67aafece70c4ce008042e06227924cdd07 |
| turbo-cache-control | no-cache |
| go-import | github.com/purescript-node/purescript-node-streams git https://github.com/purescript-node/purescript-node-streams.git |
| octolytics-dimension-user_id | 12017641 |
| octolytics-dimension-user_login | purescript-node |
| octolytics-dimension-repository_id | 43015461 |
| octolytics-dimension-repository_nwo | purescript-node/purescript-node-streams |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 43015461 |
| octolytics-dimension-repository_network_root_nwo | purescript-node/purescript-node-streams |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 820be804f18e1ef3940bd74a00d41d73d02e2b91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/purescript-node/purescript-node-streams/pull/43#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-node%2Fpurescript-node-streams%2Fpull%2F43 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-node%2Fpurescript-node-streams%2Fpull%2F43 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=purescript-node%2Fpurescript-node-streams |
| Reload | https://github.com/purescript-node/purescript-node-streams/pull/43 |
| Reload | https://github.com/purescript-node/purescript-node-streams/pull/43 |
| Reload | https://github.com/purescript-node/purescript-node-streams/pull/43 |
| purescript-node | https://github.com/purescript-node |
| purescript-node-streams | https://github.com/purescript-node/purescript-node-streams |
| Code | https://github.com/purescript-node/purescript-node-streams |
| Issues1 (1) | https://github.com/purescript-node/purescript-node-streams/issues |
| Pull requests | https://github.com/purescript-node/purescript-node-streams/pulls |
| Actions | https://github.com/purescript-node/purescript-node-streams/actions |
| Security and quality | https://github.com/purescript-node/purescript-node-streams/security |
| Insights | https://github.com/purescript-node/purescript-node-streams/pulse |
| https://github.com/purescript-node/purescript-node-streams |
| JordanMartinez | https://github.com/JordanMartinez |
| purescript-node:master | https://github.com/purescript-node/purescript-node-streams/tree/master |
| Conversation | https://github.com/purescript-node/purescript-node-streams/pull/43 |
| Commits10 (10) | https://github.com/purescript-node/purescript-node-streams/pull/43/commits |
| Checks | https://github.com/purescript-node/purescript-node-streams/pull/43/checks |
| Files changed | https://github.com/purescript-node/purescript-node-streams/pull/43/files |
| Fix write/end FFI type signatures; export destroyWithError; prep v7.0.0 release | https://github.com/purescript-node/purescript-node-streams/pull/43#top |
| JordanMartinez | https://github.com/JordanMartinez |
| purescript-node:master | https://github.com/purescript-node/purescript-node-streams/tree/master |
|
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Apr 29, 2022 | https://github.com/purescript-node/purescript-node-streams/pull/43#issue-1220567771 |
| #35 | https://github.com/purescript-node/purescript-node-streams/issues/35 |
| Please reload this page | https://github.com/purescript-node/purescript-node-streams/pull/43 |
| JordanMartinez | https://github.com/JordanMartinez |
| April 29, 2022 06:02 | https://github.com/purescript-node/purescript-node-streams/pull/43#commits-pushed-1158f22 |
|
| https://github.com/JordanMartinez |
| Install nullable | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/1158f22a3596df46a5baaafc8a69e9d07f0457ea |
| 1158f22 | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/1158f22a3596df46a5baaafc8a69e9d07f0457ea |
|
| https://github.com/JordanMartinez |
| Update write/writeString/end to take Maybe Error arg | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/15409e19d9cb6db83bf5495987dfa2f4ccaf0d1f |
| 15409e1 | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/15409e19d9cb6db83bf5495987dfa2f4ccaf0d1f |
|
| https://github.com/JordanMartinez |
| Add tests | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/03253667c8f6a31ffac5dfec206a00f77ff1b9c7 |
| 0325366 | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/03253667c8f6a31ffac5dfec206a00f77ff1b9c7 |
|
| https://github.com/JordanMartinez |
| Update changelog | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/d295bc3334efec44336e3aaec73f12522c8eea66 |
| d295bc3 | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/d295bc3334efec44336e3aaec73f12522c8eea66 |
|
| https://github.com/JordanMartinez |
| Tweak tests | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/066e280ea6147fbf08c9e3285d86c13fd6b97347 |
| 066e280 | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/066e280ea6147fbf08c9e3285d86c13fd6b97347 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Apr 29, 2022 | https://github.com/purescript-node/purescript-node-streams/pull/43#issuecomment-1113255821 |
| @garyb | https://github.com/garyb |
| Please reload this page | https://github.com/purescript-node/purescript-node-streams/pull/43 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Apr 29, 2022 | https://github.com/purescript-node/purescript-node-streams/pull/43#event-6522885626 |
| JordanMartinez | https://github.com/JordanMartinez |
| April 29, 2022 07:42 | https://github.com/purescript-node/purescript-node-streams/pull/43#commits-pushed-b127c61 |
|
| https://github.com/JordanMartinez |
| Bump Node to 16 | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/b127c614cf3bd5f5f88f0537704ffa39c92b0f9f |
| b127c61 | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/b127c614cf3bd5f5f88f0537704ffa39c92b0f9f |
|
| https://github.com/JordanMartinez |
| Revert "Bump Node to 16" | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/d80bd8e289e700c48f00f61febd187f25ada5fab |
| d80bd8e | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/d80bd8e289e700c48f00f61febd187f25ada5fab |
| b127c61 | https://github.com/purescript-node/purescript-node-streams/commit/b127c614cf3bd5f5f88f0537704ffa39c92b0f9f |
|
| https://github.com/JordanMartinez |
| Export destroyWithError | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/6d230a1941cbd5e1e86165237fc1dc3d5ce75148 |
| 6d230a1 | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/6d230a1941cbd5e1e86165237fc1dc3d5ce75148 |
|
| https://github.com/JordanMartinez |
| Update test to use destroyWithError | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/d0648b8d1d4f6293cc86215bdb631c8bb58486ce |
| d0648b8 | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/d0648b8d1d4f6293cc86215bdb631c8bb58486ce |
|
| https://github.com/JordanMartinez |
| Add entry for destroyWithError change | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/ece11ff7dfc86f96824402a82b6784695bc38830 |
| ece11ff | https://github.com/purescript-node/purescript-node-streams/pull/43/commits/ece11ff7dfc86f96824402a82b6784695bc38830 |
| https://github.com/garyb |
| garyb | https://github.com/garyb |
| Apr 29, 2022 | https://github.com/purescript-node/purescript-node-streams/pull/43#issuecomment-1113290701 |
| Please reload this page | https://github.com/purescript-node/purescript-node-streams/pull/43 |
| https://github.com/garyb |
| garyb | https://github.com/garyb |
|
Apr 29, 2022
| https://github.com/purescript-node/purescript-node-streams/pull/43#pullrequestreview-957707078 |
|
View reviewed changes
| https://github.com/purescript-node/purescript-node-streams/pull/43/files/ece11ff7dfc86f96824402a82b6784695bc38830 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| 8395652 | https://github.com/purescript-node/purescript-node-streams/commit/8395652f9f347101fe042f58726edc592ae5086c |
| Apr 29, 2022 | https://github.com/purescript-node/purescript-node-streams/pull/43#event-6523170650 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Apr 29, 2022 | https://github.com/purescript-node/purescript-node-streams/pull/43#event-6523172565 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| April 29, 2022 13:09 | https://github.com/purescript-node/purescript-node-streams/pull/43#event-6523173129 |
| https://github.co/hiddenchars |
| https://github.com/purescript-node/purescript-node-streams/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-node%2Fpurescript-node-streams%2Fpull%2F43 |
|
| https://github.com/garyb |
|
garyb
| https://github.com/garyb |
|
| https://github.com/purescript-node/purescript-node-streams/pull/43/files/ece11ff7dfc86f96824402a82b6784695bc38830 |
| Please reload this page | https://github.com/purescript-node/purescript-node-streams/pull/43 |
|
Stream write callback doesn't allow handling errors
| https://github.com/purescript-node/purescript-node-streams/issues/35 |
| Please reload this page | https://github.com/purescript-node/purescript-node-streams/pull/43 |
|
| https://github.com/JordanMartinez |
|
| https://github.com/garyb |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |