René's URL Explorer Experiment


Title: Data.Int.toStringAs leaks a global `n` (missing `local`) · Issue #1 · purescript-lua/purescript-lua-integers · GitHub

Open Graph Title: Data.Int.toStringAs leaks a global `n` (missing `local`) · Issue #1 · purescript-lua/purescript-lua-integers

X Title: Data.Int.toStringAs leaks a global `n` (missing `local`) · Issue #1 · purescript-lua/purescript-lua-integers

Description: Summary src/Data/Int.lua declares the loop variable n in toStringAs without local, so it leaks into the global environment. luacheck --std min src/ flags it as setting non-standard global variable n, and because the rest of the function ...

Open Graph Description: Summary src/Data/Int.lua declares the loop variable n in toStringAs without local, so it leaks into the global environment. luacheck --std min src/ flags it as setting non-standard global variable ...

X Description: Summary src/Data/Int.lua declares the loop variable n in toStringAs without local, so it leaks into the global environment. luacheck --std min src/ flags it as setting non-standard global variable ...

Opengraph URL: https://github.com/purescript-lua/purescript-lua-integers/issues/1

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Data.Int.toStringAs leaks a global `n` (missing `local`)","articleBody":"## Summary\n\n`src/Data/Int.lua` declares the loop variable `n` in `toStringAs` without `local`, so it leaks into the global environment. `luacheck --std min src/` flags it as `setting non-standard global variable n`, and because the rest of the function reads that name, the single missing `local` cascades into eight separate warnings.\n\n## Offending code\n\n```lua\ntoStringAs = (function(radix)\n  return function(i)\n    local floor, insert = math.floor, table.insert\n    n = floor(i)                       -- \u003c-- no `local`: global leak\n    if radix == 10 then return tostring(n) end\n    ...\n    if n \u003c 0 then\n      sign = \"-\"\n      n = -n\n    end\n    repeat\n      local d = (n % radix) + 1\n      n = floor(n / radix)\n      insert(t, 1, digits:sub(d, d))\n    until n == 0\n    ...\n```\n\n`floor` and `insert` on the preceding line are correctly `local`; only `n` was missed.\n\n## Root cause\n\nA plain assignment `n = floor(i)` instead of `local n = floor(i)`. In Lua an unqualified assignment to an undeclared name writes to the global table `_G`. Every later use of `n` in the function then resolves to that global rather than a local.\n\n## Impact\n\n- Functional: each call to `Data.Int.toStringAs` mutates the shared global `n`. In a single-threaded Lua program this is usually benign, but it is an unintended global write that can collide with any other code (the FFI runtime, user code, another module) that happens to use a global named `n`, producing hard-to-trace cross-module interference. It is the kind of latent footgun that only manifests under specific call interleavings.\n- Hygiene/tooling: `luacheck --quiet --std min src/` exits non-zero on this file. The one missing `local` produces these warnings:\n\n```\nsrc/Data/Int.lua:25:7: setting non-standard global variable n\nsrc/Data/Int.lua:26:43: accessing undefined variable n\nsrc/Data/Int.lua:30:10: accessing undefined variable n\nsrc/Data/Int.lua:32:9: setting non-standard global variable n\nsrc/Data/Int.lua:32:14: accessing undefined variable n\nsrc/Data/Int.lua:35:20: accessing undefined variable n\nsrc/Data/Int.lua:36:9: setting non-standard global variable n\nsrc/Data/Int.lua:36:19: accessing undefined variable n\n```\n\nAll eight collapse once `n` is declared `local`.\n\n## How it was found\n\nLinting the FFI sources of the Lua-fork package with `luacheck --quiet --std min src/` while auditing the `purescript-lua` package ecosystem for Lua-5.1/global-hygiene issues.\n\n## Fix\n\nAdd `local` to the declaration of `n`:\n\n```lua\nlocal n = floor(i)\n```\n\nMinimal, single-line, `src`-only change. No behaviour change for any well-formed program; it merely confines `n` to the function scope where it belongs.\n\n## Note on out-of-scope warnings\n\nThe same file also reports `accessing undefined field pow of global math` (`math.pow`, removed in Lua 5.2+) and an `unused argument nothing`. Those are distinct pre-existing issues and are intentionally left out of this fix to keep the change minimal and focused on the global leak.\n\n## Cross-reference\n\nTracked upstream by pslua issue Unisay/purescript-lua#51; this is the detailed package-level report it points to.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-06-14T08:31:20Z","url":"https://github.com/purescript-lua/purescript-lua-integers/issues/1"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:470b3b3f-d8d2-a532-c2aa-3d522b733939
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD482:27E5CD:A67DE3:D84F07:6B00E5A8
html-safe-nonce0b5e252ed9d5763f42ca2c62ae4c815300078d801c8705588ed8d1933dce7732
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDgyOjI3RTVDRDpBNjdERTM6RDg0RjA3OjZCMDBFNUE4IiwidmlzaXRvcl9pZCI6IjM3NjM0NzgyMzMyMjAxNzkzNjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaceba7b545f24266cae526579fa1faf9aa5a42b81f8994235a93d7fa054fb8f050
hovercard-subject-tagissue:4658448293
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua-integers/1/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ad2a1df2dc0035c284947a8d8d251e62bbef6ed9f2ff59f61523e05fe6009b92/purescript-lua/purescript-lua-integers/issues/1
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ad2a1df2dc0035c284947a8d8d251e62bbef6ed9f2ff59f61523e05fe6009b92/purescript-lua/purescript-lua-integers/issues/1
og:image:altSummary src/Data/Int.lua declares the loop variable n in toStringAs without local, so it leaks into the global environment. luacheck --std min src/ flags it as setting non-standard global variable ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameUnisay
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-preview
go-importgithub.com/purescript-lua/purescript-lua-integers git https://github.com/purescript-lua/purescript-lua-integers.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id779795746
octolytics-dimension-repository_nwopurescript-lua/purescript-lua-integers
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id30888599
octolytics-dimension-repository_parent_nwopurescript/purescript-integers
octolytics-dimension-repository_network_root_id30888599
octolytics-dimension-repository_network_root_nwopurescript/purescript-integers
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua-integers/issues/1#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua-integers%2Fissues%2F1
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua-integers%2Fissues%2F1
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua-integers
Reloadhttps://github.com/purescript-lua/purescript-lua-integers/issues/1
Reloadhttps://github.com/purescript-lua/purescript-lua-integers/issues/1
Reloadhttps://github.com/purescript-lua/purescript-lua-integers/issues/1
purescript-luahttps://github.com/purescript-lua
purescript-lua-integershttps://github.com/purescript-lua/purescript-lua-integers
Codehttps://github.com/purescript-lua/purescript-lua-integers
Issueshttps://github.com/purescript-lua/purescript-lua-integers/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua-integers/pulls
Actionshttps://github.com/purescript-lua/purescript-lua-integers/actions
Security and qualityhttps://github.com/purescript-lua/purescript-lua-integers/security
Insightshttps://github.com/purescript-lua/purescript-lua-integers/insights
https://github.com/purescript-lua/purescript-lua-integers
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua-integers/issues/1
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua-integers/issues/1
#2https://github.com/purescript-lua/purescript-lua-integers/pull/2
Data.Int.toStringAs leaks a global n (missing local)https://github.com/purescript-lua/purescript-lua-integers/issues/1#top
#2https://github.com/purescript-lua/purescript-lua-integers/pull/2
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jun 14, 2026https://github.com/purescript-lua/purescript-lua-integers/issues/1#issue-4658448293
purescript-lua/purescript-lua#51https://github.com/purescript-lua/purescript-lua/issues/51
Unisayhttps://github.com/Unisay
completedhttps://github.com/purescript-lua/purescript-lua-integers/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#2https://github.com/purescript-lua/purescript-lua-integers/pull/2
on Jun 14, 2026https://github.com/purescript-lua/purescript-lua-integers/issues/1#event-26724481295
Sign up for freehttps://github.com/signup?return_to=https://github.com/purescript-lua/purescript-lua-integers/issues/1
Sign in to commenthttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua-integers/issues/1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.