René's URL Explorer Experiment


Title: test: lock regressions for #28 and #30 by Unisay · Pull Request #47 · purescript-lua/purescript-lua · GitHub

Open Graph Title: test: lock regressions for #28 and #30 by Unisay · Pull Request #47 · purescript-lua/purescript-lua

X Title: test: lock regressions for #28 and #30 by Unisay · Pull Request #47 · purescript-lua/purescript-lua

Description: Both bugs turned out to be already fixed on main, but neither issue got closed because the reporters never confirmed. This PR adds eval-backed regression tests so they can be closed with evidence rather than on the assumption that some commit took care of them. #28 (Data.Lens._Newtype miscompiled). Root cause was the unguarded eta reduction dropping a lambda whose dictionary parameter was still in use. It was fixed twice: 833cec8 added a free-variable guard, and #45 later removed eta reduction entirely (see Note [Eta reduction is unsound]). The new Golden.ProfunctorDictLens.Test reproduces the _Newtype shape without pulling in profunctor-lenses: _Wrapped = dimap unwrap Wrapped is abstracted over the Profunctor dictionary and used more than once, so the used-once inliner cannot hide a lost dictionary lambda. The generated Lua keeps the binding as function(dictProfunctor) ... end, and the eval golden checks the runtime output. #30 (pslua: Impossible subexpressions: IfThenElse). The crash lived in the currying optimizer, which 965d1fe removed wholesale; grep -rn Impossible lib/ comes back empty today. Golden.MaybeChain.Test reproduces the nested maybe/map chain from the report with an eval golden (application link mode), and Golden.MaybeChainModule.Test covers module link mode, which is where the crash was originally reported. test/ps/spago.dhall gains maybe, newtype and profunctor as direct dependencies; all three were already present in the package set transitively. Closes #28 Closes #30

Open Graph Description: Both bugs turned out to be already fixed on main, but neither issue got closed because the reporters never confirmed. This PR adds eval-backed regression tests so they can be closed with evidence r...

X Description: Both bugs turned out to be already fixed on main, but neither issue got closed because the reporters never confirmed. This PR adds eval-backed regression tests so they can be closed with evidence r...

Opengraph URL: https://github.com/purescript-lua/purescript-lua/pull/47

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:68b9fc51-eacb-7f2e-cfb7-3729a32cecca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9F04:3897F3:BFFFC6:F93005:6B00EF93
html-safe-nonce4c99c4cc22bda1470804fdce0048f8d27d492006315621e4038aa7c4de1060fd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjA0OjM4OTdGMzpCRkZGQzY6RjkzMDA1OjZCMDBFRjkzIiwidmlzaXRvcl9pZCI6IjE4MDUyODA4NTA1ODYxNjkyMzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac840c95f4730577f66ade5dde177f4eef92da822e18d358ccde042a6827e2b515
hovercard-subject-tagpull_request:3855556791
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/purescript-lua/purescript-lua/pull/47/files
twitter:imagehttps://avatars.githubusercontent.com/u/1009751?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1009751?s=400&v=4
og:image:altBoth bugs turned out to be already fixed on main, but neither issue got closed because the reporters never confirmed. This PR adds eval-backed regression tests so they can be closed with evidence r...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/pull/47/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fpull%2F47%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fpull%2F47%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/pull/47/files
Reloadhttps://github.com/purescript-lua/purescript-lua/pull/47/files
Reloadhttps://github.com/purescript-lua/purescript-lua/pull/47/files
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2Fnew%2Fchoose
Unisayhttps://github.com/Unisay
mainhttps://github.com/purescript-lua/purescript-lua/tree/main
issue-28-30/regression-testshttps://github.com/purescript-lua/purescript-lua/tree/issue-28-30/regression-tests
Conversation 1 https://github.com/purescript-lua/purescript-lua/pull/47
Commits 2 https://github.com/purescript-lua/purescript-lua/pull/47/commits
Checks 1 https://github.com/purescript-lua/purescript-lua/pull/47/checks
Files changed https://github.com/purescript-lua/purescript-lua/pull/47/files
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/47/files
test: lock regressions for #28 and #30 https://github.com/purescript-lua/purescript-lua/pull/47/files#top
Show all changes 2 commits https://github.com/purescript-lua/purescript-lua/pull/47/files
c251beb test: lock regression for #28 (profunctor dict lens) Unisay Jun 12, 2026 https://github.com/purescript-lua/purescript-lua/pull/47/commits/c251beb40a0b6faddb82e9afc57c7e33ae1d8f1b
5a797be test: lock regression for #30 (maybe chain optimizer crash) Unisay Jun 12, 2026 https://github.com/purescript-lua/purescript-lua/pull/47/commits/5a797bee5c0ee0abc193b6bb07e14ae86465ad77
Clear filters https://github.com/purescript-lua/purescript-lua/pull/47/files
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/47/files
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/47/files
Test.purs https://github.com/purescript-lua/purescript-lua/pull/47/files#diff-cdbb2fa179d6485834c408cb84762884b2dfe75357375e7db3ab802ec1e83563
Test.purs https://github.com/purescript-lua/purescript-lua/pull/47/files#diff-3ee0af3b5687517d543bf7f00eb987d7bf28a59ed4b0d28e07d64727747c920c
Test.purs https://github.com/purescript-lua/purescript-lua/pull/47/files#diff-4a7e1c8cb22a06d67830b816d41c408984d16300b77fa6141c364adac75aff4b
corefn.json https://github.com/purescript-lua/purescript-lua/pull/47/files#diff-a764461786acb9d5598c524b463828c43a1cf16c8109eb5d360a3a2057416742
.gitignore https://github.com/purescript-lua/purescript-lua/pull/47/files#diff-c2c4e662963b7080f73a19a8710c72e43a2cbdfa51c7300dce1d8297ffdca443
golden.txt https://github.com/purescript-lua/purescript-lua/pull/47/files#diff-1253b2143643542f63edaca8e55976c2c9ede8eb6c204adfa438b37d2e98aae6
golden.ir https://github.com/purescript-lua/purescript-lua/pull/47/files#diff-3006141b034eb94f2e88b5db2e09fd3a0fb2c4565719131fe516243bc24b92e8
golden.lua https://github.com/purescript-lua/purescript-lua/pull/47/files#diff-8e7867f5f173ace42b15b122ecdf3ff80cec593e6931cb44edafb30838f1044a
corefn.json https://github.com/purescript-lua/purescript-lua/pull/47/files#diff-01843e5422c0a6fa2440be1b8701b48efcee9b6cdff19ad82bc5e1891889a0d4
golden.ir https://github.com/purescript-lua/purescript-lua/pull/47/files#diff-34418e53398e71f9f3991f6108c7e3efe4031c294dd127d3531215598cec350f
golden.lua https://github.com/purescript-lua/purescript-lua/pull/47/files#diff-f4d6b8c9c13f7caba9fcfd1d8302989a82ef8caa1bc9ebfa393fd60ef792c875
corefn.json https://github.com/purescript-lua/purescript-lua/pull/47/files#diff-e352ee90420b071aea6205a997554a721c402f9da126f7ff482f005a12a3e94c
.gitignore https://github.com/purescript-lua/purescript-lua/pull/47/files#diff-68984b5d7719903f336eac2fadee6cfb110fa23e4396ebf8c811fb1170b5aed5
golden.txt https://github.com/purescript-lua/purescript-lua/pull/47/files#diff-c476b8f04815da86ea178013a3bb93ef46e681e834a0ec74749250bddf97bbf2
golden.ir https://github.com/purescript-lua/purescript-lua/pull/47/files#diff-ea89ea708c8e25a05b63283fb8d74820b2ce2219bd5484a5f8b7b9b4c3d2a659
golden.lua https://github.com/purescript-lua/purescript-lua/pull/47/files#diff-4f0755e4e4caea3e293c097cbe735d371c163fa463fffab6dcb32535099b9029
spago.dhall https://github.com/purescript-lua/purescript-lua/pull/47/files#diff-f530eb9e6c28647654321ce547bc67f1dbf801c1a072a16bf4463cd6f83531ce
test/ps/golden/Golden/MaybeChain/Test.purshttps://github.com/purescript-lua/purescript-lua/pull/47/files#diff-cdbb2fa179d6485834c408cb84762884b2dfe75357375e7db3ab802ec1e83563
View file https://github.com/purescript-lua/purescript-lua/blob/5a797bee5c0ee0abc193b6bb07e14ae86465ad77/test/ps/golden/Golden/MaybeChain/Test.purs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/purescript-lua/purescript-lua/pull/47/{{ revealButtonHref }}
test/ps/golden/Golden/MaybeChainModule/Test.purshttps://github.com/purescript-lua/purescript-lua/pull/47/files#diff-3ee0af3b5687517d543bf7f00eb987d7bf28a59ed4b0d28e07d64727747c920c
View file https://github.com/purescript-lua/purescript-lua/blob/5a797bee5c0ee0abc193b6bb07e14ae86465ad77/test/ps/golden/Golden/MaybeChainModule/Test.purs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/purescript-lua/purescript-lua/pull/47/{{ revealButtonHref }}
test/ps/golden/Golden/ProfunctorDictLens/Test.purshttps://github.com/purescript-lua/purescript-lua/pull/47/files#diff-4a7e1c8cb22a06d67830b816d41c408984d16300b77fa6141c364adac75aff4b
View file https://github.com/purescript-lua/purescript-lua/blob/5a797bee5c0ee0abc193b6bb07e14ae86465ad77/test/ps/golden/Golden/ProfunctorDictLens/Test.purs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/purescript-lua/purescript-lua/pull/47/{{ revealButtonHref }}
test/ps/output/Golden.MaybeChain.Test/corefn.jsonhttps://github.com/purescript-lua/purescript-lua/pull/47/files#diff-a764461786acb9d5598c524b463828c43a1cf16c8109eb5d360a3a2057416742
View file https://github.com/purescript-lua/purescript-lua/blob/5a797bee5c0ee0abc193b6bb07e14ae86465ad77/test/ps/output/Golden.MaybeChain.Test/corefn.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/purescript-lua/purescript-lua/pull/47/{{ revealButtonHref }}
test/ps/output/Golden.MaybeChain.Test/eval/.gitignorehttps://github.com/purescript-lua/purescript-lua/pull/47/files#diff-c2c4e662963b7080f73a19a8710c72e43a2cbdfa51c7300dce1d8297ffdca443
View file https://github.com/purescript-lua/purescript-lua/blob/5a797bee5c0ee0abc193b6bb07e14ae86465ad77/test/ps/output/Golden.MaybeChain.Test/eval/.gitignore
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/purescript-lua/purescript-lua/pull/47/{{ revealButtonHref }}
test/ps/output/Golden.MaybeChain.Test/eval/golden.txthttps://github.com/purescript-lua/purescript-lua/pull/47/files#diff-1253b2143643542f63edaca8e55976c2c9ede8eb6c204adfa438b37d2e98aae6
View file https://github.com/purescript-lua/purescript-lua/blob/5a797bee5c0ee0abc193b6bb07e14ae86465ad77/test/ps/output/Golden.MaybeChain.Test/eval/golden.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/purescript-lua/purescript-lua/pull/47/{{ revealButtonHref }}
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/47/files
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/47/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.