René's URL Explorer Experiment


Title: feat(optimizer): gate inlining with Complexity/Capture lattices by Unisay · Pull Request #244 · purescript-lua/purescript-lua · GitHub

Open Graph Title: feat(optimizer): gate inlining with Complexity/Capture lattices by Unisay · Pull Request #244 · purescript-lua/purescript-lua

X Title: feat(optimizer): gate inlining with Complexity/Capture lattices by Unisay · Pull Request #244 · purescript-lua/purescript-lua

Description: Closes #231. What Two small analysis lattices sharpen the shared inlining guard: Complexity = Trivial < Deref < KnownSize < NonTrivial (complexityOf, a bottom-up classifier next to expSize) Capture = CaptureNone < CaptureBranch < CaptureClosure (countFreeRefUsage, a per-site variant of countFreeRef reporting the strongest wrapper crossed between the root and each reference) Two new tiers feed the guard shared by withBinding, betaReduce and inlineLocalBinding (Note [Complexity and Capture gate inlining]): Deref tier: an expression of complexity at most Deref and size under 16 pastes at any use count. Records and module tables are write-once, so re-reading a projection chain preserves semantics. Multi-use projection aliases dissolve. KnownSize tier (local sites only): a closed lambda under 16 nodes whose bound name is used only outside branches and closures substitutes at every site, so a locally bound combinator beta-reduces everywhere. The CaptureNone gate refuses to move a lambda literal into a branch or closure (the per-call closure-allocation pathology of #204), so closedness and small size alone do not admit duplication. A NonTrivial body is never duplicated. The @inline pragmas, the used-once path, the ForeignImport veto and the module-level count map are untouched; inlineSizeBudget = 64 stays the call-site ceiling. Red → green The spec commit lands first with a compile-ready skeleton (exact totals, CaptureNone context): 106 examples, 6 failures. Failing were the Deref tier, both KnownSize substitution paths and the three capture-context examples; the sharing pins and every pre-existing spec passed. The feat commit turns the six green without touching the pins. One pre-existing fixture moved: the #131 leak-guard test used a projection-shaped field, which the Deref tier now inlines on its own merit regardless of annotation. The fixture is an annotated application now, so only a leaked Just Always can make the binding inlinable and the guard keeps its teeth. Corpus 10 of 62 golden modules move, net -223 lines of generated Lua. All 31 eval oracles pass unchanged (they are never auto-accepted), luacheck passes, and the checked pipeline lints every pass boundary. A scan of the churn found no added line pattern whose occurrence count grew against the old goldens: nothing non-trivial got duplicated. The Uncurry module shows the intended end shape: tiny uncurried workers like add$w = function(x, y) return x + y end disappear and their call sites fold to +. The collapse is a domino cascade rather than a direct admission: a new tier dissolves a cheap binding, the next binding becomes used-once for the existing rule, and the pass fixpoint rolls forward. A minimal probe confirms a twice-used worker still survives on its own, and the cascade surfaced a separate gap in the call-site inliner (n-ary heads), filed as a follow-up. Left for follow-ups Per-use-kind counters (call/access/case) and an admission for a projection used only in call position. #239 and #240 consume the Capture and exact-use groundwork this PR lays.

Open Graph Description: Closes #231. What Two small analysis lattices sharpen the shared inlining guard: Complexity = Trivial < Deref < KnownSize < NonTrivial (complexityOf, a bottom-up classifier next to expSiz...

X Description: Closes #231. What Two small analysis lattices sharpen the shared inlining guard: Complexity = Trivial &lt; Deref &lt; KnownSize &lt; NonTrivial (complexityOf, a bottom-up classifier ne...

Opengraph URL: https://github.com/purescript-lua/purescript-lua/pull/244

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1b4b3f65-454d-739b-f558-2b3e823b9bcc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA102:1087D4:A4E644:DD3F1D:6B00EFA4
html-safe-nonce7dc4dc3f36f4a3aedf4b30d687cc96f50108a738f88f4a5dbdd47fd61c5b7cda
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTAyOjEwODdENDpBNEU2NDQ6REQzRjFEOjZCMDBFRkE0IiwidmlzaXRvcl9pZCI6IjQ1MjUyNzQ3OTU4MDUzMDY3ODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0e4a58307d43ffdbfa351850cd029086f24dd065aba905a10388c9f9b6a8c14e
hovercard-subject-tagpull_request:4037013971
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/purescript-lua/purescript-lua/pull/244/files
twitter:imagehttps://avatars.githubusercontent.com/u/1009751?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1009751?s=400&v=4
og:image:altCloses #231. What Two small analysis lattices sharpen the shared inlining guard: Complexity = Trivial < Deref < KnownSize < NonTrivial (complexityOf, a bottom-up classifier next to expSiz...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/pull/244/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fpull%2F244%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fpull%2F244%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/pull/244/files
Reloadhttps://github.com/purescript-lua/purescript-lua/pull/244/files
Reloadhttps://github.com/purescript-lua/purescript-lua/pull/244/files
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2Fnew%2Fchoose
Unisayhttps://github.com/Unisay
mainhttps://github.com/purescript-lua/purescript-lua/tree/main
issue-231/complexity-capture-latticehttps://github.com/purescript-lua/purescript-lua/tree/issue-231/complexity-capture-lattice
Conversation 1 https://github.com/purescript-lua/purescript-lua/pull/244
Commits 4 https://github.com/purescript-lua/purescript-lua/pull/244/commits
Checks 2 https://github.com/purescript-lua/purescript-lua/pull/244/checks
Files changed https://github.com/purescript-lua/purescript-lua/pull/244/files
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/244/files
feat(optimizer): gate inlining with Complexity/Capture lattices https://github.com/purescript-lua/purescript-lua/pull/244/files#top
Show all changes 4 commits https://github.com/purescript-lua/purescript-lua/pull/244/files
2207b71 test(optimizer): specs for the Complexity/Capture inlining gates (#231) Unisay Jul 11, 2026 https://github.com/purescript-lua/purescript-lua/pull/244/commits/2207b714b68c287acc9bf1040e5a6081a3938af5
97368f0 feat(optimizer): gate inlining with Complexity/Capture lattices (#231) Unisay Jul 12, 2026 https://github.com/purescript-lua/purescript-lua/pull/244/commits/97368f0adf252d157d978e4bbd7196a03673031d
2d0079f test(golden): accept structural churn from the Complexity/Capture gat… Unisay Jul 11, 2026 https://github.com/purescript-lua/purescript-lua/pull/244/commits/2d0079fc0bb866086944cf93efe65e80a69f5861
ed79493 docs(magic-do): state the transformation generically in the module he… Unisay Jul 12, 2026 https://github.com/purescript-lua/purescript-lua/pull/244/commits/ed794936f2f1be53fa5d77117de7b2e156086946
Clear filters https://github.com/purescript-lua/purescript-lua/pull/244/files
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/244/files
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/244/files
20260712_090000_unisay_complexity_capture_inlining.md https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-045c85c8e50eecd2a41840a63eca69220b670bb89347fad52b638ec84dfe417d
MagicDo.hs https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-328cbd548cb26793eb748fd65aeac8ad258513e2b55db04b4d1aefc7477ea06f
Optimizer.hs https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
Types.hs https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-c628fb950daac01f47dc80a039e24b8b452f9d578ab0d55483d10758027b4884
Spec.hs https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-241ea2421c606c31b9414fb386f9f4d1beb60055ed792935b393101edfd7b949
golden.ir https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-a50730a65be2dd43fb54fcc7256daba19c0f0d185fa91ae70fd74eb6dc88babb
golden.lua https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-f09de2d9591e7ed04c015cf5105c29cef2be557187d5d7b8ca203b70d4f11bfc
golden.ir https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-8529207f5726b1c4ce856b7d81dadbbbdc4b244d37e96f40d897c3acc69290b8
golden.lua https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-0c90c2d7623d39f887ed98803e0198ce7532cb955c04690d5c518a02bb16d0e1
golden.ir https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-40d54b27f028b6066bcec746327a3f0a128053c75819d4019f03cfcc0fce015f
golden.lua https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-a3c17d21777b8fc58fbba68eb74a46fb303e60a17d8524ca2674479e0ebf7eb9
golden.ir https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-d3c70e506ea822ff99389c6a4e383878df25de8723c47a01e91e7dc5792501dc
golden.lua https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-596c7cb04898e2e110885627fbe42de08e09aa38b253a73bf3a99c9cedfa6bec
golden.ir https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-214ade9cc7aa9bbbaeb07927c013dfa7eeb9f9e2f12ed14f5d31fc98a446bd13
golden.lua https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-67e4dcf4711ce34fdb0ed8a2c23c4b638cf54c282818689a85be15ec720ace60
golden.ir https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-c87daf3e43a53dd52fa264f09901b86021b6ee624f9da16bea90707758b8abfe
golden.lua https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-7a0f829c8097adffc9b5bff2f03fd5a9a7d69ed4d2e1719bd21e8c484253266d
golden.ir https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-df535e1f7273af0cc86db20df55495de4552000d7bf2f3abb21f421d07947914
golden.lua https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-8f846c962c84e2efb0046e7848c15b3bac3e044be37a2d2ee0620f823f2e9b0f
golden.ir https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-943a6e999776e2a06a4d4209af7f89e9a8d977d6000c31c70ed84e781da2e2ff
golden.lua https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-56618fb442d7b6de74d0159576d795d225986345ac7840c4a3a8a3831cb98ad3
golden.ir https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-9f1799ede16b2de76bbd9ce943935d297b0b2196125598eee26cc4313177c6b4
golden.lua https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-5921e666a0348af0dd78380b07fead46422cafb2d7dadb38988ae54c01af9164
golden.ir https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-61f79094c925f1c00df559521926a985640236fe532d9ccec94b9893442659e3
golden.lua https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-12b1d0aa4433bf963d1b2b3685ea3ec7726991cd5b797cdb7c8ce480aa7d24dd
changelog.d/20260712_090000_unisay_complexity_capture_inlining.mdhttps://github.com/purescript-lua/purescript-lua/pull/244/files#diff-045c85c8e50eecd2a41840a63eca69220b670bb89347fad52b638ec84dfe417d
View file https://github.com/purescript-lua/purescript-lua/blob/ed794936f2f1be53fa5d77117de7b2e156086946/changelog.d/20260712_090000_unisay_complexity_capture_inlining.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/purescript-lua/purescript-lua/pull/244/{{ revealButtonHref }}
lib/Language/PureScript/Backend/IR/MagicDo.hshttps://github.com/purescript-lua/purescript-lua/pull/244/files#diff-328cbd548cb26793eb748fd65aeac8ad258513e2b55db04b4d1aefc7477ea06f
View file https://github.com/purescript-lua/purescript-lua/blob/ed794936f2f1be53fa5d77117de7b2e156086946/lib/Language/PureScript/Backend/IR/MagicDo.hs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/purescript-lua/purescript-lua/pull/244/{{ revealButtonHref }}
https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-328cbd548cb26793eb748fd65aeac8ad258513e2b55db04b4d1aefc7477ea06f
https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-328cbd548cb26793eb748fd65aeac8ad258513e2b55db04b4d1aefc7477ea06f
lib/Language/PureScript/Backend/IR/Optimizer.hshttps://github.com/purescript-lua/purescript-lua/pull/244/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
View file https://github.com/purescript-lua/purescript-lua/blob/ed794936f2f1be53fa5d77117de7b2e156086946/lib/Language/PureScript/Backend/IR/Optimizer.hs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/purescript-lua/purescript-lua/pull/244/{{ revealButtonHref }}
https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
lib/Language/PureScript/Backend/IR/Types.hshttps://github.com/purescript-lua/purescript-lua/pull/244/files#diff-c628fb950daac01f47dc80a039e24b8b452f9d578ab0d55483d10758027b4884
View file https://github.com/purescript-lua/purescript-lua/blob/ed794936f2f1be53fa5d77117de7b2e156086946/lib/Language/PureScript/Backend/IR/Types.hs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/purescript-lua/purescript-lua/pull/244/{{ revealButtonHref }}
https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-c628fb950daac01f47dc80a039e24b8b452f9d578ab0d55483d10758027b4884
https://github.com/purescript-lua/purescript-lua/pull/244/files#diff-c628fb950daac01f47dc80a039e24b8b452f9d578ab0d55483d10758027b4884
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/244/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.