| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a9b2aa41-7ae0-3c6d-a5c8-a67f3c23b905 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DE60:4279A:8AD289:BC4C71:6B00E860 |
| html-safe-nonce | 1ac0c12c9e857b5edd4b9ce6622c0fdcab1833e98f53e88660d2df25bdc64508 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTYwOjQyNzlBOjhBRDI4OTpCQzRDNzE6NkIwMEU4NjAiLCJ2aXNpdG9yX2lkIjoiOTczNTMwNjczODg3MzczNDA4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ac10b0081c1d42934a98296f84c54b77451680bf731c6898a309cc01a80fc9d1 |
| hovercard-subject-tag | pull_request:4000753716 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/purescript-lua/purescript-lua/192/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/14cb5d1cf8c07c311ae92328d1e6d4d632577017be5daff2643580583b247273/purescript-lua/purescript-lua/pull/192 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/14cb5d1cf8c07c311ae92328d1e6d4d632577017be5daff2643580583b247273/purescript-lua/purescript-lua/pull/192 |
| og:image:alt | Fixes #168.
Problem
collectDataDeclarations decided whether a data type is a product or a sum by grouping a module's constructors with List.groupBy, keyed on the type name. groupBy only merges ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Unisay |
| hostname | github.com |
| expected-hostname | github.com |
| None | 27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14 |
| turbo-cache-control | no-cache |
| go-import | github.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git |
| octolytics-dimension-user_id | 131581790 |
| octolytics-dimension-user_login | purescript-lua |
| octolytics-dimension-repository_id | 587200487 |
| octolytics-dimension-repository_nwo | purescript-lua/purescript-lua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 587200487 |
| octolytics-dimension-repository_network_root_nwo | purescript-lua/purescript-lua |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 624179fb8b88d26ba5bba08894eb60a1c5a1d93d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/purescript-lua/purescript-lua/pull/192#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fpull%2F192 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fpull%2F192 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua |
| Reload | https://github.com/purescript-lua/purescript-lua/pull/192 |
| Reload | https://github.com/purescript-lua/purescript-lua/pull/192 |
| Reload | https://github.com/purescript-lua/purescript-lua/pull/192 |
| purescript-lua | https://github.com/purescript-lua |
| purescript-lua | https://github.com/purescript-lua/purescript-lua |
| Code | https://github.com/purescript-lua/purescript-lua |
| Issues48 (48) | https://github.com/purescript-lua/purescript-lua/issues |
| Pull requests | https://github.com/purescript-lua/purescript-lua/pulls |
| Discussions | https://github.com/purescript-lua/purescript-lua/discussions |
| Actions | https://github.com/purescript-lua/purescript-lua/actions |
| Projects | https://github.com/purescript-lua/purescript-lua/projects |
| Security and quality | https://github.com/purescript-lua/purescript-lua/security |
| Insights | https://github.com/purescript-lua/purescript-lua/insights |
| https://github.com/purescript-lua/purescript-lua |
| Unisay | https://github.com/Unisay |
| main | https://github.com/purescript-lua/purescript-lua/tree/main |
| issue-168/order-independent-data-decls | https://github.com/purescript-lua/purescript-lua/tree/issue-168/order-independent-data-decls |
| Conversation | https://github.com/purescript-lua/purescript-lua/pull/192 |
| Commits3 (3) | https://github.com/purescript-lua/purescript-lua/pull/192/commits |
| Checks | https://github.com/purescript-lua/purescript-lua/pull/192/checks |
| Files changed | https://github.com/purescript-lua/purescript-lua/pull/192/files |
| fix: classify data types independently of constructor order (#168) | https://github.com/purescript-lua/purescript-lua/pull/192#top |
| Unisay | https://github.com/Unisay |
| main | https://github.com/purescript-lua/purescript-lua/tree/main |
| issue-168/order-independent-data-decls | https://github.com/purescript-lua/purescript-lua/tree/issue-168/order-independent-data-decls |
|
| https://github.com/Unisay |
| Unisay | https://github.com/Unisay |
| Jul 6, 2026 | https://github.com/purescript-lua/purescript-lua/pull/192#issue-4821491025 |
| #168 | https://github.com/purescript-lua/purescript-lua/issues/168 |
| Please reload this page | https://github.com/purescript-lua/purescript-lua/pull/192 |
| Unisay | https://github.com/Unisay |
| July 6, 2026 19:14 | https://github.com/purescript-lua/purescript-lua/pull/192#commits-pushed-aaee647 |
|
| https://github.com/Unisay |
| fix: classify data types independently of constructor order ( | https://github.com/purescript-lua/purescript-lua/pull/192/commits/aaee64777783c7a79a4b5ec2de5445e603422706 |
| #168 | https://github.com/purescript-lua/purescript-lua/issues/168 |
| ) | https://github.com/purescript-lua/purescript-lua/pull/192/commits/aaee64777783c7a79a4b5ec2de5445e603422706 |
| aaee647 | https://github.com/purescript-lua/purescript-lua/pull/192/commits/aaee64777783c7a79a4b5ec2de5445e603422706 |
|
| https://github.com/Unisay |
| perf: emit the $ctor row only for sum-type constructors ( | https://github.com/purescript-lua/purescript-lua/pull/192/commits/1281e43c82dbc1497bf440f58ef325190cfaf2f8 |
| #168 | https://github.com/purescript-lua/purescript-lua/issues/168 |
| ) | https://github.com/purescript-lua/purescript-lua/pull/192/commits/1281e43c82dbc1497bf440f58ef325190cfaf2f8 |
| 1281e43 | https://github.com/purescript-lua/purescript-lua/pull/192/commits/1281e43c82dbc1497bf440f58ef325190cfaf2f8 |
|
| https://github.com/Unisay |
| chore: drop the unused specialNameCtor | https://github.com/purescript-lua/purescript-lua/pull/192/commits/d33041f694ffde81f7311c2f983922adec3f78e5 |
| d33041f | https://github.com/purescript-lua/purescript-lua/pull/192/commits/d33041f694ffde81f7311c2f983922adec3f78e5 |
| https://github.com/Unisay |
| Unisay | https://github.com/Unisay |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
| July 6, 2026 17:19 | https://github.com/purescript-lua/purescript-lua/pull/192#event-27621982003 |
| started reviewing | https://github.com/purescript-lua/purescript-lua/sessions/707b2c16-cd37-48d2-99ed-927dbf0f6945 |
| Unisay | https://github.com/Unisay |
| July 6, 2026 17:20 | https://github.com/purescript-lua/purescript-lua/pull/192#event-27622000182 |
|
View session
| https://github.com/purescript-lua/purescript-lua/sessions/707b2c16-cd37-48d2-99ed-927dbf0f6945 |
|
| https://github.com/apps/copilot-pull-request-reviewer |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
|
Jul 6, 2026
| https://github.com/purescript-lua/purescript-lua/pull/192#pullrequestreview-4638214197 |
|
View reviewed changes
| https://github.com/purescript-lua/purescript-lua/pull/192/files/d33041f694ffde81f7311c2f983922adec3f78e5 |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
| https://github.com/purescript-lua/purescript-lua/pull/192#pullrequestreview-4638214197 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/purescript-lua/purescript-lua/pull/192 |
| https://github.com/Unisay |
| Unisay | https://github.com/Unisay |
| Jul 6, 2026 | https://github.com/purescript-lua/purescript-lua/pull/192#event-27622187174 |
| https://github.com/Unisay |
| Unisay | https://github.com/Unisay |
| July 6, 2026 17:24 | https://github.com/purescript-lua/purescript-lua/pull/192#event-27622190237 |
| https://github.com/Unisay |
| Unisay | https://github.com/Unisay |
| 7252f34 | https://github.com/purescript-lua/purescript-lua/commit/7252f348fcf0ad7784bc1204fe4939054ae0ff18 |
| Jul 6, 2026 | https://github.com/purescript-lua/purescript-lua/pull/192#event-27622234999 |
| Please reload this page | https://github.com/purescript-lua/purescript-lua/pull/192 |
| https://github.com/Unisay |
| Unisay | https://github.com/Unisay |
| July 6, 2026 17:25 | https://github.com/purescript-lua/purescript-lua/pull/192#event-27622237195 |
| https://github.co/hiddenchars |
| https://github.com/purescript-lua/purescript-lua/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fpull%2F192 |
|
Copilot code review
| https://github.com/apps/copilot-pull-request-reviewer |
|
Copilot
| https://github.com/apps/copilot-pull-request-reviewer |
| Learn more about Copilot code review. | https://gh.io/copilot-code-review-docs |
|
| https://github.com/purescript-lua/purescript-lua/pull/192/files/d33041f694ffde81f7311c2f983922adec3f78e5 |
| Please reload this page | https://github.com/purescript-lua/purescript-lua/pull/192 |
|
| https://github.com/Unisay |
|
Unisay
| https://github.com/Unisay |
|
collectDataDeclarations classifies types by constructor adjacency, so a reordered CoreFn would silently break pattern matching
| https://github.com/purescript-lua/purescript-lua/issues/168 |
| Please reload this page | https://github.com/purescript-lua/purescript-lua/pull/192 |
|
| https://github.com/Unisay |
|
| https://github.com/apps/copilot-pull-request-reviewer |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |