René's URL Explorer Experiment


Title: Guard reduceTableDefinitionAccessor against ambiguous table literals by Unisay · Pull Request #152 · purescript-lua/purescript-lua · GitHub

Open Graph Title: Guard reduceTableDefinitionAccessor against ambiguous table literals by Unisay · Pull Request #152 · purescript-lua/purescript-lua

X Title: Guard reduceTableDefinitionAccessor against ambiguous table literals by Unisay · Pull Request #152 · purescript-lua/purescript-lua

Description: Closes #140. Summary The Lua optimizer rule reduceTableDefinitionAccessor folds a field access into a table literal, rewriting { foo = 1, bar = 2 }.foo to 1. It searched only name-value rows (TableRowNV) and took the first match, falling back to Nil. Two shapes broke that: A string-keyed row (["foo"] = 1, a TableRowKV) for the accessed field is invisible to the name lookup, so the rule folded the access to Nil and dropped the real value. On a duplicate field name, Lua's constructor keeps the last assignment while the first-match lookup returns the earliest, so the rule could fold to the wrong value. Neither shape is produced by the current codegen, so this is a latent miscompile rather than a live one. The rule now fires only when the constructor is unambiguous: every row is a name-value row and no field name repeats. Otherwise it leaves the expression untouched. Changes lib/Language/PureScript/Backend/Lua/Optimizer.hs: guard the rewrite with an all-name-value check and a duplicate-name check; the Haddock explains both hazards. test/Language/PureScript/Backend/Lua/Optimizer/Spec.hs: the rule had no test before. Three cases now pin it: the fold still fires on an unambiguous literal, and it declines on a key-value row and on duplicate names (both were red against the old rule). Test plan cabal test all --test-show-details=direct passes The two decline tests fail against the pre-fix rule (confirmed red) and pass after fourmolu and hlint clean on the touched files, warning-free build

Open Graph Description: Closes #140. Summary The Lua optimizer rule reduceTableDefinitionAccessor folds a field access into a table literal, rewriting { foo = 1, bar = 2 }.foo to 1. It searched only name-value rows (Table...

X Description: Closes #140. Summary The Lua optimizer rule reduceTableDefinitionAccessor folds a field access into a table literal, rewriting { foo = 1, bar = 2 }.foo to 1. It searched only name-value rows (Table...

Opengraph URL: https://github.com/purescript-lua/purescript-lua/pull/152

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e9a318ea-682a-a6ec-b3ba-ae493dee17f9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC72:3A347:9416E2:C5CE58:6B00E481
html-safe-nonce0afa7e59a0b509354df2bc337a6be756111ae7a827bcb69f873205506aabdf5b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzcyOjNBMzQ3Ojk0MTZFMjpDNUNFNTg6NkIwMEU0ODEiLCJ2aXNpdG9yX2lkIjoiMzIyNDQzNTc5NDM0NTI1NjA2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacaef3ffa4e4085a37b74b5942bee951f0c34a6aeaf601a50cfea1aeb2f85aceb9
hovercard-subject-tagpull_request:3989949622
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/purescript-lua/purescript-lua/pull/152/files
twitter:imagehttps://avatars.githubusercontent.com/u/1009751?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1009751?s=400&v=4
og:image:altCloses #140. Summary The Lua optimizer rule reduceTableDefinitionAccessor folds a field access into a table literal, rewriting { foo = 1, bar = 2 }.foo to 1. It searched only name-value rows (Table...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/pull/152/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fpull%2F152%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fpull%2F152%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/pull/152/files
Reloadhttps://github.com/purescript-lua/purescript-lua/pull/152/files
Reloadhttps://github.com/purescript-lua/purescript-lua/pull/152/files
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2Fnew%2Fchoose
Unisayhttps://github.com/Unisay
mainhttps://github.com/purescript-lua/purescript-lua/tree/main
issue-140/table-accessor-guardhttps://github.com/purescript-lua/purescript-lua/tree/issue-140/table-accessor-guard
Conversation 1 https://github.com/purescript-lua/purescript-lua/pull/152
Commits 1 https://github.com/purescript-lua/purescript-lua/pull/152/commits
Checks 2 https://github.com/purescript-lua/purescript-lua/pull/152/checks
Files changed https://github.com/purescript-lua/purescript-lua/pull/152/files
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/152/files
Guard reduceTableDefinitionAccessor against ambiguous table literals https://github.com/purescript-lua/purescript-lua/pull/152/files#top
Show all changes 1 commit https://github.com/purescript-lua/purescript-lua/pull/152/files
cf43b4f fix: decline the table-accessor fold on ambiguous constructors Unisay Jul 4, 2026 https://github.com/purescript-lua/purescript-lua/pull/152/commits/cf43b4f49a36cb2fa387edea8584cf289a2d14fe
Clear filters https://github.com/purescript-lua/purescript-lua/pull/152/files
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/152/files
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/152/files
20260704_120000_unisay_table_accessor_guard.md https://github.com/purescript-lua/purescript-lua/pull/152/files#diff-1f62514a2cf31199bc23c71a8854c48e96a69512573a1109f5ec3ff2b65c9d11
Optimizer.hs https://github.com/purescript-lua/purescript-lua/pull/152/files#diff-729235f45985a9f15089eee44d4ee219effa1f8365a3359452ff51c908fe5e41
Spec.hs https://github.com/purescript-lua/purescript-lua/pull/152/files#diff-0cf3bacadac71b36286d45fe27adeb3db6839bc38502708722e8552067effd2a
changelog.d/20260704_120000_unisay_table_accessor_guard.mdhttps://github.com/purescript-lua/purescript-lua/pull/152/files#diff-1f62514a2cf31199bc23c71a8854c48e96a69512573a1109f5ec3ff2b65c9d11
View file https://github.com/purescript-lua/purescript-lua/blob/cf43b4f49a36cb2fa387edea8584cf289a2d14fe/changelog.d/20260704_120000_unisay_table_accessor_guard.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/purescript-lua/purescript-lua/pull/152/{{ revealButtonHref }}
lib/Language/PureScript/Backend/Lua/Optimizer.hshttps://github.com/purescript-lua/purescript-lua/pull/152/files#diff-729235f45985a9f15089eee44d4ee219effa1f8365a3359452ff51c908fe5e41
View file https://github.com/purescript-lua/purescript-lua/blob/cf43b4f49a36cb2fa387edea8584cf289a2d14fe/lib/Language/PureScript/Backend/Lua/Optimizer.hs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/purescript-lua/purescript-lua/pull/152/{{ revealButtonHref }}
https://github.com/purescript-lua/purescript-lua/pull/152/files#diff-729235f45985a9f15089eee44d4ee219effa1f8365a3359452ff51c908fe5e41
https://github.com/purescript-lua/purescript-lua/pull/152/files#diff-729235f45985a9f15089eee44d4ee219effa1f8365a3359452ff51c908fe5e41
https://github.com/purescript-lua/purescript-lua/pull/152/files#diff-729235f45985a9f15089eee44d4ee219effa1f8365a3359452ff51c908fe5e41
test/Language/PureScript/Backend/Lua/Optimizer/Spec.hshttps://github.com/purescript-lua/purescript-lua/pull/152/files#diff-0cf3bacadac71b36286d45fe27adeb3db6839bc38502708722e8552067effd2a
View file https://github.com/purescript-lua/purescript-lua/blob/cf43b4f49a36cb2fa387edea8584cf289a2d14fe/test/Language/PureScript/Backend/Lua/Optimizer/Spec.hs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/purescript-lua/purescript-lua/pull/152/{{ revealButtonHref }}
https://github.com/purescript-lua/purescript-lua/pull/152/files#diff-0cf3bacadac71b36286d45fe27adeb3db6839bc38502708722e8552067effd2a
https://github.com/purescript-lua/purescript-lua/pull/152/files#diff-0cf3bacadac71b36286d45fe27adeb3db6839bc38502708722e8552067effd2a
https://github.com/purescript-lua/purescript-lua/pull/152/files#diff-0cf3bacadac71b36286d45fe27adeb3db6839bc38502708722e8552067effd2a
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/152/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.