René's URL Explorer Experiment


Title: docs: close out the GHC-style Note pass (#44) by Unisay · Pull Request #130 · purescript-lua/purescript-lua · GitHub

Open Graph Title: docs: close out the GHC-style Note pass (#44) by Unisay · Pull Request #130 · purescript-lua/purescript-lua

X Title: docs: close out the GHC-style Note pass (#44) by Unisay · Pull Request #130 · purescript-lua/purescript-lua

Description: Summary The final #44 batch. It adds the one remaining low-priority Note that earns its keep and makes a conscious call on the rest, so the issue's "decide consciously rather than by omission" goal is met for every listed item. Comments only, so generated code, goldens, and eval oracles are unchanged. Closes #44. Added Note [IR is assumed well-typed] in IR.Optimizer. The optimizer trusts the type checker rather than re-checking: constantFolding rewrites Eq True b to b because b must be a Bool, and betaReduce substitutes an argument for a parameter without checking the types match. Cited from both rewrites. Conscious calls on the rest Left as adequate inline documentation (a titled Note would add ceremony without a second citation site): InternalIdentData (Names) already has a complete Haddock. "Prim is always imported" (Backend.IR.mkImports) has a one-line comment explaining the always-add-then-DCE approach; it is a single site. unsafePerformIO in PSString.decodeString already carries the standard safety argument. The case-alternatives ASCII diagram lives in the IR spec; it is test-local and fine where it is. Deliberately not retitled, to avoid divergence from upstream purs: The remaining CoreFn.Laziness prose (the full delay/force rules, the USE-INIT/USE-USE/USE-IMMEDIATE derivation, and the MaxRoseTree termination argument) is thorough and only cited from within that file. Batch 3 already gave the cross-module contract (the runtime-lazy convention) and the transform a citable anchor; titling the rest would diverge from the adapted upstream source for marginal benefit. Note discovered along the way @inline never does not currently veto inlining (documented in Note [Inline annotations and inlining heuristics] from the previous batch): isInlinableExpr treats Just Never like Nothing, so a ref / small literal / single-use binding is still inlined. Flagging it here; whether never should actually veto is a behavior question for a separate change, not this docs pass. Checklist Added a changelog.d/ fragment for any user-facing change (scriv create in the dev shell), or this change ships nothing releasable (CI, docs, or an internal refactor). In the dev shell (nix develop), fourmolu -i lib/ exe/ test/ and hlint lib/ exe/ test/ are clean. In the dev shell, cabal test all passes; structural goldens were re-accepted on purpose if codegen moved (PSLUA_GOLDEN_ACCEPT=1), and eval/golden.txt still holds.

Open Graph Description: Summary The final #44 batch. It adds the one remaining low-priority Note that earns its keep and makes a conscious call on the rest, so the issue's "decide consciously rather than by omiss...

X Description: Summary The final #44 batch. It adds the one remaining low-priority Note that earns its keep and makes a conscious call on the rest, so the issue's "decide consciously rather than ...

Opengraph URL: https://github.com/purescript-lua/purescript-lua/pull/130

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2b1bc96a-a0d1-e061-9af7-ceae15de29fc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA266:3E4205:BF4CDF:10117FF:6B00F9D3
html-safe-noncee4bbacd622b666ab377f055a06d8e09cdb9ecbd4ba05f99b5a3790ec05cf04b2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjY2OjNFNDIwNTpCRjRDREY6MTAxMTdGRjo2QjAwRjlEMyIsInZpc2l0b3JfaWQiOiIxMjY1MDgzMTIxMzQzMTk5Njk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0fa04b7c363e227031e8c7360c5f9f72869af6ad1cd6673384f1c8867fb887ce
hovercard-subject-tagpull_request:3937513703
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/purescript-lua/purescript-lua/pull/130/files
twitter:imagehttps://avatars.githubusercontent.com/u/1009751?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1009751?s=400&v=4
og:image:altSummary The final #44 batch. It adds the one remaining low-priority Note that earns its keep and makes a conscious call on the rest, so the issue's "decide consciously rather than by omiss...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/pull/130/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fpull%2F130%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fpull%2F130%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/pull/130/files
Reloadhttps://github.com/purescript-lua/purescript-lua/pull/130/files
Reloadhttps://github.com/purescript-lua/purescript-lua/pull/130/files
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2Fnew%2Fchoose
Unisayhttps://github.com/Unisay
mainhttps://github.com/purescript-lua/purescript-lua/tree/main
issue-44/notes-low-itemshttps://github.com/purescript-lua/purescript-lua/tree/issue-44/notes-low-items
Conversation 1 https://github.com/purescript-lua/purescript-lua/pull/130
Commits 1 https://github.com/purescript-lua/purescript-lua/pull/130/commits
Checks 2 https://github.com/purescript-lua/purescript-lua/pull/130/checks
Files changed https://github.com/purescript-lua/purescript-lua/pull/130/files
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/130/files
docs: close out the GHC-style Note pass (#44) https://github.com/purescript-lua/purescript-lua/pull/130/files#top
Show all changes 1 commit https://github.com/purescript-lua/purescript-lua/pull/130/files
154152d docs: close out the GHC-style Note pass (#44) Unisay Jun 25, 2026 https://github.com/purescript-lua/purescript-lua/pull/130/commits/154152de409134f922fa16d0a3ab5ab06b877bb2
Clear filters https://github.com/purescript-lua/purescript-lua/pull/130/files
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/130/files
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/130/files
20260625_203341_unisay_notes_low_items.md https://github.com/purescript-lua/purescript-lua/pull/130/files#diff-74064d6e5deaa0d431d4fccca81010ed8bb8da1f3603e3c694e128f9506183d9
Optimizer.hs https://github.com/purescript-lua/purescript-lua/pull/130/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
changelog.d/20260625_203341_unisay_notes_low_items.mdhttps://github.com/purescript-lua/purescript-lua/pull/130/files#diff-74064d6e5deaa0d431d4fccca81010ed8bb8da1f3603e3c694e128f9506183d9
View file https://github.com/purescript-lua/purescript-lua/blob/154152de409134f922fa16d0a3ab5ab06b877bb2/changelog.d/20260625_203341_unisay_notes_low_items.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/purescript-lua/purescript-lua/pull/130/{{ revealButtonHref }}
lib/Language/PureScript/Backend/IR/Optimizer.hshttps://github.com/purescript-lua/purescript-lua/pull/130/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
View file https://github.com/purescript-lua/purescript-lua/blob/154152de409134f922fa16d0a3ab5ab06b877bb2/lib/Language/PureScript/Backend/IR/Optimizer.hs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/purescript-lua/purescript-lua/pull/130/{{ revealButtonHref }}
https://github.com/purescript-lua/purescript-lua/pull/130/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
https://github.com/purescript-lua/purescript-lua/pull/130/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
https://github.com/purescript-lua/purescript-lua/pull/130/files#diff-487ead9d0ca9c3e6f68e23c604b0ae9070089e0dd0f7d214cdce5fbc878f3315
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/130/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.