René's URL Explorer Experiment


Title: address copilot review on #111: robust luacParse + looser local-count check by Unisay · Pull Request #112 · purescript-lua/purescript-lua · GitHub

Open Graph Title: address copilot review on #111: robust luacParse + looser local-count check by Unisay · Pull Request #112 · purescript-lua/purescript-lua

X Title: address copilot review on #111: robust luacParse + looser local-count check by Unisay · Pull Request #112 · purescript-lua/purescript-lua

Description: Follow-up to #111, applying both Copilot review comments on the parser-nesting reproduction test. Spec.hs:207 — the unflattened local-count assertion was == 1, which is brittle to unrelated codegen changes (e.g. if the emitter later adds a module/runtime-setup local). Relaxed to < 50: still far below Lua's 200-locals cap (so it corroborates "the crash isn't the locals cap"), but robust. The real cause-discriminator is unchanged — luac reports too many syntax levels, a distinct message from its locals error. Spec.hs:250 — luacParse wrote to a hard-coded /tmp/... path and ran luac via shell string concatenation. Switched to withSystemTempFile (unique, auto-cleaned) + proc "luac" ["-p", file] (argv list, no shell), so it is portable and safe against paths with spaces and concurrent test runs. Test-only; the assertion still passes and still pins the failure to parser nesting.

Open Graph Description: Follow-up to #111, applying both Copilot review comments on the parser-nesting reproduction test. Spec.hs:207 — the unflattened local-count assertion was == 1, which is brittle to unrelated codege...

X Description: Follow-up to #111, applying both Copilot review comments on the parser-nesting reproduction test. Spec.hs:207 — the unflattened local-count assertion was == 1, which is brittle to unrelated codege...

Opengraph URL: https://github.com/purescript-lua/purescript-lua/pull/112

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b7da2322-0886-ed78-ecf7-c6667096a879
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D72:27D3AD:9AC7E2:C66218:6B00EF8C
html-safe-nonce42078ea043190a732a0a0cfd081412bd12f2847f3244bf0be57c7dde233d5715
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDcyOjI3RDNBRDo5QUM3RTI6QzY2MjE4OjZCMDBFRjhDIiwidmlzaXRvcl9pZCI6IjgyMDA5NTk4MTExODYxMjY3MzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac892b09d4b40b271658358bfcf4362f32fbc7a025d48b14b3b350318472799fe1
hovercard-subject-tagpull_request:3919296288
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/purescript-lua/purescript-lua/pull/112/files
twitter:imagehttps://avatars.githubusercontent.com/u/1009751?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1009751?s=400&v=4
og:image:altFollow-up to #111, applying both Copilot review comments on the parser-nesting reproduction test. Spec.hs:207 — the unflattened local-count assertion was == 1, which is brittle to unrelated codege...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/pull/112/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fpull%2F112%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fpull%2F112%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/pull/112/files
Reloadhttps://github.com/purescript-lua/purescript-lua/pull/112/files
Reloadhttps://github.com/purescript-lua/purescript-lua/pull/112/files
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2Fnew%2Fchoose
Unisayhttps://github.com/Unisay
mainhttps://github.com/purescript-lua/purescript-lua/tree/main
issue-108/repro-test-review-fixeshttps://github.com/purescript-lua/purescript-lua/tree/issue-108/repro-test-review-fixes
Conversation 6 https://github.com/purescript-lua/purescript-lua/pull/112
Commits 2 https://github.com/purescript-lua/purescript-lua/pull/112/commits
Checks 2 https://github.com/purescript-lua/purescript-lua/pull/112/checks
Files changed https://github.com/purescript-lua/purescript-lua/pull/112/files
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/112/files
address copilot review on #111: robust luacParse + looser local-count check https://github.com/purescript-lua/purescript-lua/pull/112/files#top
Show all changes 2 commits https://github.com/purescript-lua/purescript-lua/pull/112/files
63327a3 address copilot review on PR #111 Unisay Jun 23, 2026 https://github.com/purescript-lua/purescript-lua/pull/112/commits/63327a3b3f1e63b1c8dc1cf762455657afa18928
5c07149 address copilot review on PR #112 Unisay Jun 23, 2026 https://github.com/purescript-lua/purescript-lua/pull/112/commits/5c07149547af6077c4a623e4650285b0a13a2df0
Clear filters https://github.com/purescript-lua/purescript-lua/pull/112/files
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/112/files
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/112/files
test/Language/PureScript/Backend/Lua/Golden/Spec.hshttps://github.com/purescript-lua/purescript-lua/pull/112/files#diff-e10bc6586bdc2afb3eed89cc8935f6ff0059d32a82668123ce53808a6046c019
View file https://github.com/purescript-lua/purescript-lua/blob/5c07149547af6077c4a623e4650285b0a13a2df0/test/Language/PureScript/Backend/Lua/Golden/Spec.hs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/purescript-lua/purescript-lua/pull/112/{{ revealButtonHref }}
https://github.com/purescript-lua/purescript-lua/pull/112/files#diff-e10bc6586bdc2afb3eed89cc8935f6ff0059d32a82668123ce53808a6046c019
https://github.com/purescript-lua/purescript-lua/pull/112/files#diff-e10bc6586bdc2afb3eed89cc8935f6ff0059d32a82668123ce53808a6046c019
https://github.com/purescript-lua/purescript-lua/pull/112/files#diff-e10bc6586bdc2afb3eed89cc8935f6ff0059d32a82668123ce53808a6046c019
https://github.com/purescript-lua/purescript-lua/pull/112/files#diff-e10bc6586bdc2afb3eed89cc8935f6ff0059d32a82668123ce53808a6046c019
https://github.com/purescript-lua/purescript-lua/pull/112/files#diff-e10bc6586bdc2afb3eed89cc8935f6ff0059d32a82668123ce53808a6046c019
https://github.com/purescript-lua/purescript-lua/pull/112/files#diff-e10bc6586bdc2afb3eed89cc8935f6ff0059d32a82668123ce53808a6046c019
https://github.com/purescript-lua/purescript-lua/pull/112/files#diff-e10bc6586bdc2afb3eed89cc8935f6ff0059d32a82668123ce53808a6046c019
https://github.com/purescript-lua/purescript-lua/pull/112/files#diff-e10bc6586bdc2afb3eed89cc8935f6ff0059d32a82668123ce53808a6046c019
Please reload this pagehttps://github.com/purescript-lua/purescript-lua/pull/112/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.