Title: [fork-ffi] integers: shl / shr / zshr — All three use `math.pow`/division and do not implement JS 32-bit… · Issue #91 · purescript-lua/purescript-lua · GitHub
Open Graph Title: [fork-ffi] integers: shl / shr / zshr — All three use `math.pow`/division and do not implement JS 32-bit… · Issue #91 · purescript-lua/purescript-lua
X Title: [fork-ffi] integers: shl / shr / zshr — All three use `math.pow`/division and do not implement JS 32-bit… · Issue #91 · purescript-lua/purescript-lua
Description: Package: purescript-lua-integers File: src/Data/Int/Bits.lua Function: shl / shr / zshr Class: semantics Severity: medium All three use math.pow/division and do not implement JS 32-bit shift semantics. (1) shl: a * math.pow(2, b) returns...
Open Graph Description: Package: purescript-lua-integers File: src/Data/Int/Bits.lua Function: shl / shr / zshr Class: semantics Severity: medium All three use math.pow/division and do not implement JS 32-bit shift semant...
X Description: Package: purescript-lua-integers File: src/Data/Int/Bits.lua Function: shl / shr / zshr Class: semantics Severity: medium All three use math.pow/division and do not implement JS 32-bit shift semant...
Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/91
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[fork-ffi] integers: shl / shr / zshr — All three use `math.pow`/division and do not implement JS 32-bit…","articleBody":"**Package:** purescript-lua-integers \n**File:** `src/Data/Int/Bits.lua` \n**Function:** `shl / shr / zshr` \n**Class:** semantics **Severity:** medium\n\nAll three use `math.pow`/division and do not implement JS 32-bit shift semantics. (1) shl: `a * math.pow(2, b)` returns a float and is neither masked to a 5-bit shift count nor wrapped to Int32, so `shl 1 31` gives 2147483648.0 (JS `1 \u003c\u003c 31` == -2147483648) and `shl 1 32` gives 4294967296 (JS `1 \u003c\u003c 32` == 1, count taken mod 32). (2) zshr is identical to shr (`math.floor(a / 2^b)`), but JS `>>>` is the UNSIGNED right shift: `zshr (-8) 1` must be 2147483644, while the Lua returns -4. (3) shr on negative a happens to match arithmetic shift for the cases tried, but neither masks the shift count nor stays in Int32.\n\n**Current (Lua):**\n```lua\nshl = (function(a) return function(b) return a * math.pow(2, b) end end),\nshr = (function(a) return function(b) return math.floor(a / math.pow(2, b)) end end),\nzshr = (function(a) return function(b) return math.floor(a / math.pow(2, b)) end end),\n```\n\n**Expected:** JS 32-bit shifts: shift count taken mod 32, result wrapped to signed Int32 for shl/shr; zshr operates on the unsigned 32-bit value (zshr (-8) 1 == 2147483644). shl 1 31 == -2147483648, shl 1 32 == 1.\n\n**Proposed fix:**\n```lua\nImplement via an unsigned-32-bit helper: for shl, compute `(a * 2^(b % 32)) % 0x100000000` then reinterpret as signed Int32; for zshr, first map a to unsigned (a + 0x100000000 if a \u003c 0) then `math.floor(u / 2^(b % 32))`; for shr, do an arithmetic shift on the signed value with count masked to 5 bits. A shared signed/unsigned-32 conversion pair removes the duplication.\n```\n\n_Found by the FFI audit; reproduced under Lua 5.1._","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-06-15T11:24:11Z","url":"https://github.com/purescript-lua/purescript-lua/issues/91"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:19d6e759-5eff-7989-8afe-e0e5cc1ea2d0 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9626:1DB641:985BDB:C6401B:6B00DFAB |
| html-safe-nonce | a14bb6e313c27fc2501d7b28711a9e561232fb2ab7fbc53141fb1ef784b8398a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjI2OjFEQjY0MTo5ODVCREI6QzY0MDFCOjZCMDBERkFCIiwidmlzaXRvcl9pZCI6IjYzMzQ4MDA2OTkwNTQ0MDY4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8da3a431322168fc00ed605664993488ba2f852fc6d4a37763a8be3bb4af570f |
| hovercard-subject-tag | issue:4664608593 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/91/issue_layout |
| twitter:image | https://opengraph.githubassets.com/25d3c6810e67c3d49e1fd13afd02bec53f622d23678423faac52da643b3e9e4f/purescript-lua/purescript-lua/issues/91 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/25d3c6810e67c3d49e1fd13afd02bec53f622d23678423faac52da643b3e9e4f/purescript-lua/purescript-lua/issues/91 |
| og:image:alt | Package: purescript-lua-integers File: src/Data/Int/Bits.lua Function: shl / shr / zshr Class: semantics Severity: medium All three use math.pow/division and do not implement JS 32-bit shift semant... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Unisay |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-preview |
| go-import | github.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git |
| octolytics-dimension-user_id | 131581790 |
| octolytics-dimension-user_login | purescript-lua |
| octolytics-dimension-repository_id | 587200487 |
| octolytics-dimension-repository_nwo | purescript-lua/purescript-lua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 587200487 |
| octolytics-dimension-repository_network_root_nwo | purescript-lua/purescript-lua |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width