René's URL Explorer Experiment


Title: [fork-ffi] integers: fromStringAsImpl — Two divergences from the upstream JS (which validates with a… · Issue #86 · purescript-lua/purescript-lua · GitHub

Open Graph Title: [fork-ffi] integers: fromStringAsImpl — Two divergences from the upstream JS (which validates with a… · Issue #86 · purescript-lua/purescript-lua

X Title: [fork-ffi] integers: fromStringAsImpl — Two divergences from the upstream JS (which validates with a… · Issue #86 · purescript-lua/purescript-lua

Description: Package: purescript-lua-integers File: src/Data/Int.lua Function: fromStringAsImpl Class: semantics Severity: high Two divergences from the upstream JS (which validates with a base-specific regex and then checks (i | 0) === i). (1) Lua t...

Open Graph Description: Package: purescript-lua-integers File: src/Data/Int.lua Function: fromStringAsImpl Class: semantics Severity: high Two divergences from the upstream JS (which validates with a base-specific regex a...

X Description: Package: purescript-lua-integers File: src/Data/Int.lua Function: fromStringAsImpl Class: semantics Severity: high Two divergences from the upstream JS (which validates with a base-specific regex a...

Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/86

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[fork-ffi] integers: fromStringAsImpl — Two divergences from the upstream JS (which validates with a…","articleBody":"**Package:** purescript-lua-integers  \n**File:** `src/Data/Int.lua`  \n**Function:** `fromStringAsImpl`  \n**Class:** semantics  **Severity:** high\n\nTwo divergences from the upstream JS (which validates with a base-specific regex and then checks `(i | 0) === i`). (1) Lua `tonumber(s, radix)` accepts fractional strings and out-of-range integers: `tonumber(\"0.1\",10)` -> 0.1 and `tonumber(\"2147483648\",10)` -> 2147483648, so `fromString \"0.1\"` returns Just 0.1 and `fromString \"2147483648\"` returns Just 2147483648, whereas the tests require Nothing for both (Test/Data/Int.purs lines 73-78). (2) For any base other than 10, Lua 5.1 `tonumber` treats a leading '-' as an UNSIGNED 64-bit wraparound rather than a negation: `tonumber(\"-ef\",16)` -> 1.84e19 and `tonumber(\"-80000000\",16)` -> 1.84e19. The tests require `fromStringAs hexadecimal \"-ef\" == Just (-239)` and `fromStringAs hexadecimal \"-80000000\" == Just (-2147483648)` (lines 91, 93); the Lua returns a huge bogus positive Just.\n\n**Current (Lua):**\n```lua\nfromStringAsImpl = (function(just)\n  return function(nothing)\n    return function(radix)\n      return function(s)\n        local n = tonumber(s, radix)\n        if n == nil then return nothing end\n        return just(n)\n      end\n    end\n  end\nend),\n```\n\n**Expected:** Reject non-integer strings and out-of-Int32-range values (return Nothing); parse a leading '+' or '-' sign correctly in every base, so `fromStringAs hexadecimal \"-ef\" == Just (-239)` and `fromStringAs hexadecimal \"-80000000\" == Just (-2147483648)`.\n\n**Proposed fix:**\n```lua\nreturn function(s)\n  local sign, body = 1, s\n  local c = s:sub(1,1)\n  if c == '-' then sign, body = -1, s:sub(2)\n  elseif c == '+' then body = s:sub(2) end\n  local n = tonumber(body, radix)\n  if n == nil then return nothing end\n  -- reject fractional results from base-10 parses\n  if math.modf(n) ~= n then return nothing end\n  n = sign * n\n  if n \u003c -2147483648 or n > 2147483647 then return nothing end\n  return just(n)\nend\n-- (Also validate that every digit is legal for the base, mirroring the JS regex, since tonumber tolerates surrounding whitespace; trim/validate s before parsing.)\n```\n\n_Found by the FFI audit; reproduced under Lua 5.1._","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-06-15T11:24:06Z","url":"https://github.com/purescript-lua/purescript-lua/issues/86"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:665f545b-0d0a-cbc3-98a3-3177eb741455
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id95DC:311640:637F1C:801D91:6B00DFA8
html-safe-nonce4aa54a713e141b902f509e30838b338894212cec7f50fefad71080c92de03aa1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NURDOjMxMTY0MDo2MzdGMUM6ODAxRDkxOjZCMDBERkE4IiwidmlzaXRvcl9pZCI6Ijg4ODgyNDY2MDI1MTU0MDY3NjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7a446021b83e3fc62768f1200f7a25d18f96c0ef59638fe0af676c98e88fe8fd
hovercard-subject-tagissue:4664607925
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/86/issue_layout
twitter:imagehttps://opengraph.githubassets.com/aae17ce04eb2dd432edba4efb5806d1b7ad2881dc993e13f14673fe4d6decb33/purescript-lua/purescript-lua/issues/86
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/aae17ce04eb2dd432edba4efb5806d1b7ad2881dc993e13f14673fe4d6decb33/purescript-lua/purescript-lua/issues/86
og:image:altPackage: purescript-lua-integers File: src/Data/Int.lua Function: fromStringAsImpl Class: semantics Severity: high Two divergences from the upstream JS (which validates with a base-specific regex a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameUnisay
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-preview
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/issues/86#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F86
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F86
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/86
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/86
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/86
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
https://github.com/purescript-lua/purescript-lua
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/86
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/86
[fork-ffi] integers: fromStringAsImpl — Two divergences from the upstream JS (which validates with a…https://github.com/purescript-lua/purescript-lua/issues/86#top
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jun 15, 2026https://github.com/purescript-lua/purescript-lua/issues/86#issue-4664607925
Unisayhttps://github.com/Unisay
completedhttps://github.com/purescript-lua/purescript-lua/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
be0f106https://github.com/purescript-lua/purescript-lua-integers/commit/be0f1060bba2d29df3f84b941162e0913d411f70
on Jun 15, 2026https://github.com/purescript-lua/purescript-lua/issues/86#event-26756921247
Sign up for freehttps://github.com/signup?return_to=https://github.com/purescript-lua/purescript-lua/issues/86
Sign in to commenthttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/86
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.