Title: [fork-ffi] integers: fromStringAsImpl — Two divergences from the upstream JS (which validates with a… · Issue #86 · purescript-lua/purescript-lua · GitHub
Open Graph Title: [fork-ffi] integers: fromStringAsImpl — Two divergences from the upstream JS (which validates with a… · Issue #86 · purescript-lua/purescript-lua
X Title: [fork-ffi] integers: fromStringAsImpl — Two divergences from the upstream JS (which validates with a… · Issue #86 · purescript-lua/purescript-lua
Description: Package: purescript-lua-integers File: src/Data/Int.lua Function: fromStringAsImpl Class: semantics Severity: high Two divergences from the upstream JS (which validates with a base-specific regex and then checks (i | 0) === i). (1) Lua t...
Open Graph Description: Package: purescript-lua-integers File: src/Data/Int.lua Function: fromStringAsImpl Class: semantics Severity: high Two divergences from the upstream JS (which validates with a base-specific regex a...
X Description: Package: purescript-lua-integers File: src/Data/Int.lua Function: fromStringAsImpl Class: semantics Severity: high Two divergences from the upstream JS (which validates with a base-specific regex a...
Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/86
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[fork-ffi] integers: fromStringAsImpl — Two divergences from the upstream JS (which validates with a…","articleBody":"**Package:** purescript-lua-integers \n**File:** `src/Data/Int.lua` \n**Function:** `fromStringAsImpl` \n**Class:** semantics **Severity:** high\n\nTwo divergences from the upstream JS (which validates with a base-specific regex and then checks `(i | 0) === i`). (1) Lua `tonumber(s, radix)` accepts fractional strings and out-of-range integers: `tonumber(\"0.1\",10)` -> 0.1 and `tonumber(\"2147483648\",10)` -> 2147483648, so `fromString \"0.1\"` returns Just 0.1 and `fromString \"2147483648\"` returns Just 2147483648, whereas the tests require Nothing for both (Test/Data/Int.purs lines 73-78). (2) For any base other than 10, Lua 5.1 `tonumber` treats a leading '-' as an UNSIGNED 64-bit wraparound rather than a negation: `tonumber(\"-ef\",16)` -> 1.84e19 and `tonumber(\"-80000000\",16)` -> 1.84e19. The tests require `fromStringAs hexadecimal \"-ef\" == Just (-239)` and `fromStringAs hexadecimal \"-80000000\" == Just (-2147483648)` (lines 91, 93); the Lua returns a huge bogus positive Just.\n\n**Current (Lua):**\n```lua\nfromStringAsImpl = (function(just)\n return function(nothing)\n return function(radix)\n return function(s)\n local n = tonumber(s, radix)\n if n == nil then return nothing end\n return just(n)\n end\n end\n end\nend),\n```\n\n**Expected:** Reject non-integer strings and out-of-Int32-range values (return Nothing); parse a leading '+' or '-' sign correctly in every base, so `fromStringAs hexadecimal \"-ef\" == Just (-239)` and `fromStringAs hexadecimal \"-80000000\" == Just (-2147483648)`.\n\n**Proposed fix:**\n```lua\nreturn function(s)\n local sign, body = 1, s\n local c = s:sub(1,1)\n if c == '-' then sign, body = -1, s:sub(2)\n elseif c == '+' then body = s:sub(2) end\n local n = tonumber(body, radix)\n if n == nil then return nothing end\n -- reject fractional results from base-10 parses\n if math.modf(n) ~= n then return nothing end\n n = sign * n\n if n \u003c -2147483648 or n > 2147483647 then return nothing end\n return just(n)\nend\n-- (Also validate that every digit is legal for the base, mirroring the JS regex, since tonumber tolerates surrounding whitespace; trim/validate s before parsing.)\n```\n\n_Found by the FFI audit; reproduced under Lua 5.1._","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-06-15T11:24:06Z","url":"https://github.com/purescript-lua/purescript-lua/issues/86"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:665f545b-0d0a-cbc3-98a3-3177eb741455 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 95DC:311640:637F1C:801D91:6B00DFA8 |
| html-safe-nonce | 4aa54a713e141b902f509e30838b338894212cec7f50fefad71080c92de03aa1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NURDOjMxMTY0MDo2MzdGMUM6ODAxRDkxOjZCMDBERkE4IiwidmlzaXRvcl9pZCI6Ijg4ODgyNDY2MDI1MTU0MDY3NjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7a446021b83e3fc62768f1200f7a25d18f96c0ef59638fe0af676c98e88fe8fd |
| hovercard-subject-tag | issue:4664607925 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/86/issue_layout |
| twitter:image | https://opengraph.githubassets.com/aae17ce04eb2dd432edba4efb5806d1b7ad2881dc993e13f14673fe4d6decb33/purescript-lua/purescript-lua/issues/86 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/aae17ce04eb2dd432edba4efb5806d1b7ad2881dc993e13f14673fe4d6decb33/purescript-lua/purescript-lua/issues/86 |
| og:image:alt | Package: purescript-lua-integers File: src/Data/Int.lua Function: fromStringAsImpl Class: semantics Severity: high Two divergences from the upstream JS (which validates with a base-specific regex a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Unisay |
| hostname | github.com |
| expected-hostname | github.com |
| None | 27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14 |
| turbo-cache-control | no-preview |
| go-import | github.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git |
| octolytics-dimension-user_id | 131581790 |
| octolytics-dimension-user_login | purescript-lua |
| octolytics-dimension-repository_id | 587200487 |
| octolytics-dimension-repository_nwo | purescript-lua/purescript-lua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 587200487 |
| octolytics-dimension-repository_network_root_nwo | purescript-lua/purescript-lua |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 624179fb8b88d26ba5bba08894eb60a1c5a1d93d |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width