Title: [fork-ffi] effect: forE — PureScript/JS forE lo hi f iterates over [lo, hi) — lo inclusive, hi… · Issue #78 · purescript-lua/purescript-lua · GitHub
Open Graph Title: [fork-ffi] effect: forE — PureScript/JS forE lo hi f iterates over [lo, hi) — lo inclusive, hi… · Issue #78 · purescript-lua/purescript-lua
X Title: [fork-ffi] effect: forE — PureScript/JS forE lo hi f iterates over [lo, hi) — lo inclusive, hi… · Issue #78 · purescript-lua/purescript-lua
Description: Package: purescript-lua-effect File: src/Effect.lua Function: forE Class: off-by-one Severity: high PureScript/JS forE lo hi f iterates over [lo, hi) — lo inclusive, hi EXCLUSIVE (the Effect.purs doc comment states this explicitly, and t...
Open Graph Description: Package: purescript-lua-effect File: src/Effect.lua Function: forE Class: off-by-one Severity: high PureScript/JS forE lo hi f iterates over [lo, hi) — lo inclusive, hi EXCLUSIVE (the Effect.purs d...
X Description: Package: purescript-lua-effect File: src/Effect.lua Function: forE Class: off-by-one Severity: high PureScript/JS forE lo hi f iterates over [lo, hi) — lo inclusive, hi EXCLUSIVE (the Effect.purs d...
Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/78
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[fork-ffi] effect: forE — PureScript/JS forE lo hi f iterates over [lo, hi) — lo inclusive, hi…","articleBody":"**Package:** purescript-lua-effect \n**File:** `src/Effect.lua` \n**Function:** `forE` \n**Class:** off-by-one **Severity:** high\n\nPureScript/JS forE lo hi f iterates over [lo, hi) — lo inclusive, hi EXCLUSIVE (the Effect.purs doc comment states this explicitly, and the JS FFI uses `for (var i = lo; i \u003c hi; i++)`). The Lua port uses a numeric for-loop `for i = lo, hi do`, whose upper bound is INCLUSIVE in Lua. This runs one extra iteration at i = hi, so f is invoked (hi - lo + 1) times instead of (hi - lo). It also breaks the empty-range contract: forE n n should run zero times but the Lua runs once at i = n. Verified under Lua 5.1: `forE 0 3` calls f at i=0,1,2,3 (count 4, JS gives 3); `forE 2 2` runs once (JS runs zero times).\n\n**Current (Lua):**\n```lua\nforE = (function(lo) return function(hi) return function(f) return function() for i = lo, hi do f(i)() end end end end end)\n```\n\n**Expected:** JS: for (var i = lo; i \u003c hi; i++) { f(i)(); } — i ranges over lo..hi-1; forE lo hi runs exactly max(0, hi - lo) times.\n\n**Proposed fix:**\n```lua\nUse an exclusive upper bound: `for i = lo, hi - 1 do f(i)() end`. Verified under Lua 5.1: `for i = 0, 3-1` runs 3 times; `for i = 5, 5-1` runs 0 times (Lua's for skips when start > stop), matching the JS empty-range behaviour.\n```\n\n_Found by the FFI audit; reproduced under Lua 5.1._","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-06-15T11:23:57Z","url":"https://github.com/purescript-lua/purescript-lua/issues/78"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:20fcf341-3cb9-e8a8-6e3f-dd2af943f35b |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BA58:1DB641:8A6C5A:B491E5:6B00DB5F |
| html-safe-nonce | 355b6b2c36ea4f430d7ac4fa9adbffea8e3eed74c03d2cfa6250baf47f0ea730 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTU4OjFEQjY0MTo4QTZDNUE6QjQ5MUU1OjZCMDBEQjVGIiwidmlzaXRvcl9pZCI6IjQ3ODUzMzc3NDk5MzI2NjE1OTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 76baeca5c8be1c4f85662a3e38ac46552b7807cfd52bb781bf21dfb98e3c0d7d |
| hovercard-subject-tag | issue:4664606915 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/78/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9def4d49524a5973d5029f38c2afda3f8625fcdd45e1ce354c25b2b644ecdd2b/purescript-lua/purescript-lua/issues/78 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9def4d49524a5973d5029f38c2afda3f8625fcdd45e1ce354c25b2b644ecdd2b/purescript-lua/purescript-lua/issues/78 |
| og:image:alt | Package: purescript-lua-effect File: src/Effect.lua Function: forE Class: off-by-one Severity: high PureScript/JS forE lo hi f iterates over [lo, hi) — lo inclusive, hi EXCLUSIVE (the Effect.purs d... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Unisay |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-preview |
| go-import | github.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git |
| octolytics-dimension-user_id | 131581790 |
| octolytics-dimension-user_login | purescript-lua |
| octolytics-dimension-repository_id | 587200487 |
| octolytics-dimension-repository_nwo | purescript-lua/purescript-lua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 587200487 |
| octolytics-dimension-repository_network_root_nwo | purescript-lua/purescript-lua |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width