Title: [fork-ffi] arrays: spliceImpl — JS `xs.splice(i, howMany, ...bs)` removes `howMany` elements at index… · Issue #75 · purescript-lua/purescript-lua · GitHub
Open Graph Title: [fork-ffi] arrays: spliceImpl — JS `xs.splice(i, howMany, ...bs)` removes `howMany` elements at index… · Issue #75 · purescript-lua/purescript-lua
X Title: [fork-ffi] arrays: spliceImpl — JS `xs.splice(i, howMany, ...bs)` removes `howMany` elements at index… · Issue #75 · purescript-lua/purescript-lua
Description: Package: purescript-lua-arrays File: src/Data/Array/ST.lua Function: spliceImpl Class: semantics Severity: high JS xs.splice(i, howMany, ...bs) removes howMany elements at index i, inserts bs in their place (in-place mutation of xs, with...
Open Graph Description: Package: purescript-lua-arrays File: src/Data/Array/ST.lua Function: spliceImpl Class: semantics Severity: high JS xs.splice(i, howMany, ...bs) removes howMany elements at index i, inserts bs in th...
X Description: Package: purescript-lua-arrays File: src/Data/Array/ST.lua Function: spliceImpl Class: semantics Severity: high JS xs.splice(i, howMany, ...bs) removes howMany elements at index i, inserts bs in th...
Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/75
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[fork-ffi] arrays: spliceImpl — JS `xs.splice(i, howMany, ...bs)` removes `howMany` elements at index…","articleBody":"**Package:** purescript-lua-arrays \n**File:** `src/Data/Array/ST.lua` \n**Function:** `spliceImpl` \n**Class:** semantics **Severity:** high\n\nJS `xs.splice(i, howMany, ...bs)` removes `howMany` elements at index i, inserts `bs` in their place (in-place mutation of xs, with the array shrinking/growing as needed), and RETURNS the array of removed elements. The Lua version only does `move(xs, i + howMany + 1, #xs, i + #bs + 1, xs)`: it shifts the tail but never inserts the `bs` values, never shrinks the array when #bs \u003c howMany (leaving stale duplicated trailing elements), and returns the whole mutated `xs` instead of the removed slice. Confirmed under Lua 5.1: spliceImpl(1, 2, {99}, {10,20,30,40,50}) returned {10,20,40,50,50} (len 5) and the same as the 'removed' value, instead of mutating xs to {10,99,40,50} and returning {20,30}. With insert>remove, spliceImpl(1,1,{8,9},{1,2,3}) gave {1,2,3,3} instead of {1,8,9,3}.\n\n**Current (Lua):**\n```lua\nspliceImpl = (function(i, howMany, bs, xs) return move(xs, i + howMany + 1, #xs, i + #bs + 1, xs) end)\n```\n\n**Expected:** Mutate xs by deleting howMany elements at 0-based index i and inserting bs there; return a new array of the removed elements. spliceImpl(1,2,{99},{10,20,30,40,50}) => xs={10,99,40,50}, returns {20,30}.\n\n**Proposed fix:**\n```lua\nImplement full splice semantics, collecting removed elements, shifting the tail by (#bs - howMany), trimming surplus slots to nil when shrinking, then writing bs into the gap:\n spliceImpl = (function(i, howMany, bs, xs)\n local n = #xs\n local removed = {}\n for k = 1, howMany do removed[k] = xs[i + k] end\n local nb, delta = #bs, #bs - howMany\n if delta > 0 then\n for k = n, i + howMany + 1, -1 do xs[k + delta] = xs[k] end\n elseif delta \u003c 0 then\n for k = i + howMany + 1, n do xs[k + delta] = xs[k] end\n for k = n + delta + 1, n do xs[k] = nil end\n end\n for k = 1, nb do xs[i + k] = bs[k] end\n return removed\n end)\nVerified under Lua 5.1 across remove>insert, insert>remove, and no-op cases.\n```\n\n_Found by the FFI audit; reproduced under Lua 5.1._","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-06-15T11:23:54Z","url":"https://github.com/purescript-lua/purescript-lua/issues/75"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6d3882a2-280f-3939-f643-3d4d1baa6027 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9622:2652DC:9712BF:C50762:6B00DFAB |
| html-safe-nonce | 2f5b7cc91fb1edf5272bad15fb959677b115a642baa913d8bb03ff6cdc25d0a3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjIyOjI2NTJEQzo5NzEyQkY6QzUwNzYyOjZCMDBERkFCIiwidmlzaXRvcl9pZCI6IjQyNjc3MDI2MjYzNTY4NzkyNzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | cdda075786d2f78ef8f9fda7a3e8806ff55ea8c75a527a3aece5d109e0687849 |
| hovercard-subject-tag | issue:4664606423 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/75/issue_layout |
| twitter:image | https://opengraph.githubassets.com/a8ffba588154338b11ef1747499e1326c02bf61da60b8fd30ca536f97b158448/purescript-lua/purescript-lua/issues/75 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a8ffba588154338b11ef1747499e1326c02bf61da60b8fd30ca536f97b158448/purescript-lua/purescript-lua/issues/75 |
| og:image:alt | Package: purescript-lua-arrays File: src/Data/Array/ST.lua Function: spliceImpl Class: semantics Severity: high JS xs.splice(i, howMany, ...bs) removes howMany elements at index i, inserts bs in th... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Unisay |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-preview |
| go-import | github.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git |
| octolytics-dimension-user_id | 131581790 |
| octolytics-dimension-user_login | purescript-lua |
| octolytics-dimension-repository_id | 587200487 |
| octolytics-dimension-repository_nwo | purescript-lua/purescript-lua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 587200487 |
| octolytics-dimension-repository_network_root_nwo | purescript-lua/purescript-lua |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width