René's URL Explorer Experiment


Title: [fork-ffi] arrays: traverse1Impl — Faulty JS->Lua translation of the `new ConsCell(...)` / `new… · Issue #73 · purescript-lua/purescript-lua · GitHub

Open Graph Title: [fork-ffi] arrays: traverse1Impl — Faulty JS->Lua translation of the `new ConsCell(...)` / `new… · Issue #73 · purescript-lua/purescript-lua

X Title: [fork-ffi] arrays: traverse1Impl — Faulty JS->Lua translation of the `new ConsCell(...)` / `new… · Issue #73 · purescript-lua/purescript-lua

Description: Package: purescript-lua-arrays File: src/Data/Array/NonEmpty/Internal.lua Function: traverse1Impl Class: semantics Severity: high Faulty JS->Lua translation of the new ConsCell(...) / new Cont(...) constructor pattern. In JS these are in...

Open Graph Description: Package: purescript-lua-arrays File: src/Data/Array/NonEmpty/Internal.lua Function: traverse1Impl Class: semantics Severity: high Faulty JS->Lua translation of the new ConsCell(...) / new Cont(...)...

X Description: Package: purescript-lua-arrays File: src/Data/Array/NonEmpty/Internal.lua Function: traverse1Impl Class: semantics Severity: high Faulty JS->Lua translation of the new ConsCell(...) / new Cont(....

Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/73

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[fork-ffi] arrays: traverse1Impl — Faulty JS->Lua translation of the `new ConsCell(...)` / `new…","articleBody":"**Package:** purescript-lua-arrays  \n**File:** `src/Data/Array/NonEmpty/Internal.lua`  \n**Function:** `traverse1Impl`  \n**Class:** semantics  **Severity:** high\n\nFaulty JS->Lua translation of the `new ConsCell(...)` / `new Cont(...)` constructor pattern. In JS these are invoked with `new`, so each returns a freshly-allocated object. The Lua port rewrote them as functions taking an explicit `this` first parameter (`Cont(this, fn)`, `ConsCell(this, head, tail)`) that mutate `this` and return nil, but the call sites still call them with the *data* arguments only -- e.g. `finalCell(head)` calls `ConsCell(head, emptyList)`, so `this` = the head element and `this.head = ...` errors. `consList(x)(xs)` calls `ConsCell(x, xs)` and `go` returns `Cont(function() ... end)`, all likewise broken. The function errors on its very first real invocation. Confirmed under Lua 5.1: `attempt to index local 'this' (a number value)` at the `this.head = head` line. This breaks `traverse1`/`sequence1` for NonEmptyArray entirely.\n\n**Current (Lua):**\n```lua\nlocal function Cont(this, fn) this.fn = fn end\nlocal function ConsCell(this, head, tail)\n  this.head = head\n  this.tail = tail\nend\nlocal function finalCell(head) return ConsCell(head, emptyList) end\nlocal function consList(x) return function(xs) return ConsCell(x, xs) end end\n...\nreturn Cont(function() return go(buildFrom(last, acc), currentLen - 1, xs) end)\n```\n\n**Expected:** JS uses `new`, so the constructors allocate and return objects: `finalCell(h)` => {head=h, tail=emptyList}; `consList(x)(xs)` => {head=x, tail=xs}; `go` returns a Cont wrapper {fn=...}. `traverse1Impl(apply,map,f)(array)` must thread these cells through and produce the reversed-then-listToArray result. With Identity-style apply/map and f=(*10), `traverse1Impl(...)({1,2,3})` must yield {10,20,30}.\n\n**Proposed fix:**\n```lua\nMake the constructors return tables instead of mutating a phantom `this`:\n  local function Cont(fn) return {fn = fn} end\n  local function ConsCell(head, tail) return {head = head, tail = tail} end\nThe existing call sites (finalCell, consList, the `Cont(function() ... end)` in `go`) then work unchanged. Verified under Lua 5.1: yields {10,20,30}.\n```\n\n_Found by the FFI audit; reproduced under Lua 5.1._","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-06-15T11:23:51Z","url":"https://github.com/purescript-lua/purescript-lua/issues/73"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ee6c5e47-cc57-75bd-3601-a089cf97fb3f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id841C:4E3C:6A8D40:8F3CDC:6B00D600
html-safe-nonce2cb09e4f88af79ba827201d9beac63b202364b661eefa1c00bf6585292b3bd41
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDFDOjRFM0M6NkE4RDQwOjhGM0NEQzo2QjAwRDYwMCIsInZpc2l0b3JfaWQiOiI3NjU2NTAwNDk1MTMyOTcyNTQ0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacad1138432c8803e0564c43dbb2519ab8812b9135a25e63b064cd3783c917d39a
hovercard-subject-tagissue:4664606158
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/73/issue_layout
twitter:imagehttps://opengraph.githubassets.com/2596a207c0dfa5b4e2c871608f9be82b74a5021c251ced0feff58807c1130717/purescript-lua/purescript-lua/issues/73
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2596a207c0dfa5b4e2c871608f9be82b74a5021c251ced0feff58807c1130717/purescript-lua/purescript-lua/issues/73
og:image:altPackage: purescript-lua-arrays File: src/Data/Array/NonEmpty/Internal.lua Function: traverse1Impl Class: semantics Severity: high Faulty JS->Lua translation of the new ConsCell(...) / new Cont(...)...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameUnisay
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-preview
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/issues/73#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F73
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F73
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/73
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/73
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/73
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
https://github.com/purescript-lua/purescript-lua
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/73
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/73
[fork-ffi] arrays: traverse1Impl — Faulty JS->Lua translation of the new ConsCell(...) / `new…https://github.com/purescript-lua/purescript-lua/issues/73#top
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jun 15, 2026https://github.com/purescript-lua/purescript-lua/issues/73#issue-4664606158
Unisayhttps://github.com/Unisay
completedhttps://github.com/purescript-lua/purescript-lua/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
1579351https://github.com/purescript-lua/purescript-lua-arrays/commit/1579351579d43877b3c90a47ead9f88d8904c448
on Jun 15, 2026https://github.com/purescript-lua/purescript-lua/issues/73#event-26755067176
Sign up for freehttps://github.com/signup?return_to=https://github.com/purescript-lua/purescript-lua/issues/73
Sign in to commenthttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/73
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.