Title: Absorb the magic-do thunk despite an unforced saturated worker call · Issue #360 · purescript-lua/purescript-lua · GitHub
Open Graph Title: Absorb the magic-do thunk despite an unforced saturated worker call · Issue #360 · purescript-lua/purescript-lua
X Title: Absorb the magic-do thunk despite an unforced saturated worker call · Issue #360 · purescript-lua/purescript-lua
Description: Problem pslua represents an Effect/ST action as a nullary Lua thunk, and the absorbEffectThunk pass (Language.PureScript.Backend.IR.AbsorbEffectThunk, #265) removes an allocation of that thunk per executed statement. It applies to a work...
Open Graph Description: Problem pslua represents an Effect/ST action as a nullary Lua thunk, and the absorbEffectThunk pass (Language.PureScript.Backend.IR.AbsorbEffectThunk, #265) removes an allocation of that thunk per ...
X Description: Problem pslua represents an Effect/ST action as a nullary Lua thunk, and the absorbEffectThunk pass (Language.PureScript.Backend.IR.AbsorbEffectThunk, #265) removes an allocation of that thunk per ...
Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/360
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Absorb the magic-do thunk despite an unforced saturated worker call","articleBody":"## Problem\n\n`pslua` represents an `Effect`/`ST` action as a nullary Lua thunk, and the `absorbEffectThunk` pass (`Language.PureScript.Backend.IR.AbsorbEffectThunk`, #265) removes an allocation of that thunk per executed statement. It applies to a *worker* — the n-ary Lua function the uncurrying split extracts from a curried binding — whose body is such a thunk, by moving the thunk's parameter onto the worker's own parameter list, so a statement site `w(a, b)()` becomes the single call `w(a, b, run)`.\n\nWidening a worker's arity is only safe if every reference to it is rewritten too, so the pass first accounts for all of them and declines the binding unless each is either a statement site it rewrites or the delegate call of the binding's curried wrapper, which it grows by a matching parameter:\n\n```haskell\n accounted ∷ Qualified Name → Int → Bool\n accounted q _arity =\n count forced q > 0\n && count refs q == count forced q + count wrappers q\n```\n\nThe veto is therefore total: one reference of any other shape and the whole binding keeps its thunk, at every site. The shape that trips it most often in real code is a recursive effect action whose self-call is an *argument* rather than a statement, because an argument position is not forced:\n\n```purescript\nwalk :: Int -> Int -> Effect Unit\nwalk lo hi = do\n logShow lo\n when (lo \u003c hi) (walk (lo + 1) hi)\n```\n\nHere `when`'s second argument is the action `walk (lo + 1) hi`, which by the time this pass runs is the saturated worker call `walk$w(lo + 1, hi)` with no run applied to it. Every genuine *statement* site of `walk` is forced and would benefit, but that one argument reference vetoes all of them.\n\nThe reason for the veto is real but narrower than the veto itself. Rewriting an unforced saturated call means eta-expanding it — `walk$w(lo + 1, hi)` becomes `\\x -> walk$w(lo + 1, hi, x)`, which denotes the same action — and that moves when the arguments are read: before, they are read once where the thunk is built; after, on each call of the closure. For a wrapper's delegate call the arguments are the wrapper's own parameters, bound afresh per call and never reassigned, so the pass allows exactly that shape and nothing else. For an arbitrary call the arguments could in principle change between construction and run, which is why the boundary was drawn conservatively.\n\n## Approach\n\nAdmit an unforced saturated call whose arguments provably cannot change between the eta-expanded closure's construction and its call, and eta-expand it as the wrapper case already is. Arguments that are literals, or references to binders nothing ever reassigns, are the useful population; the delegate call the pass already accepts is the special case where this holds by construction.\n\nThe claim that needs establishing rather than assuming is what \"nothing ever reassigns\" means across the pipeline, because the property is not decided at the IR level where this pass runs. IR locals are immutable, but the Lua-level loop lowering (`Language.PureScript.Backend.Lua.Loopify` / `NativeLoop`) turns a self tail call into a `while` loop that *reassigns the function's parameters* — visible in the artifact this pass itself produces, where a driver's parameters are rebound per iteration:\n\n```lua\nlocal Bench_EffectStep_go_S_w = function(i, ref)\n while true do\n local _ = Bench_EffectStep_step_S_w(ref)\n if i >= 1 and i ~= 1 then\n i, ref = i - 1, ref\n else\n return Control_Monad_ST_Internal_read(ref)()\n end\n end\nend\n```\n\nSo an eta-expanded closure capturing `i` inside such a body, stored and run after an iteration, would read the *later* `i`. Whether that combination is reachable — the closure must escape its iteration for it to matter — is the question to settle first. Two routes: prove the escape cannot happen for the shapes admitted, or restrict admission to arguments the loop lowering demonstrably never rebinds. Either way the answer belongs in a `Note [...]` at the site, because it is a cross-level invariant that a future change to the loop lowering could break silently.\n\n## Verification / Measurement\n\n`Golden.EffectWorkerThunk` already pins the veto from the outside: its `deferred` binding keeps the call-then-force shape because its worker call is bound as an action value and run later. That case must stay vetoed — the action is stored, so re-reading its arguments at run time is exactly the hazard — while a `walk`-shaped module with the self-call under `when` should move from vetoed to absorbed, both with their `eval/golden.txt` oracles unchanged. A golden pairing an admitted eta-expansion with a loopified enclosing worker is what would pin the cross-level claim, and is worth writing even if the analysis concludes the combination is unreachable.\n\nFor a number, the `Bench.EffectStep2` macrobenchmark is the closest existing driver, but its step is already absorbed; a `when`-guarded recursive variant would be the spec that isolates this case.\n\n## Prerequisites / Relations\n\nBuilds on #265, which added the pass and drew the current boundary. Independent of #342 and of the code generator's own thunk shed.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-30T10:20:41Z","url":"https://github.com/purescript-lua/purescript-lua/issues/360"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6c181bb9-99f3-07ba-c208-39571a9ce1eb |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A2D6:16EED3:4DDC17:64BE0A:6B00D930 |
| html-safe-nonce | e4f5d4889dcb0499359deb16c240631a39959a2b9f62fc6b8da43ff1c4747c75 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkQ2OjE2RUVEMzo0RERDMTc6NjRCRTBBOjZCMDBEOTMwIiwidmlzaXRvcl9pZCI6IjkwNDQ4MzIzMTQwMzQ1NDI4OTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 6b707218f5293daa349e6f783028a45210fb5fd9abbb16c7ecdf8982d8426a4f |
| hovercard-subject-tag | issue:5018707751 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/360/issue_layout |
| twitter:image | https://opengraph.githubassets.com/1033b4abe26c6d6b17adb652b1dfe47e09235c0e0a044707004c24d8813f4480/purescript-lua/purescript-lua/issues/360 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1033b4abe26c6d6b17adb652b1dfe47e09235c0e0a044707004c24d8813f4480/purescript-lua/purescript-lua/issues/360 |
| og:image:alt | Problem pslua represents an Effect/ST action as a nullary Lua thunk, and the absorbEffectThunk pass (Language.PureScript.Backend.IR.AbsorbEffectThunk, #265) removes an allocation of that thunk per ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Unisay |
| hostname | github.com |
| expected-hostname | github.com |
| None | a481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b |
| turbo-cache-control | no-preview |
| go-import | github.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git |
| octolytics-dimension-user_id | 131581790 |
| octolytics-dimension-user_login | purescript-lua |
| octolytics-dimension-repository_id | 587200487 |
| octolytics-dimension-repository_nwo | purescript-lua/purescript-lua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 587200487 |
| octolytics-dimension-repository_network_root_nwo | purescript-lua/purescript-lua |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84c8c5cc25e2fb7f2308428458538436baecc6d2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width