René's URL Explorer Experiment


Title: Splice a discarded applied function literal, not only a tail-position one · Issue #359 · purescript-lua/purescript-lua · GitHub

Open Graph Title: Splice a discarded applied function literal, not only a tail-position one · Issue #359 · purescript-lua/purescript-lua

X Title: Splice a discarded applied function literal, not only a tail-position one · Issue #359 · purescript-lua/purescript-lua

Description: Problem pslua represents an Effect/ST action as a nullary Lua thunk, and the magic-do pass lowers a do block into one such thunk holding a flat statement sequence. When the optimizer inlines an action's body at a call site, the result is...

Open Graph Description: Problem pslua represents an Effect/ST action as a nullary Lua thunk, and the magic-do pass lowers a do block into one such thunk holding a flat statement sequence. When the optimizer inlines an act...

X Description: Problem pslua represents an Effect/ST action as a nullary Lua thunk, and the magic-do pass lowers a do block into one such thunk holding a flat statement sequence. When the optimizer inlines an act...

Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/359

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Splice a discarded applied function literal, not only a tail-position one","articleBody":"## Problem\n\n`pslua` represents an `Effect`/`ST` action as a nullary Lua thunk, and the magic-do pass lowers a `do` block into one such thunk holding a flat statement sequence. When the optimizer inlines an action's body at a call site, the result is a *literal* thunk that is built and immediately called — a closure allocation and a call whose only purpose is to run statements that could sit in the parent function directly.\n\nThe Lua-level optimizer already removes this, budgeted, in one position. `collapseTailLiteralApplication` (`Language.PureScript.Backend.Lua.Optimizer`) splices the literal's body into its parent when the merged body still fits the local-variable ceiling — the splice undoes exactly the chunking magic-do uses to keep any one function's locals under Lua 5.1's `LUAI_MAXVARS` of 200 (#19), so it re-checks that budget rather than assuming it:\n\n```haskell\ncollapseTailLiteralApplication ∷ LuaLimits → RewriteRule\ncollapseTailLiteralApplication limits = \\case\n  Function params body\n    | Just (leading, binding, spliced) ← matchTailLiteralApplication body\n    , not (chunkScopeUsesVararg spliced)\n    , let merged = leading \u003c> binding \u003c> spliced\n    , length params + activationLocalSlots merged\n        \u003c= workingLocalCeiling limits →\n```\n\nIts matcher, however, only recognises the literal in *tail* position — a function body whose last statement is a `Return` of the applied literal:\n\n```haskell\n  matchTailLiteralApplication body = case reverse body of\n    Ann (Return [Ann (FunctionCall (Ann (Function params spliced)) args)])\n      : reverseLeading → do\n```\n\nA magic-do effect statement is not in tail position. It is a discarded `local` binding, because the statement's value is unused and only its effect matters, so the inlined action lands as `local _ = (function() … end)()` and the rule never sees it. From `Golden.EffectWorkerThunk`, where the two-statement body of `runWith` was pasted into its one call site:\n\n```lua\n  local _ = (function()\n    local _ = Golden_EffectWorkerThunk_Test_tally_S_w(\"via\", 3)\n    return Effect_Console_log(\"ran\")()\n  end)()\n```\n\nTwo locals in the parent's budget would admit the splice with room to spare, yet the closure is allocated and called every time this statement runs. Across the golden corpus there are 84 applied-literal sites in this discarded-binding position, against 153 in the tail position the existing rule covers.\n\n## Approach\n\nExtend the reach of the existing rule (or add a sibling sharing its conditions) to an applied function literal that is the right-hand side of a statement whose value is discarded. Every guard the tail case already checks carries over unchanged and should be reused rather than restated: the vararg guard (`chunkScopeUsesVararg`), the parameter binding built from the call's arguments, and the `length params + activationLocalSlots merged \u003c= workingLocalCeiling limits` budget that keeps the splice from undoing magic-do's chunking.\n\nOne condition is new, and it is what bounds the change. The tail case splices a body whose value becomes the parent's return value, so the body's `return` needs no rewriting. In statement position the value is discarded, so the body's trailing `return e` has to become a discarded statement of `e` — and any *other* `return` in the body, for instance inside an `if` branch, would after splicing return from the *parent* function instead of from the thunk. The rewrite must therefore be restricted to a body whose only `return` is its last statement, which is the shape magic-do itself emits; a body with branching returns keeps its thunk.\n\n## Verification / Measurement\n\nThe `runWith` site in `Golden.EffectWorkerThunk` is the minimal positive case: a two-local body with a single trailing return, whose `local _ = (function() … end)()` should become the two statements spliced into the enclosing block, with `eval/golden.txt` unchanged. A golden whose thunk body returns from inside a branch pins the negative side and is the one shape that must keep its closure. Because the parent of a spliced body can itself be spliced, the fixpoint behaviour the tail rule already documents (it re-applies itself to the merged function) needs the same treatment here.\n\nA wall-clock number needs a benchmark whose hot loop executes such a statement; none of the current `bench/macro` specs does, since an inlined action in a hot loop tends to be in tail position. Whether the win is worth a new spec can be judged from the counter oracles first: each spliced site removes one `FNEW` from a function body, which `bench/tools/fnew_census.lua` counts statically and which aborts LuaJIT trace recording (`NYI: bytecode FNEW`) when it sits in a hot path.\n\n## Prerequisites / Relations\n\nIndependent. #342 widens a *different* guard — the code generator's own shed in `Language.PureScript.Backend.Lua`, which drops a literal thunk applied to the effect-run marker when the thunk's body is a call, and which #342 extends to any body that lowers to an expression. That shed cannot handle a body of statements at all, and explicitly leaves such bodies thunked; this issue is about the Lua-level optimizer that runs afterwards and *can* splice statements, given the budget. The two are complementary and neither blocks the other.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-30T10:20:31Z","url":"https://github.com/purescript-lua/purescript-lua/issues/359"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:019d4655-7dca-4095-a929-2fe6278799d6
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE94A:33444D:6CF404:92F946:6B00D93E
html-safe-nonce76ba1413d8572c0df873de207dc78c731db9a7cb6c182d0c3061a94163afc325
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTRBOjMzNDQ0RDo2Q0Y0MDQ6OTJGOTQ2OjZCMDBEOTNFIiwidmlzaXRvcl9pZCI6IjE1OTc2NDA0NDk0Nzk3MDM2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc61e85f9b4e5ee1045dce18b7d5bcf0056d477ad58e92d1a5c5d41051c42b383
hovercard-subject-tagissue:5018706472
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/359/issue_layout
twitter:imagehttps://opengraph.githubassets.com/108658b5048066ead8f690a0e8fc49cdc537adb1f18fd85fbbc0e0aa9349f84b/purescript-lua/purescript-lua/issues/359
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/108658b5048066ead8f690a0e8fc49cdc537adb1f18fd85fbbc0e0aa9349f84b/purescript-lua/purescript-lua/issues/359
og:image:altProblem pslua represents an Effect/ST action as a nullary Lua thunk, and the magic-do pass lowers a do block into one such thunk holding a flat statement sequence. When the optimizer inlines an act...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameUnisay
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-preview
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/issues/359#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F359
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F359
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/359
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/359
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/359
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
https://github.com/purescript-lua/purescript-lua
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/359
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/359
Splice a discarded applied function literal, not only a tail-position onehttps://github.com/purescript-lua/purescript-lua/issues/359#top
OptimisationA Compiler Optimisationhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22Optimisation%22
area: codegenLua code generation / printinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20codegen%22
enhancementNew feature or requesthttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jul 30, 2026https://github.com/purescript-lua/purescript-lua/issues/359#issue-5018706472
#19https://github.com/purescript-lua/purescript-lua/issues/19
#342https://github.com/purescript-lua/purescript-lua/issues/342
#342https://github.com/purescript-lua/purescript-lua/issues/342
Unisayhttps://github.com/Unisay
enhancementNew feature or requesthttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22enhancement%22
area: codegenLua code generation / printinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20codegen%22
OptimisationA Compiler Optimisationhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22Optimisation%22
on Jul 30, 2026https://github.com/purescript-lua/purescript-lua/issues/359#event-28714204448
Sign up for freehttps://github.com/signup?return_to=https://github.com/purescript-lua/purescript-lua/issues/359
Sign in to commenthttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/359
OptimisationA Compiler Optimisationhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22Optimisation%22
area: codegenLua code generation / printinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20codegen%22
enhancementNew feature or requesthttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.