René's URL Explorer Experiment


Title: Let a rewrite-budget exhaustion stop the enclosing pass fixpoint · Issue #352 · purescript-lua/purescript-lua · GitHub

Open Graph Title: Let a rewrite-budget exhaustion stop the enclosing pass fixpoint · Issue #352 · purescript-lua/purescript-lua

X Title: Let a rewrite-budget exhaustion stop the enclosing pass fixpoint · Issue #352 · purescript-lua/purescript-lua

Description: Problem pslua's IR optimizer runs its passes inside fixpoint combinators: RunFixpoint "optimize+dce" re-runs optimize and dce until a whole round reports no change, bounded by maxFixpointIterations (1000). Whether a round changed anythin...

Open Graph Description: Problem pslua's IR optimizer runs its passes inside fixpoint combinators: RunFixpoint "optimize+dce" re-runs optimize and dce until a whole round reports no change, bounded by maxFixpointIterations...

X Description: Problem pslua's IR optimizer runs its passes inside fixpoint combinators: RunFixpoint "optimize+dce" re-runs optimize and dce until a whole round reports no change, bounded by maxFixp...

Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/352

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Let a rewrite-budget exhaustion stop the enclosing pass fixpoint","articleBody":"## Problem\n\n`pslua`'s IR optimizer runs its passes inside fixpoint combinators: `RunFixpoint \"optimize+dce\"` re-runs `optimize` and `dce` until a whole round reports no change, bounded by `maxFixpointIterations` (1000). Whether a round changed anything comes from each pass's `WasRewritten` flag, which the fixpoint trusts:\n\n```haskell\n      loop ∷ Natural → UberModule → SupplyM UberModule\n      loop 0 uber = pure uber -- cap reached: accept (see the module doc)\n      loop n uber =\n        runRound passRun uber (toList passes) >>= \\case\n          (uber', Rewritten) → loop (n - 1) uber'\n          (uber', Unmodified) → pure uber'\n```\n\nBelow that sits the rewrite driver `rewriteExpBottomUpM`, which re-applies the rule set at a node until it stops firing — now bounded by `maxNestedRewrites` (100) so that a term with no normal form cannot livelock it (#348). When that budget runs out the driver abandons the redex and reports `Rewritten`, which is accurate: it did change the term. But it is also indistinguishable from ordinary progress, so the enclosing fixpoint keeps iterating, advances the same non-converging term by another 100 steps per round, and only stops at its own 1000-round cap.\n\n## How it shows up\n\nAs wasted work on inputs the optimizer cannot finish, and it is measurable in the test suite that #348 came from. The `IR Optimizer` spec group used to cost 0.35 s; it now costs about 3 s at *every* hspec seed, because the example-based regression test added with #348 deliberately drives the budget to exhaustion twice:\n\n```\n$ for s in $(seq 1 500); do timeout 60 $SPEC --match \"IR Optimizer\" --seed $s; done\nworst_elapsed=6s\nfailures:\n```\n\nThe three seeds whose generated draw contains the diverging term add ~2 s on top of that floor (109 → 6 s, 152 and 478 → 5 s). Full-suite wall clock absorbs it at 88 s, so this is a cost worth removing rather than an emergency.\n\nThe diagnostic side is the more interesting half. With invariant checking on — `runStepsChecked`, used by the test suite always and by the CLI behind `--lint-ir` — the exhausted budget currently surfaces one level too high, as the fixpoint reporting that it never converged:\n\n```haskell\noptimizedUberModuleChecked mempty original\n  === Left (FixpointDivergence \"optimize+dce\" maxFixpointIterations)\n```\n\nThat names the fixpoint but not the culprit. The driver knows exactly which node it gave up on and which rule kept firing on it; none of that reaches the report.\n\n## Approach\n\nLet budget exhaustion be a distinct outcome rather than collapsing into `Rewritten`, and let the fixpoint stop on it instead of iterating into its cap.\n\nThe plumbing is the cost. `rewriteExpBottomUpM` returns `m (RawExp ann, WasRewritten)` and would need a third component (or a richer accumulator in its `WriterT`); `Pass`'s `passRun ∷ UberModule → SupplyM (UberModule, WasRewritten)` would need the same, which touches every pass constructed in `Language.PureScript.Backend.IR.Optimizer` and all three runners in `Language.PureScript.Backend.IR.Pass` (`runSteps`, `runStepsChecked`, `runStepsTraced`). `Language.PureScript.Backend.IR.DCE` also drives the bottom-up rewriter and would have to pass the signal through.\n\nTwo properties must survive the change. The production runner must keep accepting the module it has reached — every pass is semantics-preserving, so an early stop costs optimization and never correctness, and a compiler that refused to emit code for a term it could not fully normalize would be strictly worse. And `Unmodified` must keep meaning \"structurally identical\", since `runStepsChecked` compares a module a pass claims unchanged against its input and fails with `PassUnreportedChange`.\n\nThe payoff is both halves of the problem at once: the fixpoint stops at the first exhausted round instead of spending 1000, and the checked runner can name the pass, the rule and the node rather than only the fixpoint.\n\n## Verification / Measurement\n\nThe wall-clock claim is the check: `$SPEC --match \"IR Optimizer\" --seed 109` should drop from ~6 s toward the ~0.35 s the group cost before #348, and the every-seed floor should drop with it. Record before/after numbers rather than asserting an improvement.\n\nThe golden corpus must stay byte-identical. No real compilation exhausts the budget — PureScript's type system rejects every term without a normal form — so a change that moves any `golden.ir` or `golden.lua` has altered ordinary convergence, not just the give-up path.\n\nThe diagnostic improvement wants a test of its own: the #348 regression module should report the offending pass and node, replacing the current assertion that only names `optimize+dce`.\n\n## Prerequisites / Relations\n\nDepends on #348, which is merged: `maxNestedRewrites` and the give-up path it introduced are what this change makes legible.\n\nBuilds on #351, which puts the same bound on the sibling top-down driver: if both drivers end up reporting exhaustion they should report it the same way, so #351 is worth doing first, or the signal designed for both at once. Not a hard blocker — this change stands alone if #351 is dropped.\n\n## Acceptance criteria\n\n- An exhausted rewrite budget stops the enclosing fixpoint on the round it happens, instead of iterating to `maxFixpointIterations`.\n- The production pipeline still returns the module reached, with no error path added for a term it could not normalize.\n- Under `runStepsChecked` the report identifies the pass and the abandoned node, not just the fixpoint's name.\n- Before/after timings for the `IR Optimizer` group are recorded, at seed 109 and at a seed that does not draw a diverging term.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-29T11:18:32Z","url":"https://github.com/purescript-lua/purescript-lua/issues/352"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:b05642c0-e015-ef80-4ee0-11351883f719
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBF5A:311640:4E851B:655376:6B00D93A
html-safe-noncece6fcb7674fc8d7154adc775ae5a338492288c3532c3f4e3a98c3119f424d992
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjVBOjMxMTY0MDo0RTg1MUI6NjU1Mzc2OjZCMDBEOTNBIiwidmlzaXRvcl9pZCI6IjU1MTE0MjI1MDEyNjUxMzU5MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac97d0fcdd96528425c60ed5593bf5551e668da6aef344e4a146f82e48ffd0d94b
hovercard-subject-tagissue:5008619904
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/352/issue_layout
twitter:imagehttps://opengraph.githubassets.com/4da469ff19abada5f256573710f9b4b184c7e901eb5915e6f3f4766b3f0fde62/purescript-lua/purescript-lua/issues/352
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4da469ff19abada5f256573710f9b4b184c7e901eb5915e6f3f4766b3f0fde62/purescript-lua/purescript-lua/issues/352
og:image:altProblem pslua's IR optimizer runs its passes inside fixpoint combinators: RunFixpoint "optimize+dce" re-runs optimize and dce until a whole round reports no change, bounded by maxFixpointIterations...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameUnisay
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-preview
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/issues/352#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F352
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F352
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/352
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/352
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/352
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
https://github.com/purescript-lua/purescript-lua
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/352
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/352
Let a rewrite-budget exhaustion stop the enclosing pass fixpointhttps://github.com/purescript-lua/purescript-lua/issues/352#top
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
choreMaintenance / infrastructurehttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22chore%22
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jul 29, 2026https://github.com/purescript-lua/purescript-lua/issues/352#issue-5008619904
#348https://github.com/purescript-lua/purescript-lua/issues/348
#348https://github.com/purescript-lua/purescript-lua/issues/348
#348https://github.com/purescript-lua/purescript-lua/issues/348
#348https://github.com/purescript-lua/purescript-lua/issues/348
#348https://github.com/purescript-lua/purescript-lua/issues/348
#348https://github.com/purescript-lua/purescript-lua/issues/348
#351https://github.com/purescript-lua/purescript-lua/issues/351
#351https://github.com/purescript-lua/purescript-lua/issues/351
#351https://github.com/purescript-lua/purescript-lua/issues/351
Unisayhttps://github.com/Unisay
enhancementNew feature or requesthttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22enhancement%22
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
OptimisationA Compiler Optimisationhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22Optimisation%22
choreMaintenance / infrastructurehttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22chore%22
enhancementNew feature or requesthttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22enhancement%22
OptimisationA Compiler Optimisationhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22Optimisation%22
on Jul 29, 2026https://github.com/purescript-lua/purescript-lua/issues/352#event-28655848754
Sign up for freehttps://github.com/signup?return_to=https://github.com/purescript-lua/purescript-lua/issues/352
Sign in to commenthttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/352
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
choreMaintenance / infrastructurehttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22chore%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.