Title: Let a rewrite-budget exhaustion stop the enclosing pass fixpoint · Issue #352 · purescript-lua/purescript-lua · GitHub
Open Graph Title: Let a rewrite-budget exhaustion stop the enclosing pass fixpoint · Issue #352 · purescript-lua/purescript-lua
X Title: Let a rewrite-budget exhaustion stop the enclosing pass fixpoint · Issue #352 · purescript-lua/purescript-lua
Description: Problem pslua's IR optimizer runs its passes inside fixpoint combinators: RunFixpoint "optimize+dce" re-runs optimize and dce until a whole round reports no change, bounded by maxFixpointIterations (1000). Whether a round changed anythin...
Open Graph Description: Problem pslua's IR optimizer runs its passes inside fixpoint combinators: RunFixpoint "optimize+dce" re-runs optimize and dce until a whole round reports no change, bounded by maxFixpointIterations...
X Description: Problem pslua's IR optimizer runs its passes inside fixpoint combinators: RunFixpoint "optimize+dce" re-runs optimize and dce until a whole round reports no change, bounded by maxFixp...
Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/352
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Let a rewrite-budget exhaustion stop the enclosing pass fixpoint","articleBody":"## Problem\n\n`pslua`'s IR optimizer runs its passes inside fixpoint combinators: `RunFixpoint \"optimize+dce\"` re-runs `optimize` and `dce` until a whole round reports no change, bounded by `maxFixpointIterations` (1000). Whether a round changed anything comes from each pass's `WasRewritten` flag, which the fixpoint trusts:\n\n```haskell\n loop ∷ Natural → UberModule → SupplyM UberModule\n loop 0 uber = pure uber -- cap reached: accept (see the module doc)\n loop n uber =\n runRound passRun uber (toList passes) >>= \\case\n (uber', Rewritten) → loop (n - 1) uber'\n (uber', Unmodified) → pure uber'\n```\n\nBelow that sits the rewrite driver `rewriteExpBottomUpM`, which re-applies the rule set at a node until it stops firing — now bounded by `maxNestedRewrites` (100) so that a term with no normal form cannot livelock it (#348). When that budget runs out the driver abandons the redex and reports `Rewritten`, which is accurate: it did change the term. But it is also indistinguishable from ordinary progress, so the enclosing fixpoint keeps iterating, advances the same non-converging term by another 100 steps per round, and only stops at its own 1000-round cap.\n\n## How it shows up\n\nAs wasted work on inputs the optimizer cannot finish, and it is measurable in the test suite that #348 came from. The `IR Optimizer` spec group used to cost 0.35 s; it now costs about 3 s at *every* hspec seed, because the example-based regression test added with #348 deliberately drives the budget to exhaustion twice:\n\n```\n$ for s in $(seq 1 500); do timeout 60 $SPEC --match \"IR Optimizer\" --seed $s; done\nworst_elapsed=6s\nfailures:\n```\n\nThe three seeds whose generated draw contains the diverging term add ~2 s on top of that floor (109 → 6 s, 152 and 478 → 5 s). Full-suite wall clock absorbs it at 88 s, so this is a cost worth removing rather than an emergency.\n\nThe diagnostic side is the more interesting half. With invariant checking on — `runStepsChecked`, used by the test suite always and by the CLI behind `--lint-ir` — the exhausted budget currently surfaces one level too high, as the fixpoint reporting that it never converged:\n\n```haskell\noptimizedUberModuleChecked mempty original\n === Left (FixpointDivergence \"optimize+dce\" maxFixpointIterations)\n```\n\nThat names the fixpoint but not the culprit. The driver knows exactly which node it gave up on and which rule kept firing on it; none of that reaches the report.\n\n## Approach\n\nLet budget exhaustion be a distinct outcome rather than collapsing into `Rewritten`, and let the fixpoint stop on it instead of iterating into its cap.\n\nThe plumbing is the cost. `rewriteExpBottomUpM` returns `m (RawExp ann, WasRewritten)` and would need a third component (or a richer accumulator in its `WriterT`); `Pass`'s `passRun ∷ UberModule → SupplyM (UberModule, WasRewritten)` would need the same, which touches every pass constructed in `Language.PureScript.Backend.IR.Optimizer` and all three runners in `Language.PureScript.Backend.IR.Pass` (`runSteps`, `runStepsChecked`, `runStepsTraced`). `Language.PureScript.Backend.IR.DCE` also drives the bottom-up rewriter and would have to pass the signal through.\n\nTwo properties must survive the change. The production runner must keep accepting the module it has reached — every pass is semantics-preserving, so an early stop costs optimization and never correctness, and a compiler that refused to emit code for a term it could not fully normalize would be strictly worse. And `Unmodified` must keep meaning \"structurally identical\", since `runStepsChecked` compares a module a pass claims unchanged against its input and fails with `PassUnreportedChange`.\n\nThe payoff is both halves of the problem at once: the fixpoint stops at the first exhausted round instead of spending 1000, and the checked runner can name the pass, the rule and the node rather than only the fixpoint.\n\n## Verification / Measurement\n\nThe wall-clock claim is the check: `$SPEC --match \"IR Optimizer\" --seed 109` should drop from ~6 s toward the ~0.35 s the group cost before #348, and the every-seed floor should drop with it. Record before/after numbers rather than asserting an improvement.\n\nThe golden corpus must stay byte-identical. No real compilation exhausts the budget — PureScript's type system rejects every term without a normal form — so a change that moves any `golden.ir` or `golden.lua` has altered ordinary convergence, not just the give-up path.\n\nThe diagnostic improvement wants a test of its own: the #348 regression module should report the offending pass and node, replacing the current assertion that only names `optimize+dce`.\n\n## Prerequisites / Relations\n\nDepends on #348, which is merged: `maxNestedRewrites` and the give-up path it introduced are what this change makes legible.\n\nBuilds on #351, which puts the same bound on the sibling top-down driver: if both drivers end up reporting exhaustion they should report it the same way, so #351 is worth doing first, or the signal designed for both at once. Not a hard blocker — this change stands alone if #351 is dropped.\n\n## Acceptance criteria\n\n- An exhausted rewrite budget stops the enclosing fixpoint on the round it happens, instead of iterating to `maxFixpointIterations`.\n- The production pipeline still returns the module reached, with no error path added for a term it could not normalize.\n- Under `runStepsChecked` the report identifies the pass and the abandoned node, not just the fixpoint's name.\n- Before/after timings for the `IR Optimizer` group are recorded, at seed 109 and at a seed that does not draw a diverging term.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-29T11:18:32Z","url":"https://github.com/purescript-lua/purescript-lua/issues/352"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:b05642c0-e015-ef80-4ee0-11351883f719 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BF5A:311640:4E851B:655376:6B00D93A |
| html-safe-nonce | ce6fcb7674fc8d7154adc775ae5a338492288c3532c3f4e3a98c3119f424d992 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjVBOjMxMTY0MDo0RTg1MUI6NjU1Mzc2OjZCMDBEOTNBIiwidmlzaXRvcl9pZCI6IjU1MTE0MjI1MDEyNjUxMzU5MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 97d0fcdd96528425c60ed5593bf5551e668da6aef344e4a146f82e48ffd0d94b |
| hovercard-subject-tag | issue:5008619904 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/352/issue_layout |
| twitter:image | https://opengraph.githubassets.com/4da469ff19abada5f256573710f9b4b184c7e901eb5915e6f3f4766b3f0fde62/purescript-lua/purescript-lua/issues/352 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4da469ff19abada5f256573710f9b4b184c7e901eb5915e6f3f4766b3f0fde62/purescript-lua/purescript-lua/issues/352 |
| og:image:alt | Problem pslua's IR optimizer runs its passes inside fixpoint combinators: RunFixpoint "optimize+dce" re-runs optimize and dce until a whole round reports no change, bounded by maxFixpointIterations... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Unisay |
| hostname | github.com |
| expected-hostname | github.com |
| None | a481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b |
| turbo-cache-control | no-preview |
| go-import | github.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git |
| octolytics-dimension-user_id | 131581790 |
| octolytics-dimension-user_login | purescript-lua |
| octolytics-dimension-repository_id | 587200487 |
| octolytics-dimension-repository_nwo | purescript-lua/purescript-lua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 587200487 |
| octolytics-dimension-repository_network_root_nwo | purescript-lua/purescript-lua |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84c8c5cc25e2fb7f2308428458538436baecc6d2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width